[Payment due @gijoe0295] Add Onyx failure data for handling errors during VBBA setup by akinwale · Pull Request #88735 · Expensify/App

akinwale · 2026-04-24T17:18:26Z

Explanation of Change

Adds Onyx failure data for handling errors that may occur during VBBA setup.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/609462
PROPOSAL:

Tests

Launch Expensify
Create a new workspace if none exist, or select an existing workspace.
Navigate to Workspace settings > Workflows and click Add bank account.
Add a new bank account using Plaid.
Continue the VBBA flow until the end of the Personal Information section is reached.
Simulate a request failure after clicking on the Confirm button.
Navigate back to the bank account step and verify that the Plaid account information is still present.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-04-29.at.06.49.40.mp4

melvin-bot · 2026-04-24T17:18:32Z

@gijoe0295 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 68d08a1c65

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-24T17:32:47Z

+    if (currentStep != CONST.BANK_ACCOUNT.STEP.REQUESTOR) {
+        failureData.push({
+            onyxMethod: Onyx.METHOD.SET,
+            key: ONYXKEYS.ONFIDO_TOKEN,
+            value: null


Avoid clearing Onfido state when step is omitted

This condition resets ONFIDO_TOKEN whenever currentStep is anything other than REQUESTOR, but several VBBA writes (notably verifyIdentityForBankAccount()) call getVBBADataForOnyx() without passing a step, so transient API failures during identity verification now clear the token/applicant ID and force users to restart Onfido instead of retrying in place. Restrict this reset to explicit steps that require it (or pass REQUESTOR from requestor-flow callers).

Useful? React with 👍 / 👎.

When verifyIdentityForBankAccount fails, user is redirected back to personal information step and must go through Onfido verification again. This is not a bug

codecov · 2026-04-24T18:21:32Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/BankAccounts.ts	`10.81% <83.33%> (+1.39%)`	⬆️
... and 5 files with indirect coverage changes

gijoe0295 · 2026-04-27T09:42:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-04-30.at.21.45.02.mov

trjExpensify · 2026-04-27T11:17:25Z

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

gijoe0295 · 2026-04-27T18:41:19Z

The function is reused in pretty many places. I'm still testing other scenarios. Should complete tomorrow

gijoe0295 · 2026-04-28T16:32:07Z

+            value: null,
+        },
+    ];
+    if ((currentStep ?? null) !== CONST.BANK_ACCOUNT.STEP.REQUESTOR) {


Why do we need ?? null?

Removed this. I was checking if it fixed a particular codex review.

gijoe0295 · 2026-04-28T16:51:45Z

When connecting using Plaid and UpdatePersonalInformationForBankAccount fails, going back to BankInfo step opens Plaid linking step (user needs to link Plaid again because plaidData and token were cleared):

This PR (2:25):

Screen.Recording.2026-04-28.at.23.48.21.mov

Staging (0:14):

Screen.Recording.2026-04-28.at.23.13.52.mov

… the start of the VBBA flow

gijoe0295

LGTM

melvin-bot · 2026-04-30T14:45:54Z

🎯 @gijoe0295, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/609462.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

gijoe0295

LGTM

melvin-bot · 2026-05-02T00:10:53Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-05-02T00:11:15Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-05-02T00:11:25Z

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2026-05-05T19:23:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-05T21:00:25Z

🚧 @madmax330 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-05T21:18:51Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88735.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b0a9339-0c47e0c-1b10814c5da23dc84621498fe3fd031854b5d82b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b0a9339-0c47e0c-d918fa3e154bfa9b5b6426d45ca93f11658c22a6/index.html

Web 🕸️
https://88735.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-06T22:52:33Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.3.68-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-06T22:54:43Z

I reviewed the changes in this PR. The modifications are limited to src/libs/actions/BankAccounts.ts and are purely technical — they add Onyx failure data (clearing Plaid link tokens, Onfido tokens, and setting error state) for handling API request failures during VBBA setup.

No user-facing features, flows, UI labels, or settings were added or changed. The existing bank account setup flow and its steps remain the same; this PR only improves how errors are handled internally when a request fails mid-flow.

No help site changes are required.

OSBotify · 2026-05-08T15:10:38Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.68-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot · 2026-05-08T15:16:21Z

🤖 Payment issue created: #90008

add Onyx failure data for handling errors during VBBA setup

68d08a1

akinwale requested review from a team as code owners April 24, 2026 17:18

melvin-bot Bot assigned akinwale Apr 24, 2026

melvin-bot Bot requested a review from gijoe0295 April 24, 2026 17:18

melvin-bot Bot requested review from trjExpensify and removed request for a team April 24, 2026 17:18

chatgpt-codex-connector Bot reviewed Apr 24, 2026

View reviewed changes

akinwale added 2 commits April 24, 2026 18:57

fix lint and prettier errors

2a1bcc6

fix onyx data types for the getVBBADataForOnyx method

c3b2bf2

trjExpensify removed their request for review April 27, 2026 11:17

gijoe0295 suggested changes Apr 28, 2026

View reviewed changes

Comment thread src/libs/actions/BankAccounts.ts Outdated

gijoe0295 reviewed Apr 28, 2026

View reviewed changes

This comment was marked as outdated.

Sign in to view

akinwale changed the title ~~[No QA] add Onyx failure data for handling errors during VBBA setup~~ Add Onyx failure data for handling errors during VBBA setup Apr 29, 2026

akinwale added 3 commits April 29, 2026 06:42

avoid resetting Plaid data to prevent getting stuck when returning to…

5a6c2b8

… the start of the VBBA flow

Merge remote-tracking branch 'origin/main' into task-609462-app

8cd984d

fix TypeScript check, PLAID_LINK_TOKEN -> RAM_ONLY_PLAID_LINK_TOKEN

f2372af

akinwale requested a review from gijoe0295 April 29, 2026 06:15

gijoe0295 approved these changes Apr 30, 2026

View reviewed changes

melvin-bot Bot changed the title ~~Add Onyx failure data for handling errors during VBBA setup~~ [Payment due @gijoe0295] Add Onyx failure data for handling errors during VBBA setup Apr 30, 2026

gijoe0295 approved these changes Apr 30, 2026

View reviewed changes

akinwale requested review from a team and madmax330 May 2, 2026 00:10

melvin-bot Bot requested review from parasharrajat and removed request for a team May 2, 2026 00:10

akinwale requested review from a team and removed request for bernhardoj May 2, 2026 00:11

melvin-bot Bot requested a review from jayeshmangwani May 2, 2026 00:11

melvin-bot Bot removed the request for review from a team May 2, 2026 00:11

akinwale requested review from a team and removed request for parasharrajat May 2, 2026 00:11

melvin-bot Bot requested a review from dmkt9 May 2, 2026 00:11

melvin-bot Bot removed the request for review from a team May 2, 2026 00:11

akinwale requested review from iwiznia and removed request for dmkt9 and jayeshmangwani May 2, 2026 00:11

iwiznia approved these changes May 4, 2026

View reviewed changes

madmax330 approved these changes May 5, 2026

View reviewed changes

madmax330 merged commit b0a9339 into Expensify:main May 5, 2026
48 checks passed

OSBotify mentioned this pull request May 6, 2026

Deploy Checklist: New Expensify 2026-05-06 #89819

Closed

73 tasks

melvin-bot Bot mentioned this pull request May 8, 2026

[Due for payment 2026-05-15] Payment issue for E/App PR#88735 #90008

Open

Conversation

akinwale commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

gijoe0295 Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Apr 24, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gijoe0295 commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

trjExpensify commented Apr 27, 2026

Uh oh!

gijoe0295 commented Apr 27, 2026

Uh oh!

Uh oh!

gijoe0295 Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

akinwale Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

gijoe0295 commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gijoe0295 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Apr 30, 2026

Uh oh!

gijoe0295 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 2, 2026

Uh oh!

melvin-bot Bot commented May 2, 2026

Uh oh!

melvin-bot Bot commented May 2, 2026

Uh oh!

Uh oh!

OSBotify commented May 5, 2026

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

OSBotify commented May 6, 2026

Uh oh!

MelvinBot commented May 6, 2026

Uh oh!

OSBotify commented May 8, 2026

Uh oh!

melvin-bot Bot commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

akinwale commented Apr 24, 2026 •

edited

Loading

codecov Bot commented Apr 24, 2026 •

edited by github-actions Bot

Loading

gijoe0295 commented Apr 27, 2026 •

edited

Loading

gijoe0295 commented Apr 28, 2026 •

edited

Loading