Use correct cardName translation key for personal card rename flow by MelvinBot · Pull Request #88736 · Expensify/App

MelvinBot · 2026-04-24T17:19:17Z

Explanation of Change

The personal card edit name page and card details header menu were using the workspace.moreFeatures.companyCards.cardNumber translation key (which resolves to "Card number") instead of workspace.moreFeatures.companyCards.cardName (which resolves to "Card name"). This caused the label to incorrectly show "Card number" instead of "Card name" when editing a personal card's name.

Changed 4 occurrences of the wrong key across two files:

PersonalCardEditNamePage.tsx: header title, input label, and aria-label
PersonalCardDetailsHeaderMenu.tsx: menu item description

Fixed Issues

$ #88555
PROPOSAL: #88555 (comment)

Tests

Go to Settings > Wallet
Add a personal card if you don't have one already
Tap on a personal card to open its details
Verify the menu item description says "Card name" (not "Card number")
Tap on the card name field to open the edit name page
Verify the page header says "Card name"
Verify the input label says "Card name"
Verify that no errors appear in the JS console

Offline tests

N/A - this is a label-only change with no network dependency.

QA Steps

Go to Settings > Wallet
Tap on an existing personal card to open its details
Verify the menu item description says "Card name" (not "Card number")
Tap on the card name field to open the edit name page
Verify the page header and input label both say "Card name"
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

The personal card edit name page and card details header menu were using the 'cardNumber' translation key instead of 'cardName', causing the label to show "Card number" instead of "Card name". Co-authored-by: mkhutornyi <mkhutornyi@users.noreply.github.com>

codecov · 2026-04-24T17:31:16Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../settings/Wallet/PersonalCardDetailsHeaderMenu.tsx	`0.00% <0.00%> (ø)`
...pages/settings/Wallet/PersonalCardEditNamePage.tsx	`0.00% <0.00%> (ø)`
... and 8 files with indirect coverage changes

mkhutornyi · 2026-04-26T16:52:31Z

@MelvinBot add Tests/QA Steps and complete author checklist (Don't use N/A but ✔️ even if they're not related)

MelvinBot · 2026-04-26T16:55:15Z

Updated the PR description with Tests/QA Steps and completed the author checklist. Please add screenshots/videos for each platform before marking as ready for review.

mkhutornyi · 2026-04-26T16:58:04Z

@MelvinBot mark as ready for review

MelvinBot · 2026-04-26T16:59:19Z

Marked this PR as ready for review.

melvin-bot · 2026-04-26T16:59:21Z

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-04-26T16:59:51Z

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mkhutornyi · 2026-04-26T17:00:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

github-actions · 2026-04-27T14:02:57Z

🚧 @amyevans has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-27T14:08:29Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88736.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9c594fd-8db5ec6-b513022f080b460ac022c388a255656d0f77c885/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9c594fd-8db5ec6-1c576fcbc4d22c1b052ac73bd039c8d37baefd60/index.html

Web 🕸️
https://88736.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-27T14:12:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-28T00:17:26Z

🚀 Deployed to staging by https://github.com/amyevans in version: 9.3.62-13 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-28T00:18:55Z

No help site changes required.

I reviewed all articles under App/docs/articles — the most relevant file is Manage-Personal-Cards.md, which covers the personal card Wallet flow.

The docs already use generic language (e.g., "Rename the card with a custom nickname") and don't reference the specific UI label text ("Card number" / "Card name") that this PR fixes. Since this is purely a UI label bug fix (wrong translation key), no documentation update is needed.

OSBotify · 2026-04-28T01:05:07Z

🚀 Deployed to staging by https://github.com/amyevans in version: 9.3.63-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android

MelvinBot · 2026-04-28T01:07:50Z

No help site changes required.

The docs under App/docs/articles already use the correct "card name" terminology for personal cards:

Manage-Personal-Cards.md — references "card name" (line 27, 39)
Connect-Personal-Credit-Cards.md — references "card name" (line 56)

This PR only fixes a UI translation key mismatch (cardNumber → cardName) — the help site was never affected by the bug.

OSBotify · 2026-04-28T01:43:54Z

🚀 Deployed to staging by https://github.com/amyevans in version: 9.3.64-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-28T01:45:17Z

No help site changes are required for this PR.

The relevant article (docs/articles/new-expensify/connect-credit-cards/Manage-Personal-Cards.md) already uses correct terminology — it references "card name" and "Rename the card" without ever using the incorrect "Card number" label that this PR fixes. The bug was limited to a wrong translation key in the UI code; the docs were never affected.

MelvinBot assigned mkhutornyi Apr 24, 2026

MelvinBot requested a review from a team April 24, 2026 17:19

MelvinBot mentioned this pull request Apr 24, 2026

[$125] Update personal card field name in NewDot #88555

Open

7 tasks

MelvinBot marked this pull request as ready for review April 26, 2026 16:59

MelvinBot requested a review from a team as a code owner April 26, 2026 16:59

melvin-bot Bot requested review from JmillsExpensify and mkhutornyi and removed request for a team April 26, 2026 16:59

melvin-bot Bot requested review from a team and amyevans and removed request for a team April 26, 2026 16:59

mkhutornyi approved these changes Apr 26, 2026

View reviewed changes

amyevans approved these changes Apr 27, 2026

View reviewed changes

amyevans merged commit 9c594fd into main Apr 27, 2026
54 of 55 checks passed

amyevans deleted the claude-fixPersonalCardNameLabel branch April 27, 2026 14:02

OSBotify mentioned this pull request Apr 28, 2026

Deploy Checklist: New Expensify 2026-04-23 #88633

Open

arosiclair mentioned this pull request Apr 29, 2026

PR checklist #89226

Open

Conversation

MelvinBot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Apr 24, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mkhutornyi commented Apr 26, 2026

Uh oh!

MelvinBot commented Apr 26, 2026

Uh oh!

mkhutornyi commented Apr 26, 2026

Uh oh!

MelvinBot commented Apr 26, 2026

Uh oh!

melvin-bot Bot commented Apr 26, 2026

Uh oh!

melvin-bot Bot commented Apr 26, 2026

Uh oh!

mkhutornyi commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Apr 27, 2026

Uh oh!

github-actions Bot commented Apr 27, 2026

Uh oh!

OSBotify commented Apr 27, 2026

Uh oh!

OSBotify commented Apr 28, 2026

Uh oh!

MelvinBot commented Apr 28, 2026

Uh oh!

OSBotify commented Apr 28, 2026

Uh oh!

MelvinBot commented Apr 28, 2026

Uh oh!

OSBotify commented Apr 28, 2026

Uh oh!

MelvinBot commented Apr 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MelvinBot commented Apr 24, 2026 •

edited

Loading

codecov Bot commented Apr 24, 2026 •

edited by github-actions Bot

Loading

mkhutornyi commented Apr 26, 2026 •

edited

Loading