Skip to content

[No QA] [NO QA] Docs updates for E/A#86938 Add undelete and deleted expense filter docs#88763

Open
stephanieelliott wants to merge 10 commits intomainfrom
helpsite-undelete-expenses
Open

[No QA] [NO QA] Docs updates for E/A#86938 Add undelete and deleted expense filter docs#88763
stephanieelliott wants to merge 10 commits intomainfrom
helpsite-undelete-expenses

Conversation

@stephanieelliott
Copy link
Copy Markdown
Contributor

Replaces: #88028

@stephanieelliott stephanieelliott self-assigned this Apr 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds documentation for the new "undelete" expense feature across three files: a new procedural section in How-to-Delete-Expenses.md, a table row in Expense-and-Report-Actions.md, and a filter value addition in Getting-Started-with-the-Spend-Page.md. The changes are focused, well-scoped, and generally follow governance standards. The PR also corrects previously non-compliant absolute URLs to relative links, which is a welcome fix.

Scores Summary

  • Readability: 9/10 - Steps are clear, sequential, and action-oriented. The new "How to find and undelete deleted expenses" section is concise and easy to follow. The table row in Expense-and-Report-Actions.md is slightly dense but functional.
  • AI Readiness: 9/10 - The new section heading is properly task-based ("How to find and undelete deleted expenses"). Keywords and internalScope metadata are updated with relevant search phrases (undelete expense, restore deleted expense, find deleted expenses). YAML frontmatter is complete.
  • Style Compliance: 8/10 - Navigation instructions correctly use the unified pattern. Button and UI element names are bolded. However, the Undelete row in the Expense-and-Report-Actions.md table uses plain text for UI references ("Reports > Expenses with Status = Deleted filter") where UI element names should be bolded per naming conventions.

Key Findings

  • The new procedural section in How-to-Delete-Expenses.md follows the step formatting standard well, with clear numbered steps and proper UI element bolding.
  • Converting three absolute URLs (help.expensify.com) to relative links aligns with the cross-linking governance rule requiring relative links only. This is a positive correction of prior non-compliance.
  • The Undelete row added to the Expense-and-Report-Actions.md table describes the condition as "On deleted expenses (accessible via Reports > Expenses with Status = Deleted filter)" -- the UI element references within this description (Reports, Expenses, Status, Deleted) are not bolded, which is inconsistent with the naming conventions governance requiring exact UI labels to use bold formatting.
  • Keywords and internalScope updates are thorough and reflect realistic search queries.

Recommendations

  1. In Expense-and-Report-Actions.md, consider bolding UI element names within the Undelete row's condition column (e.g., "accessible via Reports > Expenses with Status = Deleted filter") to match the naming conventions governance. Note: this is a minor issue given the table format constraints, and existing rows in this table follow the same plain-text pattern, so this may be an intentional table-wide convention.
  2. No other blocking issues found. The changes are well-structured and governance-compliant.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Expense-and-Report-Actions.md - One row added to actions table. Minor UI bolding gap noted.
  • docs/articles/new-expensify/reports-and-expenses/Getting-Started-with-the-Spend-Page.md - "Deleted" added to Status filter examples. Clean change.
  • docs/articles/new-expensify/reports-and-expenses/How-to-Delete-Expenses.md - New "How to find and undelete deleted expenses" section added, metadata updated, absolute URLs converted to relative links. Well-executed.

Note: Detailed line-by-line feedback has been provided as inline comments where applicable.

Comment thread docs/articles/new-expensify/reports-and-expenses/Expense-and-Report-Actions.md Outdated
@github-actions github-actions Bot changed the title [NO QA] Docs updates for E/A#86938 Add undelete and deleted expense filter docs [No QA] [NO QA] Docs updates for E/A#86938 Add undelete and deleted expense filter docs Apr 25, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Apr 25, 2026

@stephanieelliott stephanieelliott requested a review from a team April 25, 2026 03:32
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 25, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @CortneyOfstad

@melvin-bot melvin-bot Bot requested a review from CortneyOfstad April 25, 2026 03:32
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 25, 2026

@CortneyOfstad Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team April 25, 2026 03:32
Added section explaining the consequences of deleting an expense.
@stephanieelliott
Copy link
Copy Markdown
Contributor Author

@MelvinBot fix the spelling errors

@MelvinBot
Copy link
Copy Markdown
Contributor

The spellcheck failure has 2 typos in docs/articles/new-expensify/reports-and-expenses/Expense-and-Report-Actions.md:

  1. Line 5, col 52: overiewoverview
  2. Line 105, col 17: OustandingOutstanding

⚠️ I can't push changes to this PR because I didn't open it and I'm not listed as an assignee. To have me make this fix, add me to the PR assignees and then retry your request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants