BT - Migrate Xero Export Routes#88836
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@huult This one is ready for review. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68b32a6c4a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@mananjadhav could you check codex's comment? |
Screen.Recording.2026-05-02.at.22.45.14.movCould you verify the flow of opening the Export option from the company card? It currently leads to a ‘Not Found’ page. |
|
I've fixed @huult. This is now ready for your QA. web-bt-xero-export.mov |
|
On main: Screen.Recording.2026-05-07.at.09.29.03.movOn this branch: Screen.Recording.2026-05-07.at.09.32.03.mov@mananjadhav The behavior has changed. Could you help check this? |
|
@huult I've fixed the behavior. web-xero-back-handling.mov |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-05-08.at.09.34.15.mp4Android: mWeb ChromeScreen.Recording.2026-05-08.at.09.36.03.mp4iOS: HybridAppScreen.Recording.2026-05-08.at.09.39.08.mp4iOS: mWeb SafariScreen.Recording.2026-05-08.at.09.39.53.mp4MacOS: Chrome / SafariScreen.Recording.2026-05-08.at.09.30.07.mp4 |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.69-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes required. This PR is a purely technical refactor that migrates Xero Export routes from static to dynamic route definitions ( The existing Xero help site articles (e.g., |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.69-18 🚀
|
Explanation of Change
Fixed Issues
$ #83841
PROPOSAL:
Tests
Xero Export (
xero/export)Workspaces > [Workspace] > Accounting > Xero.workspaces/<policyID>/accounting/xero/export./xero/export)..../accounting/xero/export.Preferred Exporter Select (
xero-preferred-exporter/select)Workspaces > [Workspace] > Accounting > Xero > Export.workspaces/<policyID>/accounting/xero/export/xero-preferred-exporter/select./xero-preferred-exporter/select)..../xero-preferred-exporter/select.Purchase Bill Date Select (
purchase-bill-date-select)Workspaces > [Workspace] > Accounting > Xero > Export.workspaces/<policyID>/accounting/xero/export/purchase-bill-date-select./purchase-bill-date-select)..../purchase-bill-date-select.Offline tests
Same as Test Steps
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Test Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-bt-xero-export.mov
Android: mWeb Chrome
mweb-chrome-bt-exero-export.mov
iOS: Native
ios-bt-xero-export.mov
iOS: mWeb Safari
mweb-safari-bt-xero-export.mov
MacOS: Chrome / Safari
web-bt-xero-export.mov