Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required. This feature is shipped.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 @dangrous has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.62-13 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR (removing the The existing article at No help site changes are required. |
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.63-1 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.64-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Removing beta since it's been enabled for all for a while
Fixed Issues
#67531 (comment)
Tests
No
Offline tests
No
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
No
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari