[CP Staging] fix: SpendOverTime widget not updating data when switching tabs#88966
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-04-27.19.12.53.movAndroid: mWeb Chrome2026-04-27.19.09.30.moviOS: HybridApp2026-04-27.19.12.53.moviOS: mWeb Safari2026-04-27.19.09.30.movMacOS: Chrome / Safari2026-04-27.19.02.48.mov |
|
LGTM! |
…d-over-time-on-screen-focus fix: SpendOverTime widget not updating data when switching tabs (cherry picked from commit d3995bb) (cherry-picked to staging by luacmartins)
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.62-13 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes required. This PR is a technical bug fix that adds screen-focus-based data refetching to the Spend Over Time widget. It doesn't change any user-facing feature names, UI labels, navigation, or behavior described in the docs. The existing help site articles that mention "Spend over time" (e.g., |
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.63-1 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.64-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Makes the Spend Over Time widget refetch data when
isFocusedchanges to true as the home page is no longer remounted when navigating between tabs.Fixed Issues
$ #88936
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-04-27.o.18.12.47.mov