[CP Staging & Prod] Add Settings_Profile to exit survey entryScreens#88990
[CP Staging & Prod] Add Settings_Profile to exit survey entryScreens#88990youssef-lr merged 9 commits intomainfrom
Conversation
The "Switch to Expensify Classic" button on InitialSettingsPage navigates to EXIT_SURVEY_REASON using createDynamicRoute, which builds the URL relative to the current central pane. On wide screens the default central pane is Settings_Profile, but that screen was not in entryScreens, causing getStateFromPath to reject the route and show a 404. Add SCREENS.SETTINGS.PROFILE.ROOT to both EXIT_SURVEY_REASON and EXIT_SURVEY_CONFIRM entryScreens so the exit survey is reachable from the default settings central pane. Co-authored-by: mjasikowski <mjasikowski@users.noreply.github.com> Co-authored-by: Michał Jasikowski <mjasikowski@users.noreply.github.com>
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
trjExpensify
left a comment
There was a problem hiding this comment.
Add all settings central pane screens to EXIT_SURVEY_REASON.entryScreens in src/ROUTES.ts:346-349. The sidebar button can be clicked while any central pane is focused (not just Profile), so we need to allow all of them. The same fix should also be applied to EXIT_SURVEY_CONFIRM at line 350-353, since InitialSettingsPage can navigate directly to it as well (line 344).
Only partially fixes the bug. Melvin was right about this commentary above.
2026-04-27_20-53-38.mp4
|
@youssef-lr for this to work if launched from any of the settings pages, I think this needs to be: |
|
@MelvinBot let's play it safe and allow all screens to lead to the exit survey, in case new screens come up in the future that do this. |
Co-authored-by: Youssef Lourayad <youssef@expensify.com>
…uestStepUpgrade Co-authored-by: Michał Jasikowski <mjasikowski@users.noreply.github.com>
…com/Expensify/App into claude-exitSurveyMissingEntryScreen Co-authored-by: Michał Jasikowski <mjasikowski@users.noreply.github.com>
Co-authored-by: Michał Jasikowski <mjasikowski@users.noreply.github.com>
|
Fixed the failing typecheck: after merging |
|
The previous TypeScript check failures were from CI runs that started before the fix in commit I verified locally that |
|
🚧 @youssef-lr has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.3.62-13 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This PR is a pure route configuration fix (changing |
…yScreen (cherry picked from commit c074c85) (cherry-picked to production by arosiclair)
|
@mjasikowski @youssef-lr @blimpich @dangrous Supportal is blocked for Applause, Can this one please be tested internally? |
|
We've internally QA'd it on prod via this thread in deployers. 👍 |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.63-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.3.63-1 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This PR is a route configuration bug fix — it changes The relevant help article (Switch between New Expensify and Expensify Classic) documents the path as Profile > Troubleshoot > Switch to Expensify Classic, which remains accurate. |
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.3.64-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This is a routing configuration fix ( |
Explanation of Change
The "Switch to Expensify Classic" button on the main Settings page (
InitialSettingsPage) callscreateDynamicRoute(EXIT_SURVEY_REASON.path), which builds the exit survey URL relative to the currently focused central pane. On wide screens the default central pane isSettings_Profile, butEXIT_SURVEY_REASON.entryScreensonly allowedSettings_Troubleshoot. This causedgetStateFromPathto reject the route and show a 404.This PR adds
SCREENS.SETTINGS.PROFILE.ROOTto theentryScreensof bothEXIT_SURVEY_REASONandEXIT_SURVEY_CONFIRMso the exit survey is reachable when the default Profile central pane is active.Fixed Issues
$ #88986
PROPOSAL: #88986 (comment)
Tests
Offline tests
N/A - this is a route configuration change with no network dependency.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari