Skip to content

Guard against empty policyID in openDraftWorkspaceRequest#89014

Draft
MelvinBot wants to merge 2 commits into
mainfrom
claude-guardEmptyPolicyIdInOpenDraftWorkspaceRequest
Draft

Guard against empty policyID in openDraftWorkspaceRequest#89014
MelvinBot wants to merge 2 commits into
mainfrom
claude-guardEmptyPolicyIdInOpenDraftWorkspaceRequest

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

@MelvinBot MelvinBot commented Apr 28, 2026

Explanation of Change

The openDraftWorkspaceRequest function guards against invalid policyIDs ('-1' and CONST.POLICY.ID_FAKE) but does not guard against an empty string. When a client sends OpenDraftWorkspaceRequest with an empty policyID, Auth throws 402 Missing policyID, surfacing as an ExpException. This change adds a falsy check (!policyID) to the existing guard to prevent the API call from being made with an empty policyID.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/629598

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

N/A - this change prevents an API call from being made, no offline behavior change.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@MelvinBot @rushatgabhane
Guard against empty policyID in openDraftWorkspaceRequest
fa4a9dc 
The client was sending OpenDraftWorkspaceRequest with an empty policyID,
causing Auth to throw 402 Missing policyID. The existing guard checked
for '-1' and ID_FAKE but not for empty strings.

Co-authored-by: Rushat Gabhane <rushatgabhane@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team April 28, 2026 01:03
@MelvinBot
Copy link
Copy Markdown
Contributor Author

MelvinBot commented Apr 28, 2026

The test (job 7) failure is a transient GitHub Actions infrastructure issue — the Checkout step failed, not any actual test. This is unrelated to the PR changes. I've re-triggered the failed jobs.

@MelvinBot
Copy link
Copy Markdown
Contributor Author

MelvinBot commented Apr 28, 2026

The test (job 7) failure is not related to this PR's code changes — it's a transient GitHub Actions infrastructure error. The job failed during git checkout before any tests ran:

error: RPC failed; curl 56 GnuTLS recv error (-24): Decryption has failed.
fatal: early EOF

All three retry attempts hit the same TLS decryption failure. No code fix is needed — please re-run the failed job.

@rushatgabhane
Copy link
Copy Markdown
Member

rushatgabhane commented May 13, 2026

@MelvinBot merge main please

@MelvinBot @rushatgabhane
Merge remote-tracking branch 'origin/main' into claude-guardEmptyPoli…
6c31275 
…cyIdInOpenDraftWorkspaceRequest

Co-authored-by: Rushat Gabhane <rushatgabhane@users.noreply.github.com>
@MelvinBot
Copy link
Copy Markdown
Contributor Author

MelvinBot commented May 13, 2026

Done! Merged main into this branch. The merge was clean — no conflicts.

@rushatgabhane
Copy link
Copy Markdown
Member

rushatgabhane commented May 14, 2026

@MelvinBot shouldn't we use util? isEmpty ?

@MelvinBot
Copy link
Copy Markdown
Contributor Author

MelvinBot commented May 14, 2026

The !policyID falsy check is the right approach here. The codebase doesn't have a general-purpose isEmpty for strings — the available utilities serve different purposes:

  • StringUtils.isEmptyString() — strips invisible Unicode/zero-width characters before checking emptiness. Designed for user-facing text input, not internal IDs.
  • isEmptyObject() — checks objects, not strings.
  • Lodash isEmpty — would work but adds an import for something a simple !policyID already handles.

Since policyID is typed as string and we're just guarding against an empty string being passed to the API, !policyID is idiomatic and sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rushatgabhane rushatgabhane

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MelvinBot @rushatgabhane