Update odometer error message to include missing 'to continue' suffix by MelvinBot · Pull Request #89034 · Expensify/App

MelvinBot · 2026-04-28T02:53:21Z

Explanation of Change

The odometer validation error message (invalidReadings) was missing the "to continue" suffix and used "and" instead of "&". Updated the English string from Please enter both start and end readings to Please enter both start & end readings to continue to match the expected behavior from the regression test case. Also added the equivalent "to continue" suffix to all 9 non-English translations, matching the phrasing pattern already used by neighboring error strings (invalidAmount, invalidDistance).

Fixed Issues

$ #88695
PROPOSAL: #88695 (comment)

Tests

Verify that no errors appear in the JS console
Login to the ND app
Navigate to Track Distance > Odometer
Click Next without fill any numbers on both or one of the Start reading and End readings
Verify that error "Please enter both start & end readings to continue" appears

Offline tests

N/A — This is a string-only change with no network dependency.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

The invalidReadings error message was missing the 'to continue' suffix that the expected behavior requires. Updated the English string from 'Please enter both start and end readings' to 'Please enter both start & end readings to continue', and added equivalent suffixes to all 9 other language translations. Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>

OSBotify · 2026-04-28T02:55:29Z

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff

diff --git a/src/languages/de.ts b/src/languages/de.ts
index 89d1d7c8..14a7b3f4 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -1421,7 +1421,7 @@ const translations: TranslationDeepObject<typeof en> = {
             invalidTagLength: 'Der Tagname überschreitet 255 Zeichen. Bitte kürzen Sie ihn oder wählen Sie einen anderen Tag.',
             invalidAmount: 'Bitte gib vor dem Fortfahren einen gültigen Betrag ein',
             invalidDistance: 'Bitte gib eine gültige Entfernung ein, bevor du fortfährst',
-            invalidReadings: 'Bitte geben Sie sowohl Start- als auch Endstand ein, bevor Sie fortfahren',
+            invalidReadings: 'Bitte gib sowohl Start- als auch Endstand ein, um fortzufahren',
             negativeDistanceNotAllowed: 'Endstand muss größer als Anfangsstand sein',
             distanceAmountTooLarge: 'Der Gesamtbetrag ist zu hoch. Verringere die Entfernung oder reduziere den Satz.',
             distanceAmountTooLargeReduceDistance: 'Der Gesamtbetrag ist zu hoch. Verringere die Entfernung.',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 2bb7ae0a..5050648d 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -1400,7 +1400,7 @@ const translations: TranslationDeepObject<typeof en> = {
             invalidTagLength: 'タグ名が255文字を超えています。短くするか、別のタグを選択してください。',
             invalidAmount: '続行する前に有効な金額を入力してください',
             invalidDistance: '続行する前に有効な距離を入力してください',
-            invalidReadings: '続行する前に開始値と終了値の両方を入力してください',
+            invalidReadings: '続行するには開始値と終了値の両方を入力してください',
             negativeDistanceNotAllowed: '終了値は開始値より大きくなければなりません',
             distanceAmountTooLarge: '合計金額が大きすぎます。距離を減らすか、レートを下げてください。',
             distanceAmountTooLargeReduceDistance: '合計金額が大きすぎます。距離を減らしてください。',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 46526cd3..1beb0473 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1417,7 +1417,7 @@ const translations: TranslationDeepObject<typeof en> = {
             invalidTagLength: 'De tagnaam is langer dan 255 tekens. Maak deze korter of kies een andere tag.',
             invalidAmount: 'Voer een geldig bedrag in voordat je doorgaat',
             invalidDistance: 'Voer een geldige afstand in voordat je verdergaat',
-            invalidReadings: 'Voer zowel de begin- als eindstanden in voordat je doorgaat',
+            invalidReadings: 'Voer zowel de begin- als eindstanden in om door te gaan',
             negativeDistanceNotAllowed: 'Eindstand moet hoger zijn dan beginstand',
             distanceAmountTooLarge: 'Het totale bedrag is te hoog. Verlaag de afstand of verlaag het tarief.',
             distanceAmountTooLargeReduceDistance: 'Het totale bedrag is te hoog. Verlaag de afstand.',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 2e022088..0d766834 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -1415,7 +1415,7 @@ const translations: TranslationDeepObject<typeof en> = {
             invalidTagLength: 'Nazwa taga przekracza 255 znaków. Skróć ją lub wybierz inny tag.',
             invalidAmount: 'Wprowadź poprawną kwotę przed kontynuowaniem',
             invalidDistance: 'Wprowadź prawidłowy dystans przed kontynuowaniem',
-            invalidReadings: 'Wprowadź zarówno odczyt początkowy, jak i końcowy przed kontynuowaniem',
+            invalidReadings: 'Wprowadź zarówno odczyt początkowy, jak i końcowy, aby kontynuować',
             negativeDistanceNotAllowed: 'Końcowy odczyt musi być większy niż początkowy odczyt',
             distanceAmountTooLarge: 'Łączna kwota jest zbyt wysoka. Zmniejsz dystans lub obniż stawkę.',
             distanceAmountTooLargeReduceDistance: 'Łączna kwota jest zbyt wysoka. Zmniejsz dystans.',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index b6b28b0a..ddb5e73b 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -1414,7 +1414,7 @@ const translations: TranslationDeepObject<typeof en> = {
             invalidTagLength: 'O nome da tag excede 255 caracteres. Reduza-o ou escolha uma tag diferente.',
             invalidAmount: 'Insira um valor válido antes de continuar',
             invalidDistance: 'Insira uma distância válida antes de continuar',
-            invalidReadings: 'Insira as leituras de início e fim antes de continuar',
+            invalidReadings: 'Insira as leituras inicial e final para continuar',
             negativeDistanceNotAllowed: 'A leitura final deve ser maior que a leitura inicial',
             distanceAmountTooLarge: 'O valor total é muito alto. Diminua a distância ou reduza a tarifa.',
             distanceAmountTooLargeReduceDistance: 'O valor total é muito alto. Diminua a distância.',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 6f49eca5..03523b2a 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -1374,7 +1374,7 @@ const translations: TranslationDeepObject<typeof en> = {
             invalidTagLength: '标签名称超过了 255 个字符。请缩短它或选择其他标签。',
             invalidAmount: '请在继续之前输入有效金额',
             invalidDistance: '请在继续之前输入有效的距离',
-            invalidReadings: '请在继续之前输入起始读数和结束读数',
+            invalidReadings: '请输入起始和结束读数后继续',
             negativeDistanceNotAllowed: '结束读数必须大于开始读数',
             distanceAmountTooLarge: '总金额过大。请减少距离或降低费率。',
             distanceAmountTooLargeReduceDistance: '总金额过大。请减少距离。',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

thelullabyy · 2026-04-28T02:56:03Z

@MelvinBot Please tick all checklist and open the PR for review

MelvinBot · 2026-04-28T02:58:31Z

Done! All checklist items have been ticked and the PR has been marked as ready for review.

melvin-bot · 2026-04-28T02:58:33Z

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thelullabyy · 2026-04-28T03:08:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

joekaufmanexpensify

Fine for product

thelullabyy · 2026-05-01T10:06:26Z

@MelvinBot Please add this test case to Test part

1. Login to the ND app
2. Navigate to Track Distance > Odometer
3. Click Next without fill any numbers on both or one of the Start reading and End readings
4. Verify that error "Please enter both start & end readings to continue" appears

MelvinBot · 2026-05-01T10:08:23Z

Added the requested test case to the Tests section of the PR description.

thelullabyy · 2026-05-01T10:08:47Z

            invalidAmount: 'Por favor, ingresa un importe válido antes de continuar',
            invalidDistance: 'Por favor, ingresa una distancia válida antes de continuar',
-            invalidReadings: 'Por favor ingrese ambas lecturas de inicio y fin',
+            invalidReadings: 'Por favor ingrese ambas lecturas de inicio y fin para continuar',


Confirming here

thelullabyy

Copy changes. LGTM!

Confirming ES translation here

OSBotify · 2026-05-01T21:55:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-01T22:01:22Z

🚧 @marcaaron has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-01T22:08:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89034.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-3f49ce4-018b2b8-f04acb3007b1550e7258327bed8ecf4c08fab569/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-3f49ce4-018b2b8-f97a7975d7aa58b012fd975c4281c1679d8f5049/index.html

Web 🕸️
https://89034.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-04T13:28:14Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.3.66-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-05-04T13:30:58Z

I reviewed the changes in this PR. It's a string-only change that updates the odometer validation error message (invalidReadings) across 10 language files to add a "to continue" suffix and change "and" to "&" in the English string.

No help site changes are required. The help site articles under docs/articles document features, workflows, and settings — not individual validation error messages. This change has no impact on any existing help site content.

MelvinBot assigned thelullabyy Apr 28, 2026

MelvinBot requested a review from a team April 28, 2026 02:53

MelvinBot mentioned this pull request Apr 28, 2026

[$250] Odometer - Error message is wrong when try to track the odometer without a fill Start/End #88695

Open

7 tasks

MelvinBot marked this pull request as ready for review April 28, 2026 02:58

MelvinBot requested a review from a team as a code owner April 28, 2026 02:58

melvin-bot Bot requested review from joekaufmanexpensify and thelullabyy and removed request for a team April 28, 2026 02:58

melvin-bot Bot removed the request for review from a team April 28, 2026 02:58

joekaufmanexpensify approved these changes Apr 28, 2026

View reviewed changes

thelullabyy reviewed May 1, 2026

View reviewed changes

thelullabyy approved these changes May 1, 2026

View reviewed changes

melvin-bot Bot requested a review from marcaaron May 1, 2026 10:10

thelullabyy approved these changes May 1, 2026

View reviewed changes

marcaaron approved these changes May 1, 2026

View reviewed changes

marcaaron merged commit 3f49ce4 into main May 1, 2026
65 of 69 checks passed

marcaaron deleted the claude-fixOdometerErrorMessage branch May 1, 2026 21:47

OSBotify mentioned this pull request May 4, 2026

Deploy Checklist: New Expensify 2026-05-04 #89508

Open

76 tasks

Conversation

MelvinBot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Apr 28, 2026

🦜 Polyglot Parrot! 🦜

Uh oh!

thelullabyy commented Apr 28, 2026

Uh oh!

MelvinBot commented Apr 28, 2026

Uh oh!

melvin-bot Bot commented Apr 28, 2026

Uh oh!

thelullabyy commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

thelullabyy commented May 1, 2026

Uh oh!

MelvinBot commented May 1, 2026

Uh oh!

thelullabyy May 1, 2026

Choose a reason for hiding this comment

Uh oh!

thelullabyy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented May 1, 2026

Uh oh!

github-actions Bot commented May 1, 2026

Uh oh!

github-actions Bot commented May 1, 2026

Uh oh!

OSBotify commented May 4, 2026

Uh oh!

MelvinBot commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MelvinBot commented Apr 28, 2026 •

edited

Loading

thelullabyy commented Apr 28, 2026 •

edited

Loading