[CP Staging] Fix search list regressions: skeleton stretching, stale expense count, and lost border radius

[Krishna2323]

Explanation of Change

Fixed Issues

$ #89026
$ #89035
$ #89038
$ #89042
$ #89045
$ #89046
$ #89089
PROPOSAL:

Tests

Fix 1: Blank row at the end of the table (#89026)

Precondition:

• Have many expenses.

1. Launch Expensify app.
2. Go to Spend > Expenses.
3. Scroll to the bottom.
4. Verify the last row shows an expense — there is no blank row at the end of the table.

---

Fix 2: Expense count increases by 1 after deleting a split offline (#89035)

1. Launch Expensify app.
2. Go to workspace chat.
3. Create an expense.
4. Tap More > Split > Add split > Save.
5. Go to Spend > Reports.
6. Go offline.
7. Open the report.
8. Delete one of the splits.
9. Return to Spend > Reports.
10. Verify the number of expenses does not increase by 1.

---

Fix 3: Rounded corners disappear on the first expense row after deleting expense (#89038)

Precondition:

• Have many expenses.

1. Launch Expensify app.
2. Go to Spend > Expenses.
3. Long tap on the first expense > Select.
4. Select the last expense.
5. Tap dropdown button > Delete.
6. Delete the expense.
7. Verify the new first expense row has rounded top corners and the new last expense row has rounded bottom corners.

---

Fix 4: Amount is shown on left when expense has no merchant and description (#89042)

1. Launch Expensify app.
2. Go to workspace chat.
3. Create an expense.
4. Go to self DM.
5. Create an expense without merchant and description.
6. Go to Spend > Expenses.
7. Verify the amount appears on the right for all expenses.

---

Fix 5: Selected unreported expense shows sharp corners (#89045)

1. Go to self DM.
2. Create an expense.
3. Go to workspace chat.
4. Create a report.
5. On the report preview, click Add expense > Add unreported expense.
6. Click on the unreported expense.
7. Verify the selected unreported expense shows rounded corners.

---

Fix 6: Expense row is blank after creating expense on Spend tab (#89046)

Precondition:

• Account has no expenses.
• Have a workspace.

1. Launch Expensify app.
2. Go to Spend > Expenses.
3. Tap Create expense.
4. Create an expense.
5. Verify the expense row shows the expense summary — it is not blank.

• Verify that no errors appear in the JS console

Offline tests

• Same as Tests

QA Steps

• Same as Tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

test_1.mp4

test_2.mp4

test_3.mp4

test_5.mp4

test_6.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/Search/SearchList/index.tsx	45.45% <100.00%> (+1.38%)	⬆️
src/components/Search/SearchStaticList.tsx	6.89% <ø> (ø)
src/components/Search/index.tsx	0.92% <ø> (ø)
src/components/Skeletons/SearchRowSkeleton.tsx	69.23% <100.00%> (ø)
...stReportView/MoneyRequestReportTransactionItem.tsx	0.00% <0.00%> (ø)
...h/SearchList/ListItem/ExpenseReportListItemRow.tsx	0.00% <0.00%> (ø)
...rc/pages/TransactionMerge/MergeTransactionItem.tsx	0.00% <0.00%> (ø)
src/components/TransactionItemRow/index.tsx	74.10% <0.00%> (ø)
...Search/SearchList/ListItem/TransactionListItem.tsx	0.00% <0.00%> (ø)
... and 63 files with indirect coverage changes

[Krishna2323]

@codex review

[Krishna2323]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1549df6e94

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[melvin-bot]

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[dubielzyk-expensify]

I think it all looks good on my end, but curious to get @shawnborton 's extra eyes as well

[Krishna2323]

Android & iOS - Spend - Divider is invisible between expense rows when selected #89066](#89066) What's the expected design? Seems not blocker though

I’ve already been working on a fix—if it looks good, I can push it immediately. @Expensify/design

Monosnap.screencast.2026-04-28.16-40-53.mp4

[Krishna2323]

@situchan added fix for #89089 also, please check

[shawnborton]

We might want to use the darker border color that we are using here on web:

(Which is a good reminder we need to fix this on web too 🤣 )

[situchan]

@situchan added fix for #89089 also, please check

Should we revert this based on #89089 (comment)?

This is intentional - we are no longer displaying the tag at the expense preview level.

[luacmartins]

@Krishna2323 ^

[Krishna2323]

@situchan @luacmartins changes related to tag display is reverted.

[Krishna2323]

• Android & iOS - Spend - Divider is invisible between expense rows when selected #89066 What’s the expected design? It doesn’t seem like a blocker though.

I’ll handle this in a separate PR.

[JS00001]

@situchan can you re-review please?

[situchan]

Review is done.
Been waiting for revert of tax display.

[Krishna2323]

Sorry, my phone is behaving weirdly.

@JS00001 please review and merge when you get a chance.

[JS00001]

Looking

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89043.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-abbaa5e-aa9ddd2-716cb0cad63838f1c41e51e61c32d50b43b0d89b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-abbaa5e-aa9ddd2-73c63d3e1fefba5d67ec5a52b5f904302757f81a/index.html

Web 🕸️
https://89043.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.64-11 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• iOS

[MelvinBot]

No help site changes are required for this PR.

The changes are purely visual/rendering bug fixes (skeleton stretching, stale expense counts, lost border radius, amount alignment). None of these affect documented user workflows, feature descriptions, or instructions in App/docs/articles. The relevant articles (e.g., Getting Started with the Spend Page, Managing Expenses in a Report) describe workflows and features, not UI rendering details like border radius or skeleton loaders.

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.64-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

[MelvinBot]

No help site changes required.

This PR contains purely visual/UI bug fixes (border radius, skeleton loading, expense count display accuracy, amount alignment). None of the changes affect user-facing features, workflows, settings, or terminology that would be documented in App/docs/articles.

I checked the relevant help site articles (e.g., Getting-Started-with-the-Spend-Page.md, How-to-Delete-Expenses.md, Managing-Expenses-in-a-Report.md) and none reference the rendering details being fixed here.