Fix send money crash by rlinoz · Pull Request #89105 · Expensify/App

rlinoz · 2026-04-28T13:45:42Z

Explanation of Change

Ensure we send a number to IB SDK so it doesn't crash.

Fixed Issues

$ #89099
PROPOSAL:

Tests

Launch the app
Sign in with any account
Tap on FAB button > Start chat > Enter the email which doesn't have an expensify account
Once redirected to the DM, tap on plus icon > Pay user > Enter amount > Mark as paid

bug_capture_video_2f6854323263410cb6c1279f8a6a52be62039fe8f897.webm

Verify that no errors appear in the JS console

Offline tests

QA Steps

Launch the app
Sign in with any account
Tap on FAB button > Start chat > Enter the email which doesn't have an expensify account
Once redirected to the DM, tap on plus icon > Pay user > Enter amount > Mark as paid

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-04-28T13:47:29Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

codecov · 2026-04-28T13:54:16Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/Middleware/FraudMonitoring.ts	`39.02% <0.00%> (-0.98%)`	⬇️
... and 28 files with indirect coverage changes

melvin-bot · 2026-04-28T14:35:53Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

amyevans · 2026-04-28T14:37:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-04-28T14:44:17Z

@rlinoz looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

rlinoz · 2026-04-28T14:45:38Z

No emergency, everything was green? 😕

luacmartins · 2026-04-28T14:46:21Z

@rlinoz can you request the CP please?

OSBotify · 2026-04-28T14:54:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Fix send money crash (cherry picked from commit d64cf97) (cherry-picked to staging by luacmartins)

OSBotify · 2026-04-28T16:12:05Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.64-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-28T16:13:18Z

No help site documentation changes are required for this PR.

This is a purely internal bug fix in FraudMonitoring.ts middleware that ensures newAccountCount is properly validated and converted to a string before being passed to the IB SDK. No user-facing features, settings, flows, or UI elements are affected.

github-actions · 2026-04-28T16:14:16Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-28T16:27:50Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89105.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d64cf97-f5c1c69-a83f6f2c390d3c8c5492af3c552c07cc8fb5d9c3/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d64cf97-f5c1c69-29f317db697ed59d2a9b2d71406956e2195912e7/index.html

Web 🕸️
https://89105.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-28T17:09:53Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.64-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

convert instead of cast

bf3433a

rlinoz self-assigned this Apr 28, 2026

This comment has been minimized.

Sign in to view

rlinoz mentioned this pull request Apr 28, 2026

iOS - Pay - App crashes when paying a non existent user #89099

Closed

7 tasks

validate newAccountCount is number

8b86fb0

rlinoz changed the title ~~convert instead of cast~~ Fix send money crash Apr 28, 2026

rlinoz marked this pull request as ready for review April 28, 2026 14:35

rlinoz requested review from a team as code owners April 28, 2026 14:35

melvin-bot Bot requested review from ZhenjaHorbach and trjExpensify and removed request for a team April 28, 2026 14:35

melvin-bot Bot removed the request for review from a team April 28, 2026 14:35

amyevans approved these changes Apr 28, 2026

View reviewed changes

luacmartins self-requested a review April 28, 2026 14:38

luacmartins approved these changes Apr 28, 2026

View reviewed changes

rlinoz removed the request for review from ZhenjaHorbach April 28, 2026 14:43

rlinoz merged commit d64cf97 into main Apr 28, 2026
48 of 53 checks passed

rlinoz deleted the rodrigo-fix-sendmoney-crash branch April 28, 2026 14:44

melvin-bot Bot added the Emergency label Apr 28, 2026

rlinoz removed the Emergency label Apr 28, 2026

OSBotify pushed a commit that referenced this pull request Apr 28, 2026

Merge pull request #89105 from Expensify/rodrigo-fix-sendmoney-crash

21f5c5b

Fix send money crash (cherry picked from commit d64cf97) (cherry-picked to staging by luacmartins)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Apr 28, 2026

OSBotify mentioned this pull request Apr 28, 2026

Deploy Checklist: New Expensify 2026-04-23 #88633

Open

arosiclair mentioned this pull request Apr 29, 2026

PR checklist #89226

Open

Conversation

rlinoz commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

codecov Bot commented Apr 28, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment has been minimized.

melvin-bot Bot commented Apr 28, 2026

Uh oh!

amyevans commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

melvin-bot Bot commented Apr 28, 2026

Uh oh!

rlinoz commented Apr 28, 2026

Uh oh!

luacmartins commented Apr 28, 2026

Uh oh!

OSBotify commented Apr 28, 2026

Uh oh!

OSBotify commented Apr 28, 2026

Uh oh!

MelvinBot commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

OSBotify commented Apr 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rlinoz commented Apr 28, 2026 •

edited

Loading

codecov Bot commented Apr 28, 2026 •

edited by github-actions Bot

Loading

amyevans commented Apr 28, 2026 •

edited

Loading