Remove CompactMenuContext.Provider from PopoverMenu to fix narrow bank account icon#89135
Draft
Remove CompactMenuContext.Provider from PopoverMenu to fix narrow bank account icon#89135
Conversation
The provider was unconditionally setting compact mode for all PopoverMenu consumers, which caused bank account icons in payment popovers to render at 20px instead of 40px. The three menus that need compact styling (BaseReportActionContextMenu, FABPopoverMenu, DisplayPopup) already have their own CompactMenuContext.Provider wrappers and don't render through PopoverMenu. Co-authored-by: Jules <Julesssss@users.noreply.github.com>
Contributor
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
7 tasks
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Attempts to $ this regression introduced by compact row style changes.
Fixed Issues
$ #89129
Tests
Offline tests
N/A — this is a visual styling fix only; no data or network behavior is affected.
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari