[No QA] Add eslint-report seatbelt dashboard script#89144
Merged
roryabraham merged 14 commits intomainfrom Apr 29, 2026
Merged
Conversation
- Download Chart.js UMD beside the HTML so local file URLs load the chart. - Fix undefined toggle id (eslint-seatbelt-ds-*). - Run report generation async; fail fast if Chart download fails. - Default to opening the report in the browser; use --no-open or CI to skip. Made-with: Cursor
Replace manual argv parsing with scripts/utils/CLI.ts. Use Git.show for seatbelt snapshots; keep execSync for git log/rev-parse. Chdir to App root during git reads so Git helpers resolve the correct repo. Made-with: Cursor
Align REPORT_THEME with theme/themes/dark.ts tokens; Expensify Neue/Mono stacks. Embed ChartUiPayload for Chart.js scales, legend, tooltips, and rule palettes. Add dark color-scheme meta, footer link styling, and accent checkboxes. Made-with: Cursor
Made-with: Cursor
Modern TS/JS style, inline SVG favicon, dedupe CLI parsers and chart helpers, simplify embedded Chart/table logic without behavior change. Made-with: Cursor
Rename abbreviated bindings (chartDataset, visibilityCheckbox, chartUi, chartCanvas, etc.) in generated HTML script only. Made-with: Cursor
Extract GitUtils.getHeadShort() for rev-parse; update HTML intro and summary labels to describe eslint.seatbelt.tsv as baseline source. Made-with: Cursor
|
npm has a |
Remove Chart.js/file:// and table-sort blurbs from generated HTML; trim unused theme keys and footer CSS. Made-with: Cursor
📲 Install BuildsAndroid
|
eslint-report uses Git.getHeadShort(); remove redundant scripts/utils/GitUtils.ts. Made-with: Cursor
Add Menlo and nums; ignore .gitignore in cspell so path-only entries are not spellchecked when the file appears in PR diffs. Made-with: Cursor
|
@chiragsalian Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
I'll admit this is largely vibe-coded, but as it's just a dev tool to help us keep track of different lint errors across the project, I didn't treat it with too much scrutiny |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Made-with: Cursor
Contributor
chiragsalian
left a comment
chiragsalian
left a comment
There was a problem hiding this comment.
left a comment, rest LGTM
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Contributor
Author
|
@mountiny feel free to leave any suggestions if you'd like and I can create a follow-up PR |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Comment on lines
+61
to
+62
| # Generated eslint-report HTML (npm run eslint-report) | ||
| reports/ |
Contributor
There was a problem hiding this comment.
Suggested change
| # Generated eslint-report HTML (npm run eslint-report) | |
| reports/ | |
| # Generated eslint-report HTML (npm run eslint-report) | |
| /reports/ |
@roryabraham This is ignoring all reports folder in the codebase. Can you please fix this.
Contributor
Author
There was a problem hiding this comment.
good catch, sorry about that! @marcochavezf fixed it for me
52 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.65-0 🚀
Bundle Size Analysis (Sentry): |
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.65-6 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adds an
eslint-reportdeveloper script (npm run eslint-report) that parsesconfig/eslint/eslint.seatbelt.tsvand writes an HTML dashboard (reports/eslint-report.htmlby default) with:package.json)scripts/utils/CLI.ts(--output,--git-limit,--top-rules,--no-open)This does not change the mobile app, web app bundles, or staging/production behavior — tooling only.
Fixed Issues
$
PROPOSAL:
Internal tooling only — no linked App issue.
Tests
npm run eslint-report.reports/eslint-report.htmlis created.Offline tests
None.
QA Steps
None.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos