fix: Attendees are not copied in alphabetical order when they are arranged alphabetically by TaduJR · Pull Request #89175 · Expensify/App

TaduJR · 2026-04-29T12:28:24Z

Explanation of Change

On the merged-expense flow, attendees rendered as sorted pills but the hover-Copy button and the merge Select details page returned them in insertion order. Pills also stripped @expensify.sms while these other paths leaked it.

Sort once at the data layer; let consumers opt in.

getAttendeesListDisplayString (src/libs/TransactionUtils): accepts an optional localeCompare (sorts when passed, preserves insertion order otherwise) and strips Str.removeSMSDomain from each name + the sort key. Fixes the merge details page and the hover-Copy value. Sort is case-insensitive to match sortAlphabetically (the pill sort).
enrichAndSortAttendees (new helper in src/libs/AttendeeUtils): enriches attendees with live personalDetails and sorts once. MoneyRequestView and AttendeeField call it at the top; the same canonical list feeds pills, hover Copy, accessibility label, and the missing-attendees violation check.
React callers thread localeCompare from useLocalize (DetailsReviewPage → getDisplayValue/buildMergeFieldsData). Non-React paths (ModifiedExpenseMessage → 5 callers) intentionally skip sorting — no custom collator in utils, no threading ripple.
Replaced the inline actualAttendees.map(...).join(', ') / iouAttendees?.map(...).join(', ') expressions in MoneyRequestView and AttendeeField with calls to getAttendeesListDisplayString.

Fixed Issues

$ #89130
PROPOSAL:

Tests

Setup (precondition):

On a workspace, go to More features > Rules and enable Rules.
Go to Workspace > Rules and enable Attendee tracking.

A. Hover-Copy on merge confirm page (deploy blocker repro)

Open the workspace chat.
Click + > Create expense > Manual.
Enter an amount > Next.
On the confirm page, click Attendees.
Add an attendee named "banana", then add one named "apple", then submit. Click Create expense.
Create one more expense (no attendees needed).
Open the report.
Bulk-select both expenses.
Click the dropdown > Merge.
On the Select details page, in the Attendees section verify the attendees are listed in alphabetical order (apple, banana, …) — not the insertion order.
Pick any attendees option to keep, fill in any other required selections, then click Continue.
On the merge confirm page, hover over the Attendees field and click the Copy button that appears.
Close the RHP and paste the clipboard contents anywhere.
Verify the pasted text matches the order shown in the pills (e.g. "apple, banana, …") — alphabetical, not insertion order.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Macbook-Chrome.mp4

melvin-bot · 2026-04-29T12:28:31Z

@nyomanjyotisa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-04-29T12:36:58Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...RequestConfirmationList/sections/AttendeeField.tsx	`92.59% <100.00%> (-0.96%)`	⬇️
...c/components/ReportActionItem/MoneyRequestView.tsx	`74.50% <100.00%> (+1.10%)`	⬆️
src/libs/AttendeeUtils.ts	`62.50% <100.00%> (+6.94%)`	⬆️
src/libs/MergeTransactionUtils.ts	`78.60% <100.00%> (ø)`
src/pages/TransactionMerge/DetailsReviewPage.tsx	`0.00% <0.00%> (ø)`
src/libs/TransactionUtils/index.ts	`87.54% <75.00%> (+0.04%)`	⬆️
... and 10 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da3a27bc02

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

… duplication

TaduJR · 2026-04-29T13:42:19Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9c0c801dcd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…ll order

TaduJR · 2026-04-29T14:13:46Z

@codex review

chatgpt-codex-connector · 2026-04-29T14:23:49Z

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

trjExpensify

Attendee pills rollout follow-up. 👍

nyomanjyotisa · 2026-04-30T12:10:36Z

Also, could you fix this issue where we still shows @expensify.sms in DetailsReviewPage and when we copy the attendees

MacOS-Chrome.mp4

…ill-workflow-attendees # Conflicts: # src/libs/Notification/LocalNotification/BrowserNotifications.ts # src/libs/OptionsListUtils/index.ts # src/libs/ReportNameUtils.ts # src/libs/ReportUtils.ts

nyomanjyotisa · 2026-05-04T06:59:30Z

@codex review

chatgpt-codex-connector · 2026-05-04T07:10:59Z

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

nyomanjyotisa · 2026-05-04T14:51:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android-Native.mp4

Android: mWeb Chrome

Android-mWeb.Chrome.mp4

iOS: HybridApp

iOS-Native.mp4

iOS: mWeb Safari

iOS-mWeb.Safari.mp4

MacOS: Chrome / Safari

MacOS-Chrome.mp4

nyomanjyotisa

LGTM!

github-actions · 2026-05-04T15:29:05Z

🚧 @Gonals has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-04T15:33:53Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89175.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-cd840a9-b945a7d-cb0313a2b08b8fe7510c79d6b5742ee5f271d52d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-cd840a9-b945a7d-cc020b0e9cd610d1f41fef2b18add62bf7fdafbd/index.html

Web 🕸️
https://89175.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-04T15:37:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-05T19:18:34Z

🚀 Deployed to staging by https://github.com/Gonals in version: 9.3.67-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-05T19:24:24Z

No help site changes are required for this PR.

This is a bug fix ensuring attendees display in consistent alphabetical order across all views (merge details page, hover-copy, accessibility labels). The changes are purely code-level sorting logic and don't introduce new features, change UI labels, or modify user-facing workflows. The existing help site articles about attendees don't reference sort order, so no documentation updates are needed.

fix: sort attendees in one canonical order across all consumers

da3a27b

TaduJR requested review from a team as code owners April 29, 2026 12:28

melvin-bot Bot assigned TaduJR Apr 29, 2026

melvin-bot Bot requested review from nyomanjyotisa and trjExpensify and removed request for a team April 29, 2026 12:28

melvin-bot Bot removed the request for review from a team April 29, 2026 12:28

github-actions Bot reviewed Apr 29, 2026

View reviewed changes

Comment thread src/components/ReportActionItem/MoneyRequestView.tsx

chatgpt-codex-connector Bot reviewed Apr 29, 2026

View reviewed changes

Comment thread src/libs/TransactionUtils/index.ts Outdated

TaduJR added 2 commits April 29, 2026 15:41

refactor: extract enrichAndSortAttendees into AttendeeUtils to remove…

b3d80d1

… duplication

fix: sort attendees with the app's preferred locale

9c0c801

chatgpt-codex-connector Bot reviewed Apr 29, 2026

View reviewed changes

Comment thread src/libs/TransactionUtils/index.ts Outdated

fix: lowercase attendees before comparing so joined string matches pi…

1f85c8b

…ll order

trjExpensify previously approved these changes Apr 30, 2026

View reviewed changes

nyomanjyotisa reviewed Apr 30, 2026

View reviewed changes

Comment thread src/libs/TransactionUtils/index.ts Outdated

refactor: thread localeCompare through utils

a8234f8

TaduJR dismissed trjExpensify’s stale review via a8234f8 April 30, 2026 04:47

refactor: shorten localeCompareLocal JSDoc to a single line

e4dc39d

nyomanjyotisa reviewed Apr 30, 2026

View reviewed changes

Comment thread src/libs/Localize/index.ts Outdated

TaduJR added 2 commits May 2, 2026 21:24

Merge branch 'main' of https://github.com/TaduJR/App into feat-user-p…

f61c540

…ill-workflow-attendees # Conflicts: # src/libs/Notification/LocalNotification/BrowserNotifications.ts # src/libs/OptionsListUtils/index.ts # src/libs/ReportNameUtils.ts # src/libs/ReportUtils.ts

fix: strip @expensify.sms from joined attendee string

1082c1d

TaduJR requested a review from nyomanjyotisa May 2, 2026 19:10

nyomanjyotisa approved these changes May 4, 2026

View reviewed changes

melvin-bot Bot requested a review from Gonals May 4, 2026 14:52

Gonals approved these changes May 4, 2026

View reviewed changes

Gonals merged commit cd840a9 into Expensify:main May 4, 2026
43 of 44 checks passed

OSBotify mentioned this pull request May 5, 2026

Deploy Checklist: New Expensify 2026-05-05 #89627

Open

81 tasks

Conversation

TaduJR commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 29, 2026

Uh oh!

Uh oh!

codecov Bot commented Apr 29, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

TaduJR commented Apr 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

TaduJR commented Apr 29, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 29, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nyomanjyotisa commented Apr 30, 2026

Uh oh!

nyomanjyotisa commented May 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 4, 2026

Uh oh!

nyomanjyotisa commented May 4, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

nyomanjyotisa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

OSBotify commented May 4, 2026

Uh oh!

OSBotify commented May 5, 2026

Uh oh!

MelvinBot commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

TaduJR commented Apr 29, 2026 •

edited

Loading

codecov Bot commented Apr 29, 2026 •

edited by github-actions Bot

Loading