[cp staging] Fix report becoming invisible after deleting another report on mobile by Krishna2323 · Pull Request #89198 · Expensify/App

Krishna2323 · 2026-04-29T16:05:34Z

Explanation of Change

Fixed Issues

$ #89189
PROPOSAL:

Tests

Open the Expensify app on Android
Open any workspace chat
Create two manual expenses on two different reports
Navigate to Spend > Reports
Long tap and select the report displayed second
Tap on the dropdown menu and delete the report
Verify the remaining report preview is fully visible and not blank

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

pr2_test_1_android.mp4

pr2_test_1_web_chrome.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

codecov · 2026-04-29T16:15:58Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...arch/SearchList/ListItem/ExpenseReportListItem.tsx	`0.00% <0.00%> (ø)`
... and 19 files with indirect coverage changes

Krishna2323 · 2026-04-29T16:16:32Z

@codex review

JS00001 · 2026-04-29T16:25:25Z

lmk when this one is ready

chatgpt-codex-connector · 2026-04-29T16:26:19Z

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2026-04-29T16:49:39Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2026-04-29T16:50:19Z

@situchan @JS00001 Ready for review. I can’t reproduce #89191 — can you?

JS00001 · 2026-04-29T16:51:22Z

I haven't been able to, no

JS00001 · 2026-04-29T16:51:38Z

let me ask for a retest

situchan · 2026-04-29T17:06:38Z

Please generate adhoc build

github-actions · 2026-04-29T17:15:48Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

situchan · 2026-04-29T17:55:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mp4

Android: mWeb Chrome

iOS: HybridApp

msafari.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

Not affected on web

OSBotify · 2026-04-29T18:40:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Fix report becoming invisible after deleting another report on mobile (cherry picked from commit 7ab687d) (cherry-picked to staging by arosiclair)

OSBotify · 2026-04-29T19:21:35Z

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.3.64-21 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-29T19:22:59Z

This PR is a UI bug fix — it corrects a rendering issue where a report preview becomes blank/invisible after deleting another report on mobile. The only change is styling logic (border radius and overflow handling) in ExpenseReportListItem.tsx.

No help site changes are required. This fix doesn't affect any user-facing features, workflows, settings, or terminology documented under docs/articles. It's purely a visual rendering fix with no documentation impact.

github-actions · 2026-04-29T20:04:33Z

🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-29T20:10:04Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89198.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7ab687d-5784d71-c444bba68c0fae01d0751f9f803c4e565321320e/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7ab687d-5784d71-6e8dea1232b8fd0377a10e6137175e3b932e532c/index.html

Web 🕸️
https://89198.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Fix report becoming invisible after deleting another report on mobile

90c6ab9

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot Bot assigned Krishna2323 Apr 29, 2026

Fix report becoming invisible after deleting another report on mobile

5217d4a

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review April 29, 2026 16:49

Krishna2323 requested review from a team as code owners April 29, 2026 16:49

melvin-bot Bot requested review from situchan and trjExpensify and removed request for a team April 29, 2026 16:49

JS00001 approved these changes Apr 29, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

situchan approved these changes Apr 29, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 April 29, 2026 17:57

arosiclair approved these changes Apr 29, 2026

View reviewed changes

arosiclair merged commit 7ab687d into Expensify:main Apr 29, 2026
48 of 51 checks passed

JS00001 changed the title ~~Fix report becoming invisible after deleting another report on mobile~~ [cp staging] Fix report becoming invisible after deleting another report on mobile Apr 29, 2026

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Apr 29, 2026

OSBotify mentioned this pull request Apr 29, 2026

Deploy Checklist: New Expensify 2026-04-23 #88633

Open

arosiclair mentioned this pull request Apr 29, 2026

PR checklist #89226

Open

Conversation

Krishna2323 commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Apr 29, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Krishna2323 commented Apr 29, 2026

Uh oh!

JS00001 commented Apr 29, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 29, 2026

Uh oh!

melvin-bot Bot commented Apr 29, 2026

Uh oh!

Krishna2323 commented Apr 29, 2026

Uh oh!

JS00001 commented Apr 29, 2026

Uh oh!

JS00001 commented Apr 29, 2026

Uh oh!

situchan commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

This comment has been minimized.

situchan commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Apr 29, 2026

Uh oh!

OSBotify commented Apr 29, 2026

Uh oh!

MelvinBot commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Krishna2323 commented Apr 29, 2026 •

edited

Loading

codecov Bot commented Apr 29, 2026 •

edited by github-actions Bot

Loading

situchan commented Apr 29, 2026 •

edited

Loading