fix go back home#89214
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-04-29.22.38.00.movAndroid: mWeb Chrome2026-04-29.22.37.14.moviOS: HybridApp2026-04-29.22.38.00.moviOS: mWeb Safari2026-04-29.22.37.14.movMacOS: Chrome / Safari2026-04-29.22.35.32.mov |
|
LGTM! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…bugfix/89209-goBackToHome fix go back home (cherry picked from commit bf1b257) (cherry-picked to staging by arosiclair)
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.3.64-22 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This is a small internal navigation bug fix — it adds a |
Explanation of Change
Tweaked a navigation edge case so the back-navigation flow correctly lands on the Home tab after dismissing a Not Found page, instead of bouncing the user to a previously visited screen.
Fixed Issues
$ #89209
PROPOSAL:
Tests
https://staging.new.expensify.com/abcd.Offline tests
Unnecessary
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
iOS: Native
Screen.Recording.2026-04-29.at.21.53.46.mov