Show recently used tags in tag picker and save them in trackExpense flow#89231
Draft
MelvinBot wants to merge 1 commit into
Draft
Show recently used tags in tag picker and save them in trackExpense flow#89231MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
…em in trackExpense flow The tag picker never showed recently used tags when there were fewer than 12 enabled tags because the getTagListSections function returned early before reaching the recents logic. Additionally, the trackExpense flow never saved recently used tags to Onyx, so even if the UI rendered them, the data would be empty. Moved the filteredRecentlyUsedTags computation before the small-list early return so the recents section is shown when valid recently used tags exist. Added policyRecentlyUsedTags to the trackExpense policyParams in useExpenseSubmission, SubmitDetailsPage, and wired it through TrackExpense.ts to compute and persist optimistic recently used tags to Onyx. Co-authored-by: Chavda Sachin <ChavdaSachin@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The tag picker never displayed recently used tags when there were fewer than 12 enabled tags because
getTagListSectionsinTagsOptionsListUtils.tsreturned early before reaching the recents logic. Additionally, thetrackExpenseflow never passed or persistedpolicyRecentlyUsedTagsto Onyx, so even workspaces with 12+ tags would not accumulate recently used tags from tracked expenses.Fix 1 (UI): Moved the
filteredRecentlyUsedTagscomputation before the small-list threshold check so the "Recent" section is shown when valid recently used tags exist, even with fewer than 12 tags.Fix 2 (Data): Added
policyRecentlyUsedTagsto thepolicyParamspassed totrackExpenseinuseExpenseSubmission.tsandSubmitDetailsPage.tsx, and wired it throughTrackExpense.tsto compute and persist optimistic recently used tags viabuildOptimisticPolicyRecentlyUsedTags, matching the existing pattern used by therequestMoneyflow.Fixed Issues
$ #86197
PROPOSAL: #86197 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
// TODO: The human co-author must fill out offline tests before marking this PR as "ready for review"
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
AI Tests
npm run typecheck-tsgo— passednpm run lint-changed— passednpx prettier --write— all files unchanged (already formatted)npm test -- TagsOptionsListUtilsTest— 16/16 tests passednpm run react-compiler-compliance-check check-changed— could not run (CI environment issue: no upstream branch configured)