fix: Attendees Not Displayed in Expense View on New Expensify (Visible in Classic) by Eskalifer1 · Pull Request #89248 · Expensify/App

Eskalifer1 · 2026-04-30T06:42:30Z

Explanation of Change

Sometimes, after changing Attendees in OD, the backend would return the value of transaction?.comment?.attendees as a Map object, while the frontend expected only an array. This caused the system to fall back to the report owner instead of using the attendees returned by the backend. This PR fixes this bug

Fixed Issues

$#88756
PROPOSAL:#88756 (comment)

Tests

Precondition: have created workspace with enabled rules, enabled Attendee tracking, and with a lot of members(15+)

On ND, create an expense in the Workspace chat. When creating it, add a large number of users (15+) to the Attendees field.
Switch to the same account on OD.
Open the expense from step 1.
Edit the expense so that only one user (you) remains in the Attendees field.
Save the expense.
Edit the same expense again, adding all participants back to the Attendees field.
Save the expense
Go to ND
Open the expense from the previous steps
Make sure all users are displayed, not just you

PS: Here is a link to the full video demonstrating the bug

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

88756-android-native.mov

Android: mWeb Chrome

88756-android-web.mov

iOS: Native

88756-ios-native.mov

iOS: mWeb Safari

88756-ios-web.mov

MacOS: Chrome / Safari

88756-web.mov

…Visible in Classic)

melvin-bot · 2026-04-30T06:42:37Z

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-04-30T07:12:59Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ts/ReportActionAvatars/useReportPreviewSenderID.ts	`95.55% <100.00%> (+0.10%)`	⬆️
src/libs/AttendeeUtils.ts	`65.71% <100.00%> (+3.21%)`	⬆️
src/libs/TransactionUtils/index.ts	`87.83% <100.00%> (ø)`
src/libs/Violations/ViolationsUtils.ts	`77.13% <100.00%> (ø)`
src/libs/SearchUIUtils.ts	`63.75% <0.00%> (ø)`
... and 9 files with indirect coverage changes

joekaufmanexpensify

Good for product

linhvovan29546 · 2026-05-01T10:21:02Z

@Eskalifer1 I see there are several other places that access raw attendees. Do we need to update those as well? I think we should.

ViolationsUtils.ts:528-529

const rawAttendees = updatedTransaction.modifiedAttendees ?? updatedTransaction.comment?.attendees;
const attendees = Array.isArray(rawAttendees) ? rawAttendees : [];
If rawAttendees is an object, Array.isArray returns false and attendees becomes []. This would incorrectly trigger a "missing attendees" violation even when attendees exist.

AttendeeUtils.ts:79

const attendees = Array.isArray(iouAttendees) ? iouAttendees : [];
Same pattern — getIsMissingAttendeesViolation() would treat object-shaped attendees as empty, incorrectly flagging violations.

MoneyRequestView.tsx:287

const actualAttendees = isFromMergeTransaction && updatedTransaction
? updatedTransaction.comment?.attendees : transactionAttendees;
In the merge transaction flow, raw attendees are used directly. Same issue as 2.

TransactionListItem.tsx:165

transaction?.comment?.attendees ?? transactionItem.attendees,
Passed to syncMissingAttendeesViolation → which also hits the Array.isArray guard. Incorrect violation state in search results.

SearchUIUtils.ts:3683-3691

const aValue = a.comment?.attendees?.length ?? 0;
Plain objects don't have .length, so this always resolves to 0. Sorting by attendees count is broken for affected transactions.

useReportPreviewSenderID.ts:75

tr.comment?.attendees?.map?.((att) => ...)
Objects don't have .map, so ?.map?.() returns undefined.

Eskalifer1 · 2026-05-01T10:43:29Z

Good catch, i will take a deeper look today(Hope XD)

Eskalifer1 · 2026-05-01T15:22:56Z

@codex review

Eskalifer1 · 2026-05-01T15:26:01Z

7. TransactionListItem.tsx:165

transaction?.comment?.attendees ?? transactionItem.attendees, Passed to syncMissingAttendeesViolation → which also hits the Array.isArray guard. Incorrect violation state in search results.

I don't think this needs to be corrected, since this value is passed into the function, where it is later passed into another function as attendees ?? []:

App/src/libs/AttendeeUtils.ts

Line 115 in 536d1dd

    
           isControlPolicy && getIsMissingAttendeesViolation(policyCategories ?? {}, category ?? '', attendees ?? [], userPersonalDetails, isAttendeeTrackingEnabled, isControlPolicy);

Which later ends up here:

App/src/libs/AttendeeUtils.ts

Line 79 in 536d1dd

const attendees = Array.isArray(iouAttendees) ? iouAttendees : [];

And we fixed this part

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 10d9de7714

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-01T15:38:49Z

+    if (rawAttendees && typeof rawAttendees === 'object') {
+        return Object.values(rawAttendees as Record<string, Attendee>);


Handle Map attendees in conversion helper

Update convertAttendeesToArray to explicitly support Map inputs before calling Object.values. In the problematic flow this PR targets, attendees can arrive as a Map, and Object.values(map) returns an empty array, so downstream logic still treats attendees as missing and falls back to the report owner. That means the cross-app attendee display bug remains for transactions whose attendee payload is a real Map instance.

Useful? React with 👍 / 👎.

I haven't seen Expensify use Maps for this kind of thing yet, so I don't think it's relevant.

In this specific case, we're fixing a bug where an object is passed instead of an array, so I don't think it's worth doing.

Eskalifer1 · 2026-05-01T15:42:46Z

@linhvovan29546 PR is updated!

linhvovan29546 · 2026-05-05T02:56:40Z

+ * Converts raw attendees value to an array.
+ * Onyx may deserialize arrays as plain objects, so both shapes are handled.
+ */
+function convertAttendeesToArray(rawAttendees: Attendee[] | undefined): Attendee[] {


I think we can update the parameter type from Attendee[] | undefined to unknown, since it can be an array, an object, or other types like a string. So we don’t need to cast the attendees when passing them to convertAttendeesToArray.

linhvovan29546 · 2026-05-05T02:59:07Z

@Eskalifer1 Could you please resolve the conflicts? I’ll try to complete testing today.

Eskalifer1 · 2026-05-05T07:59:22Z

Hi @linhvovan29546! Merged main!

I checked, and here we don't need to convert it to an array; we can just leave it as is:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 287 in 3f5e62c

    
           const rawActualAttendees = isFromMergeTransaction && updatedTransaction ? updatedTransaction.comment?.attendees : transactionAttendees;

Since updatedTransaction is only present in two flows: Merge or Resolve duplicate. But here there is only isFromMergeTransaction, so this value updatedTransaction.comment?.attendees is used only in the Merge flow, but I checked there and this value is already an array, not an object, so I don’t think there’s any point in adding this check, since it’s always an array there anyway, and besides, the logic has changed there (which is why there was a conflict).

linhvovan29546 · 2026-05-05T08:21:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-05-05.at.16.47.41.mov

Android: mWeb Chrome

Screen.Recording.2026-05-05.at.16.49.31.mov

iOS: HybridApp

Screen.Recording.2026-05-05.at.15.39.06.mov

iOS: mWeb Safari

Screen.Recording.2026-05-05.at.15.43.41.mov

MacOS: Chrome / Safari

Screen.Recording.2026-05-05.at.15.20.49.mov

Julesssss

Looking good, there's just the submodule conflict to resolve. I don't think we need to touch that commit number

linhvovan29546 · 2026-05-06T07:35:09Z

@Eskalifer1 Could you please revert this change?

Eskalifer1 · 2026-05-06T09:29:18Z

Hi @linhvovan29546, sorry, i have missed this message yesterday. Already done!

linhvovan29546 · 2026-05-06T13:10:42Z

@Eskalifer1 Eslint failed. Could you please merge main again?

OSBotify · 2026-05-06T17:41:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-06T18:54:08Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-06T19:04:20Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89248.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9caaac9-b455923-c1f714e98a1674917e48bfb479076678c700c8f9/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9caaac9-b455923-3c51dc72d308dbddde16e3b01a17e57ead4d3a66/index.html

Web 🕸️
https://89248.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-06T22:53:00Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.68-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-06T22:54:20Z

No help site changes required.

This PR is a pure internal bug fix — it adds a convertAttendeesToArray utility to handle cases where Onyx deserializes attendee arrays as plain objects (Maps). The changes are limited to TypeScript utility files and unit tests. No user-facing behavior, UI labels, workflows, or feature descriptions changed, so no updates to App/docs/articles are needed.

OSBotify · 2026-05-08T15:11:05Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.68-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix:88756: Attendees Not Displayed in Expense View on New Expensify (…

a2cdbb1

…Visible in Classic)

Eskalifer1 requested review from a team as code owners April 30, 2026 06:42

melvin-bot Bot assigned Eskalifer1 Apr 30, 2026

melvin-bot Bot requested review from joekaufmanexpensify and linhvovan29546 and removed request for a team April 30, 2026 06:42

melvin-bot Bot removed the request for review from a team April 30, 2026 06:42

fix:eslint

80246c1

joekaufmanexpensify previously approved these changes Apr 30, 2026

View reviewed changes

convert attendes to array

10d9de7

Eskalifer1 dismissed joekaufmanexpensify’s stale review via 10d9de7 May 1, 2026 15:22

chatgpt-codex-connector Bot reviewed May 1, 2026

View reviewed changes

linhvovan29546 suggested changes May 5, 2026

View reviewed changes

Eskalifer1 added 3 commits May 5, 2026 09:58

c+ comment

26a5beb

Merge remote-tracking branch 'origin' into fix/88756

d2cbfe2

CI fix

0f18ee6

linhvovan29546 approved these changes May 5, 2026

View reviewed changes

melvin-bot Bot requested a review from Julesssss May 5, 2026 09:53

Julesssss reviewed May 5, 2026

View reviewed changes

Eskalifer1 added 2 commits May 6, 2026 12:21

Merge remote-tracking branch 'origin' into fix/88756

4671008

Fix submodule pointer

012a2b1

Merge remote-tracking branch 'origin' into fix/88756

4a83013

linhvovan29546 approved these changes May 6, 2026

View reviewed changes

melvin-bot Bot requested a review from Julesssss May 6, 2026 13:44

Julesssss approved these changes May 6, 2026

View reviewed changes

Julesssss merged commit 9caaac9 into Expensify:main May 6, 2026
38 checks passed

OSBotify mentioned this pull request May 6, 2026

Deploy Checklist: New Expensify 2026-05-06 #89819

Closed

73 tasks

melvin-bot Bot mentioned this pull request May 8, 2026

[Due for payment 2026-05-15] [$250] Attendees Not Displayed in Expense View on New Expensify (Visible in Classic) #88756

Open

7 tasks

		if (rawAttendees && typeof rawAttendees === 'object') {
		return Object.values(rawAttendees as Record<string, Attendee>);

Conversation

Eskalifer1 commented Apr 30, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 30, 2026

Uh oh!

codecov Bot commented Apr 30, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 commented May 1, 2026

Uh oh!

Eskalifer1 commented May 1, 2026

Uh oh!

Eskalifer1 commented May 1, 2026

Uh oh!

Eskalifer1 commented May 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Eskalifer1 May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Eskalifer1 commented May 1, 2026

Uh oh!

linhvovan29546 May 5, 2026

Choose a reason for hiding this comment

Uh oh!

Eskalifer1 May 5, 2026

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 commented May 5, 2026

Uh oh!

Eskalifer1 commented May 5, 2026

Uh oh!

linhvovan29546 commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 commented May 6, 2026

Uh oh!

Eskalifer1 commented May 6, 2026

Uh oh!

linhvovan29546 commented May 6, 2026

Uh oh!

Uh oh!

OSBotify commented May 6, 2026

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

OSBotify commented May 6, 2026

Uh oh!

MelvinBot commented May 6, 2026

Uh oh!

OSBotify commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

codecov Bot commented Apr 30, 2026 •

edited by github-actions Bot

Loading

linhvovan29546 commented May 5, 2026 •

edited

Loading