[CP Staging] fix(iOS): prevent native MVCP from activating when disabled flag is set in FlashList patch 007 by sosek108 · Pull Request #89253 · Expensify/App

sosek108 · 2026-04-30T08:12:04Z

Explanation of Change

Patch 007 (fix-scroll-anchor-unmount-on-ios) introduced a regression where maintainVisibleContentPositionInternal — which is forwarded to the native iOS ScrollView as the maintainVisibleContentPosition prop — became {disabled: true, minIndexForVisible: 0} instead of undefined for lists that have maintainVisibleContentPosition={{disabled: true}} (e.g. BaseSearchList).

The native ScrollView doesn't understand the disabled field — it sees an active MVCP config and activates MVCP. When entering selection mode on Spend > Expenses, a header renders outside the FlashList as a sibling, causing a layout shift. The active native MVCP "corrects" the scroll position, producing a blank space at the top.

Fix: split the two conditions that patch 007 incorrectly unified:

scrollAnchor: keep maintainVisibleContentPosition != null — ScrollAnchor stays mounted when the prop exists, preserving the original fix (no stale _prevFirstVisibleFrame → no scroll jump)
maintainVisibleContentPositionInternal: add && !maintainVisibleContentPosition.disabled — native MVCP only activates when truly enabled

Fixed Issues

$ #89191
PROPOSAL:

Tests

Launch Expensify app on iOS
Go to workspace chat
Create two expenses
Go to Spend > Expenses
Long tap on any expense → Select
Verify no blank space appears above the expense list in selection mode
Tap back button
Verify the expense list does not auto-scroll up after exiting selection mode

Regression check (original bugs fixed by patch 007):
9. Open a chat with multiple messages and IOUs — scroll up and down on iOS, verify no sudden scroll jump to top
10. Open a permalinked report and scroll up quickly — verify MVCP toggles cleanly without scroll reset

Offline tests

N/A — this fix is purely a FlashList scroll behaviour patch, unaffected by network state.

QA Steps

Launch Expensify app on iOS
Go to workspace chat
Create two expenses
Go to Spend > Expenses
Long tap on any expense → Select
Verify no blank space appears above the expense list in selection mode
Tap back button
Verify the expense list does not auto-scroll up after exiting selection mode

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Nagranie.z.ekranu.2026-04-30.o.10.16.26.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-04-30T08:12:16Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

melvin-bot · 2026-04-30T08:18:12Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2026-04-30T08:33:21Z

Confirmed working! As this will be CP'ed to staging, let's make sure this doesn't cause any side effect.
Also not re-introduce bugs original patch fixed:

[Due for payment 2026-05-11][$250] Chat Does Not Auto-Scroll or Show New Message Indicator for Incoming Messages #88238
[Due for payment 2026-05-11] [Due for payment 2026-05-07] iOS - Chat - Report turns blank when swiping up #88955
[Due for payment 2026-05-11] [Due for payment 2026-05-07] iOS - Chat - WS chat becomes blank when opening and scrolling after duplicate expenses #89052

situchan · 2026-04-30T08:45:51Z

Just retested and confirmed above issues are still fixed.

situchan · 2026-04-30T08:46:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mp4

Android: mWeb Chrome

iOS: HybridApp

ios.MP4

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

github-actions · 2026-04-30T11:58:40Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-04-30T12:17:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-04-30T12:52:42Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89253.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7a7b159-d1461d1-fd9ab768cd78f9355046aeb1706d96e9f08aa6eb/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7a7b159-d1461d1-9f80ea0a65f787c83cba431cb7d618776ff0d3a2/index.html

Web 🕸️
https://89253.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

…-disabled-blank-space [CP Staging] fix(iOS): prevent native MVCP from activating when disabled flag is set in FlashList patch 007 (cherry picked from commit 7a7b159) (cherry-picked to staging by arosiclair)

OSBotify · 2026-04-30T14:29:50Z

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.3.64-24 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-04-30T22:53:06Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.3.64-31 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-04-30T23:12:28Z

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.3.65-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-05-04T13:31:23Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.65-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix(iOS): prevent native MVCP from activating when disabled flag is set

5e3a61d

melvin-bot Bot assigned sosek108 Apr 30, 2026

sosek108 mentioned this pull request Apr 30, 2026

[Due for payment 2026-05-11] iOS - Spend - Blank space appears above list after entering selection mode #89191

Open

7 tasks

sosek108 marked this pull request as ready for review April 30, 2026 08:18

sosek108 requested a review from a team as a code owner April 30, 2026 08:18

melvin-bot Bot requested review from situchan and removed request for a team April 30, 2026 08:18

situchan approved these changes Apr 30, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 April 30, 2026 08:59

JS00001 approved these changes Apr 30, 2026

View reviewed changes

JS00001 changed the title ~~fix(iOS): prevent native MVCP from activating when disabled flag is set in FlashList patch 007~~ [CP Staging] fix(iOS): prevent native MVCP from activating when disabled flag is set in FlashList patch 007 Apr 30, 2026

JS00001 merged commit 7a7b159 into Expensify:main Apr 30, 2026
45 of 49 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Apr 30, 2026

OSBotify mentioned this pull request Apr 30, 2026

Deploy Checklist: New Expensify 2026-04-23 #88633

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] fix(iOS): prevent native MVCP from activating when disabled flag is set in FlashList patch 007#89253

[CP Staging] fix(iOS): prevent native MVCP from activating when disabled flag is set in FlashList patch 007#89253
JS00001 merged 1 commit intoExpensify:mainfrom
callstack-internal:fix/flash-list-mvcp-disabled-blank-space

sosek108 commented Apr 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

melvin-bot Bot commented Apr 30, 2026

Uh oh!

situchan commented Apr 30, 2026

Uh oh!

situchan commented Apr 30, 2026

Uh oh!

situchan commented Apr 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

OSBotify commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

OSBotify commented Apr 30, 2026

Uh oh!

OSBotify commented Apr 30, 2026

Uh oh!

OSBotify commented Apr 30, 2026

Uh oh!

OSBotify commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

sosek108 commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

melvin-bot Bot commented Apr 30, 2026

Uh oh!

situchan commented Apr 30, 2026

Uh oh!

situchan commented Apr 30, 2026

Uh oh!

situchan commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

OSBotify commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

OSBotify commented Apr 30, 2026

Uh oh!

OSBotify commented Apr 30, 2026

Uh oh!

OSBotify commented Apr 30, 2026

Uh oh!

OSBotify commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sosek108 commented Apr 30, 2026 •

edited

Loading

situchan commented Apr 30, 2026 •

edited

Loading