Don't fire duplicate ReconnectApp on delegate account switch by TMisiukiewicz · Pull Request #89262 · Expensify/App

TMisiukiewicz · 2026-04-30T12:00:36Z

Explanation of Change

When a user switches accounts via delegate access, the app sends OpenApp and then an unnecessary ReconnectApp right after. This PR removes that extra request. The two are not duplicates — they hit different endpoints — but the second one is wasted work because OpenApp has already brought down the freshest data.

It's safe because no real sync is skipped. The OpenApp we just sent IS a full sync. The safety net's job is "you might be stale, refresh." After OpenApp you're not stale. Skipping the immediately-following ReconnectApp doesn't lose any data.

Fixed Issues

$ #89271
PROPOSAL:

Tests

Login into an account with delegate access
Open devtools and network tab
Go to Settings -> Profile
Switch between accounts
Verify ReconnectApp is not called after OpenApp

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-04-30T12:07:00Z

@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-04-30T12:15:09Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/Delegate.ts	`34.70% <100.00%> (+0.38%)`	⬆️
... and 7 files with indirect coverage changes

mountiny · 2026-04-30T12:52:32Z

@abzokhattab can you please prioritize the review?

Copilot

Pull request overview

Reduces unnecessary network traffic when switching accounts via delegate access by preventing an immediately-following full reconnect from being triggered right after OpenApp, avoiding redundant sync work.

Changes:

Introduces clearOnyxForDelegateTransition() to seed LAST_FULL_RECONNECT_TIME before clearing Onyx during delegate transitions.
Replaces direct Onyx.clear(KEYS_TO_PRESERVE_DELEGATE_ACCESS) calls with clearOnyxForDelegateTransition() in delegate connect/disconnect/restore flows.
Updates the OldDot→NewDot delegate-switch transition flow to use the new clear helper.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/libs/actions/Session/index.ts	Uses the new delegate-transition Onyx clear helper during OldDot account switching to avoid triggering redundant reconnect behavior.
src/libs/actions/Delegate.ts	Adds and exports `clearOnyxForDelegateTransition()` and switches existing delegate flows to use it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+ * duplicate ReconnectApp on top of the OpenApp that follows the transition. Seeding
+ * it to `now` short-circuits the subscriber until OpenApp's successData refreshes it.
+ */
+function clearOnyxForDelegateTransition(): Promise<void> {


abzokhattab · 2026-04-30T13:32:24Z

lets add a test for the clearOnyxForDelegateTransition to increase the coverage

abzokhattab · 2026-04-30T13:42:22Z

Nice perf win for the delegate transition. One observation worth flagging (not blocking): the same Onyx.clear → openApp race exists in a few other flows that go through the same subscribeToFullReconnect comparator, so they'll keep firing the duplicate ReconnectApp after this lands:

src/libs/actions/Session/index.ts#L451 — supportal restore stashed session
src/libs/actions/App.ts#L163 — RESET_REQUIRED listener
src/libs/actions/App.ts#L855 — clearOnyxAndResetApp (sign-out / exit imported state)

In each, after the clear LAST_FULL_RECONNECT_TIME is '', and the next openApp() writes NVP_RECONNECT_APP_IF_FULL_RECONNECT_BEFORE via response.onyxData (which applyHTTPSOnyxUpdates applies before successData), so '' < serverTime triggers the same redundant reconnectApp(). The preserve lists at KEYS_TO_PRESERVE and KEYS_TO_PRESERVE_SUPPORTAL don't include LAST_FULL_RECONNECT_TIME, so the seed trick is needed in those flows too.

i think a good approach is to is to generalize the helper (e.g. clearOnyxAndSeedFullReconnect(keysToPreserve)) and reuse it from these callsites what do u tihnk ... should we tackle them?

mountiny · 2026-04-30T13:47:01Z

@MelvinBot can you please create a dedicated issue for this pull request and assign @mountiny and @TMisiukiewicz and @abzokhattab. Make it with Daily, Bug, Reviewing labels

mountiny · 2026-04-30T13:47:30Z

Lets add a test and push this ahead - if no regressions are found we can generalize it for the other flows too, what do you think?

MelvinBot · 2026-04-30T13:49:40Z

Created a dedicated issue for this PR: #89271

Assigned to mountiny, TMisiukiewicz, and abzokhattab with Daily, Bug, and Reviewing labels.

abzokhattab · 2026-04-30T15:06:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-04-30.at.18.05.24.mov

Android: mWeb Chrome

Screen.Recording.2026-04-30.at.18.04.33.mov

iOS: HybridApp

Screen.Recording.2026-04-30.at.18.05.24.mov

iOS: mWeb Safari

Screen.Recording.2026-04-30.at.18.04.33.mov

MacOS: Chrome / Safari

Screen.Recording.2026-04-30.at.18.02.24.mov

abzokhattab · 2026-04-30T15:09:03Z

LGTM 🚀🚀

joekaufmanexpensify · 2026-04-30T18:28:52Z

No product review needed

mountiny · 2026-05-01T06:22:04Z

@TMisiukiewicz conflicts

…ll-reconnect-time-on-delegate-switch # Conflicts: # src/libs/actions/Delegate.ts

TMisiukiewicz · 2026-05-04T07:11:06Z

@mountiny done ✅

mountiny

Thank you

OSBotify · 2026-05-04T13:03:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-04T13:04:56Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-04T13:12:49Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89262.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f824da8-34a8d39-542fc1eaec6496aba20f8c36fa6d87872738087b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f824da8-34a8d39-ed261a1f48bd2e4ba6467e46b1d3de5f22f14b98/index.html

Web 🕸️
https://89262.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-04T13:28:38Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.66-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-05-04T13:29:51Z

No help site changes are required for this PR. The changes are an internal performance optimization that prevents a duplicate ReconnectApp API call during delegate account switching — no user-facing behavior, UI, or workflows are affected.

Seed LAST_FULL_RECONNECT_TIME before Onyx.clear on delegate transition

a6c717e

melvin-bot Bot assigned TMisiukiewicz Apr 30, 2026

TMisiukiewicz marked this pull request as ready for review April 30, 2026 12:06

TMisiukiewicz requested review from a team as code owners April 30, 2026 12:06

melvin-bot Bot requested review from abzokhattab and joekaufmanexpensify and removed request for a team April 30, 2026 12:06

melvin-bot Bot removed the request for review from a team April 30, 2026 12:07

mountiny requested review from Copilot and mountiny April 30, 2026 12:52

Copilot started reviewing on behalf of mountiny April 30, 2026 12:53 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread src/libs/actions/Delegate.ts

* duplicate ReconnectApp on top of the OpenApp that follows the transition. Seeding

* it to `now` short-circuits the subscriber until OpenApp's successData refreshes it.

*/

function clearOnyxForDelegateTransition(): Promise<void> {

MelvinBot mentioned this pull request Apr 30, 2026

[$250] Don't fire duplicate ReconnectApp on delegate account switch #89271

Open

abzokhattab approved these changes Apr 30, 2026

View reviewed changes

joekaufmanexpensify removed their request for review April 30, 2026 18:28

Merge remote-tracking branch 'origin/main' into perf/preserve-last-fu…

1d4e420

…ll-reconnect-time-on-delegate-switch # Conflicts: # src/libs/actions/Delegate.ts

mountiny approved these changes May 4, 2026

View reviewed changes

mountiny merged commit f824da8 into Expensify:main May 4, 2026
36 checks passed

OSBotify mentioned this pull request May 4, 2026

Deploy Checklist: New Expensify 2026-05-04 #89508

Open

77 tasks

Conversation

TMisiukiewicz commented Apr 30, 2026 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 30, 2026

Uh oh!

codecov Bot commented Apr 30, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mountiny commented Apr 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

abzokhattab commented Apr 30, 2026

Uh oh!

abzokhattab commented Apr 30, 2026

Uh oh!

mountiny commented Apr 30, 2026

Uh oh!

mountiny commented Apr 30, 2026

Uh oh!

MelvinBot commented Apr 30, 2026

Uh oh!

abzokhattab commented Apr 30, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

abzokhattab commented Apr 30, 2026

Uh oh!

joekaufmanexpensify commented Apr 30, 2026

Uh oh!

mountiny commented May 1, 2026

Uh oh!

TMisiukiewicz commented May 4, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

OSBotify commented May 4, 2026

Uh oh!

MelvinBot commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

TMisiukiewicz commented Apr 30, 2026 •

edited by mountiny

Loading

codecov Bot commented Apr 30, 2026 •

edited by github-actions Bot

Loading