feat: Add Withdrawal ID column to Expenses search and in report view. by samranahm · Pull Request #89307 · Expensify/App

samranahm · 2026-04-30T20:53:17Z

Explanation of Change

Fixed Issues

$ #88384
PROPOSAL: #88384 (comment)

Tests

Open Spend tab > Expenses
In upper right corner press "Display" dropdown button > Edit columns
Verify "Withdrawal ID" available in Columns list
Select the "Withdrawal ID" > Save
Verify the "Withdrawal ID" column appear in search page
Open a report with 2 or 2+ expense reports
Press "Columns" and select "Withdrawal ID" > Save
Verify the "Withdrawal ID" column available in report view

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A for smaller screens.

Android: mWeb Chrome

N/A for smaller screens.

iOS: Native

N/A for smaller screens.

iOS: mWeb Safari

N/A for smaller screens.

MacOS: Chrome / Safari

macOS.Chrome.mp4

melvin-bot · 2026-04-30T20:53:33Z

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copilot

Pull request overview

Adds support for displaying Withdrawal ID as a selectable column in the Expenses search table and in the expense report (transaction list) view, aligning Expenses with the existing Withdrawal ID filter/grouping capabilities.

Changes:

Adds withdrawalID to the Transaction Onyx type and wires it into search/report table sorting.
Exposes Withdrawal ID as a selectable custom column for Expenses search and report-details columns.
Updates translation-key mapping and adds a unit test for the new translation key.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/unit/Search/SearchUIUtilsTest.ts	Adds a unit test for `getSearchColumnTranslationKey()` for `WITHDRAWAL_ID`.
src/types/onyx/Transaction.ts	Extends the transaction model with optional `withdrawalID`.
src/libs/SearchUIUtils.ts	Adds sorting mapping, translation key mapping, and ensures selected Withdrawal ID column is not filtered out.
src/libs/ReportUtils.ts	Makes Withdrawal ID sortable in report transaction lists and returns the sort value.
src/components/TransactionItemRow/index.tsx	Renders the Withdrawal ID value when the column is selected in report view.
src/CONST/index.ts	Adds Withdrawal ID to selectable custom columns for Expenses and report-details columns.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-30T20:59:36Z

            CONST.SEARCH.TABLE_COLUMNS.TOTAL_PER_ATTENDEE,
+            CONST.SEARCH.TABLE_COLUMNS.WITHDRAWAL_ID,
        ]);

        return customResult.filter((col) => nonDataColumns.has(col) || columns[col]);


Add unit test coverage for the new WITHDRAWAL_ID column behavior in getColumnsToShow. Right now the logic relies on including WITHDRAWAL_ID in the nonDataColumns set so it isn't filtered out by data-presence checks; without a test, it's easy to regress and reintroduce the original bug (column not appearing after being selected). Consider extending the existing custom-columns tests to include WITHDRAWAL_ID and assert it remains visible even when transactions don't have a withdrawalID value.

Copilot · 2026-04-30T20:59:36Z

            CONST.SEARCH.TABLE_COLUMNS.ACTION,
            CONST.SEARCH.TABLE_COLUMNS.ATTENDEES,
            CONST.SEARCH.TABLE_COLUMNS.TOTAL_PER_ATTENDEE,
+            CONST.SEARCH.TABLE_COLUMNS.WITHDRAWAL_ID,
        ]);


The nonDataColumns comment says these columns "always have content", but WITHDRAWAL_ID (added here) can be legitimately empty. Consider rewording that comment to match the actual intent: columns that should not be filtered out by data-presence checks when explicitly selected in custom columns.

codecov · 2026-04-30T21:02:24Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`92.30% <ø> (ø)`
src/components/TransactionItemRow/index.tsx	`83.13% <100.00%> (+0.09%)`	⬆️
src/libs/DebugUtils.ts	`68.73% <100.00%> (+0.06%)`	⬆️
src/libs/SearchUIUtils.ts	`63.83% <100.00%> (+0.03%)`	⬆️
src/libs/ReportUtils.ts	`83.28% <0.00%> (+0.02%)`	⬆️
... and 9 files with indirect coverage changes

trjExpensify · 2026-04-30T22:21:50Z

@heyjennahay wanna' test this one as you requested it?

dmkt9 · 2026-05-01T04:23:30Z

@samranahm typcheck fail

samranahm · 2026-05-01T04:33:23Z

Fixing..

dmkt9 · 2026-05-01T04:38:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

N/A

Android: mWeb Chrome

N/A

iOS: HybridApp

N/A

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

mac.safari.mp4

…-in-columns

…onDraftProperty

samranahm · 2026-05-01T05:20:58Z

@dmkt9 All yours.

trjExpensify

New addition Jenna wanted! 👍

dmkt9

LGTM

github-actions · 2026-05-04T12:38:28Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-05-04T12:39:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-04T12:43:38Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89307.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-2eb3e63-34a8d39-542fc1eaec6496aba20f8c36fa6d87872738087b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-2eb3e63-34a8d39-ed261a1f48bd2e4ba6467e46b1d3de5f22f14b98/index.html

Web 🕸️
https://89307.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-04T13:28:53Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.66-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-05-04T13:31:52Z

After reviewing PR changes and the help site docs under App/docs/articles, no help site changes are required.

The column customization article (Using-Reports-in-New-Expensify.md) intentionally avoids enumerating all available columns, listing only a few examples and directing users to the UI:

"To view the full list of available columns, click the Columns icon in the Spend tab."

Since the docs defer to the product UI for column discovery, adding the new Withdrawal ID column doesn't create a documentation gap.

samranahm added 3 commits May 1, 2026 01:38

Add withdrawalID type and value in Index

14e8755

mplement Withdrawal ID column in search and report view

bb448d7

Add tests for Withdrawal ID column

2c567bd

Copilot AI review requested due to automatic review settings April 30, 2026 20:53

samranahm requested review from a team as code owners April 30, 2026 20:53

melvin-bot Bot assigned samranahm Apr 30, 2026

melvin-bot Bot requested review from dmkt9 and trjExpensify April 30, 2026 20:53

Copilot started reviewing on behalf of samranahm April 30, 2026 20:53 View session

samranahm mentioned this pull request Apr 30, 2026

[$250] Add Withdrawal ID to Custom Columns in Expenses Search #88384

Open

Copilot AI reviewed Apr 30, 2026

View reviewed changes

trjExpensify removed the request for review from a team April 30, 2026 22:20

samranahm added 3 commits May 1, 2026 09:39

fix typecheck

27e9f22

Merge remote-tracking branch 'upstream/main' into 88384/Withdrawal-ID…

4e9adb4

…-in-columns

Add withdrawalID case to string validation group in validateTransacti…

c115d2c

…onDraftProperty

trjExpensify approved these changes May 1, 2026

View reviewed changes

dmkt9 approved these changes May 4, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 May 4, 2026 02:14

JS00001 approved these changes May 4, 2026

View reviewed changes

JS00001 merged commit 2eb3e63 into Expensify:main May 4, 2026
41 of 42 checks passed

OSBotify mentioned this pull request May 4, 2026

Deploy Checklist: New Expensify 2026-05-04 #89508

Open

77 tasks

Conversation

samranahm commented Apr 30, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Apr 30, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify commented Apr 30, 2026

Uh oh!

dmkt9 commented May 1, 2026

Uh oh!

samranahm commented May 1, 2026

Uh oh!

dmkt9 commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

samranahm commented May 1, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

dmkt9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

OSBotify commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

OSBotify commented May 4, 2026

Uh oh!

MelvinBot commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov Bot commented Apr 30, 2026 •

edited by github-actions Bot

Loading

dmkt9 commented May 1, 2026 •

edited

Loading