Skip to content

[NO QA] Docs updates for E/A#88550 Add read-only conversation banner to chat FAQ#89326

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-docsUpdatesReadOnlyBanner
May 6, 2026
Merged

[NO QA] Docs updates for E/A#88550 Add read-only conversation banner to chat FAQ#89326
stephanieelliott merged 1 commit into
mainfrom
claude-docsUpdatesReadOnlyBanner

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Summary

Related PR

#88550

Test plan

  • Verify the updated FAQ answer renders correctly on the help site
  • Confirm the wording matches the actual banner text shown in the app

Added mention of the read-only banner to the FAQ about why users
can't message in some rooms, matching the new UI behavior from
#88550.

Co-authored-by: Kio <KioCoan@users.noreply.github.com>
@stephanieelliott stephanieelliott added the HelpDot Apply this label if the issue relates to ExpensifyHelp label May 6, 2026
@stephanieelliott stephanieelliott marked this pull request as ready for review May 6, 2026 23:18
@stephanieelliott stephanieelliott self-requested a review as a code owner May 6, 2026 23:18
@stephanieelliott stephanieelliott merged commit 0d5121c into main May 6, 2026
23 of 25 checks passed
@stephanieelliott stephanieelliott deleted the claude-docsUpdatesReadOnlyBanner branch May 6, 2026 23:19
@melvin-bot melvin-bot Bot added the Emergency label May 6, 2026
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 6, 2026

@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

HelpDot Documentation Review

Overall Assessment

This PR makes a single, focused change: it expands the FAQ answer for "Why can't I message in some rooms?" in Chat-Features-and-Moderation-Tools.md by adding a sentence about read-only conversations and the banner users will see. The change is small, targeted, and informative.

Scores Summary

  • Readability: 8/10 - The added sentence is clear and describes both the condition (read-only conversation) and the visual indicator (banner text). The resulting sentence is somewhat long when combined with the existing text, but still scannable within an FAQ context.
  • AI Readiness: 8/10 - The additional detail improves retrieval quality by introducing the phrase "read-only" and the specific banner text "This conversation is read-only," which aligns with real user search queries. Note: the file's YAML frontmatter is missing internalScope, which is required per the authoring guidelines -- however, that is pre-existing and outside the scope of this diff.
  • Style Compliance: 9/10 - The language is precise and references the exact UI banner text. The banner text could be bolded (e.g., This conversation is read-only) to match the convention of bolding UI element text per naming conventions, but quoting it in the current form is still reasonably clear.

Key Findings

  • The change correctly addresses a real user question: why messaging is unavailable in certain rooms beyond just admin-restricted permissions.
  • The added sentence references specific UI text ("This conversation is read-only"), which supports deterministic writing and AI retrieval.
  • Minor style note: the banner text is presented in quotes rather than bold formatting. Per HELPSITE_NAMING_CONVENTIONS.md, UI element text should use bold formatting rather than quotation marks.

Recommendations

  • Consider changing "This conversation is read-only" to This conversation is read-only (bold, no quotes) to align with the button/UI element naming conventions that require bold formatting and prohibit quotation marks.
  • No structural or heading changes needed -- the FAQ heading "Why can't I message in some rooms?" is already well-formed as a question-based heading.

Files Reviewed

  • docs/articles/new-expensify/chat/Chat-Features-and-Moderation-Tools.md - Single FAQ answer expanded with read-only room context. Change is appropriate and well-scoped.


## Why can’t I message in some rooms?
Rooms may have restricted posting permissions for Admins only.
Rooms may have restricted posting permissions for Admins only. In other cases, the conversation may be read-only, and you’ll see a "This conversation is read-only" banner at the bottom of the chat.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/style violation: The banner text "This conversation is read-only" is a UI element and should be bolded, not wrapped in quotation marks. Per HELPSITE_NAMING_CONVENTIONS.md, all UI labels must use bold formatting and must not use quotation marks.

Suggested fix:

Suggested change
Rooms may have restricted posting permissions for Admins only. In other cases, the conversation may be read-only, and youll see a "This conversation is read-only" banner at the bottom of the chat.
Rooms may have restricted posting permissions for Admins only. In other cases, the conversation may be read-only, and you'll see a **This conversation is read-only** banner at the bottom of the chat.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented May 8, 2026

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.69-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.69-18 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Emergency HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants