Fix header border color when items are selected

[Krishna2323]

Explanation of Change

Fixed Issues

$ #89066
PROPOSAL:

Tests

1. Open the app
2. Navigate to the Search (Spend) page and find an expense report with multiple child transactions
3. Expand the report to see child transaction rows
4. Select all child transactions using the checkboxes
5. Verify the border between the column sub-header row ("Receipt Type, Date, Status...") and the first child transaction changes color and remains visible (does not blend into the selected background)
6. Deselect all transactions
7. Verify the border returns to its normal color
8. Navigate to the Report details page (click into a report)
9. Verify the border below the table header row (checkbox + column headers) is visible
10. Select all transactions using the "Select all" checkbox
11. Verify the header border changes color and remains visible against the selected background
12. Deselect all transactions
13. Verify the border returns to its normal color
14. Repeat steps 2-13 in dark mode to confirm the border is visible in both themes

• Verify that no errors appear in the JS console

Offline tests

• Same as Tests

QA Steps

• Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android_hybrid.mp4

Android: mWeb Chrome

android_mWeb.mp4

iOS: Native

ios_hybrid.mp4

iOS: mWeb Safari

ios_mWeb.mp4

MacOS: Chrome / Safari

web_chrome.mp4

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...archList/ListItem/TransactionGroupListExpanded.tsx	62.76% <100.00%> (+0.40%)	⬆️
src/components/TransactionItemRow/index.tsx	83.04% <ø> (ø)
src/styles/utils/index.ts	48.23% <100.00%> (+0.13%)	⬆️
...stReportView/MoneyRequestReportTransactionItem.tsx	0.00% <0.00%> (ø)
...stReportView/MoneyRequestReportTransactionList.tsx	0.33% <0.00%> (ø)
...arch/SearchList/ListItem/ExpenseReportListItem.tsx	0.00% <0.00%> (ø)
...h/SearchList/ListItem/TransactionGroupListItem.tsx	73.75% <66.66%> (+1.22%)	⬆️
...Search/SearchList/ListItem/TransactionListItem.tsx	0.00% <0.00%> (ø)
... and 23 files with indirect coverage changes

[melvin-bot]

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@JS00001 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

❌ CONSISTENCY-3 (docs)

The inline style {...styles.borderBottom, borderColor: item.isSelected ? theme.buttonHoveredBG : theme.border} is duplicated across multiple list item components (ExpenseReportListItem, TransactionListItem, TransactionGroupListItem, TransactionGroupListExpanded, TransactionItemRow, MoneyRequestReportTransactionList). The same borderColor conditional logic already exists in getSearchTableRowPressableStyle in src/styles/utils/index.ts.

Extract a shared style utility (e.g., getSelectedBorderColor(isSelected) or getBottomBorderStyle(isSelected)) in StyleUtils and reuse it across all these components instead of duplicating the conditional border color logic inline.

---

Reviewed at: b4afeb9 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

[Krishna2323]

shared style utility added.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b4afeb94b2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[github-actions]

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

[shawnborton]

Feels good to me:

[situchan]

Author checklist failing

bump ^

[MelvinBot]

PR Review

Overall: This PR looks solid. The approach of extracting getSelectedBorderBottomStyle into a shared utility is clean and consistently applied across all affected components. All substantive CI checks pass.

What the PR does

When table rows are selected, borders between rows now change color from theme.border to theme.buttonHoveredBG so they remain visible against the selected background. This is achieved via a new getSelectedBorderBottomStyle utility that replaces raw styles.borderBottom usage across 8 files.

Observations

1. getSearchTableRowPressableStyle borderRadius change (index.ts:1837-1840): The switch from borderRadius: 0 to four individual corner properties is functionally equivalent here — the searchTableBottomRadius spread on the next line sets individual bottom corners, which override individual properties the same way they would override the shorthand. This change is fine but worth calling out as cosmetic/defensive rather than a functional fix.

2. useNetwork addition in MoneyRequestReportTransactionList (MoneyRequestReportTransactionList.tsx:168): The isOffline flag changes the lastTransactionID logic — when offline, pending-delete transactions are no longer filtered out. This is a behavioral change beyond just border styling. It seems intentional (offline can't confirm deletes), but the PR description doesn't mention it. Worth confirming this is expected.

3. Falsy borderBottomStyle in TransactionGroupListItem (line 555): isItemSelected && {borderColor: theme.buttonHoveredBG} evaluates to false when unselected. This is safe — React Native ignores falsy values in style arrays — and matches existing patterns in the codebase.

CI Status

The only failing check is PR Author Checklist, which is a non-blocking checklist reminder (reviewer situchan already flagged this in comments).

[JS00001]

@Krishna2323 can you fix those two issues? Then we can merge this

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[MelvinBot]

Possible Regressions

I investigated four areas of this PR for potential regressions. Two are clean, two deserve attention.

1. lastTransactionID offline behavior change — Low risk, worth confirming

The useNetwork/isOffline addition changes which transaction is considered "last" when offline. When offline, pending-delete transactions are no longer skipped, so a pending-delete transaction at the end of the list becomes isLastItem=true and loses its bottom border on narrow layout.

This is arguably correct (the delete hasn't been confirmed offline, so the item is still visually present), but it's a behavioral change not mentioned in the PR description. The isLastItem prop only affects the bottom border — no logic, navigation, or data behavior depends on it.

2. Last item in narrow layout now gets rounded bottom corners — Intentional but visible change

In TransactionListItem.tsx:265-268, the old code always applied styles.noBorderRadius in narrow layout. The new code applies styles.searchTableBottomRadius for the last item instead, giving it rounded bottom corners. This is likely intentional (matches how the outer pressable wrapper already handles first/last item rounding), but reviewers should confirm this is the desired visual on mobile.

3. Border element migration (narrow layout) — No regression

The styles.borderBottom was removed from inner wrapper Views and replaced with getSelectedBorderBottomStyle on the outer pressable style. Both the inner wrapper and outer pressable are full-width block containers (OpacityView parent → GenericPressable child in PressableWithFeedback), so the border renders at the same visual position. No missing or doubled borders.

4. borderRadius: 0 → individual corner properties — No regression

The change in getSearchTableRowPressableStyle from shorthand borderRadius: 0 to four individual corner properties is functionally equivalent — React Native resolves individual corner properties with higher specificity than the shorthand. The change makes the override chain more explicit. Note: the sibling function getSearchTableGroupRowBorderStyle still uses the shorthand borderRadius: 0 — consider updating it for consistency.

[JS00001]

conflicts too @Krishna2323

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[Krishna2323]

Conflicts resolved and checklist completed. Failing test isn't related.

[github-actions]

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89353.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f6e7b99-34a8d39-542fc1eaec6496aba20f8c36fa6d87872738087b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f6e7b99-34a8d39-ed261a1f48bd2e4ba6467e46b1d3de5f22f14b98/index.html

Web 🕸️
https://89353.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.66-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

[MelvinBot]

No help site changes required.

This PR (#89353) is a UI-only fix that corrects the border color between table rows when transactions are selected on the Search page and Report details page. The changes are purely visual/styling (adding a getSelectedBorderBottomStyle utility and applying it across list item components). No features, workflows, settings, or terminology documented in the help site are affected.

[lanitochka17]

Deploy Blocker ##89527 was identified to be related to this PR.