[Payment due @jayeshmangwani] Improve bank account workspace connection error messages#89483
[Payment due @jayeshmangwani] Improve bank account workspace connection error messages#89483MelvinBot wants to merge 4 commits into
Conversation
…tionable The error message shown when a user tries to set up a non-USD bank account without connecting it to a workspace was vague. Updated it across all languages to clearly instruct users to go to Workspaces, select their workspace, and navigate to Workflows > Payments > Add bank account. Co-authored-by: greg-schroeder <greg-schroeder@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: greg-schroeder <greg-schroeder@users.noreply.github.com>
|
Fixed the failing Prettier check: ran prettier on |
|
@MelvinBot Can we say "linked" instead of "added"? The form does not have to be completed on a workspace. The user just has to link the bank account to a workspace. They can then finish the form in either place. |
Updated wording across all 10 languages to say the bank account must be "linked" to a workspace rather than "added" through one, since the user just needs to link the account - the form can be completed in either place. Co-authored-by: greg-schroeder <greg-schroeder@users.noreply.github.com>
|
Updated — changed "added" to "linked" (and equivalents) across all 10 language files. The error message now reads: "This bank account must be linked to a workspace." |
This comment has been minimized.
This comment has been minimized.
melvin-bot
Bot
requested review from
heyjennahay and
jayeshmangwani
and removed request for
a team
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
bump on this one @jayeshmangwani <3 |
|
Sure, checking now |
|
@MelvinBot, can we use a common string for both can we fix the error message shown in |
|
Both observations are correct: 1. Duplicate 2. Missing padding on error message — I can only make code changes when directed by the PR author, an assignee, or an existing co-author. To have me implement this, the PR assignee or author should reply with a request tagging me. |
|
@MelvinBot, could you check all the boxes in the PR checklist and add the tests below to the Tests and QA section? Non Australia (AUD) case
Australia (AUD) case
|
|
I can't do either of these:
|
|
@greg-schroeder can you please ask Melvin to make these changes #89483 (comment) and #89483 (comment)? Since you’re the co-author of the PR, it doesn’t seem to apply changes from my comments 😄 |
|
Asked on Slack https://expensify.slack.com/archives/C01GTK53T8Q/p1778599947292459 for confirmation of the spanish translation. |
|
@greg-schroeder Whenever you get a chance, please take a look at comment #89483 (comment) for instructions for Melvin to make a few changes. |
|
Hi @jayeshmangwani ah sorry about that! Yes let me take care of it |
|
@greg-schroeder, whenever you get a chance, could you please ask Melvin to make the above two changes #89483 (comment)? |
|
@MelvinBot implement the changes defined here #89483 (comment) |
|
Done! I've updated the PR body:
|
|
@MelvinBot please do this change too #89483 (comment) |
|
Thanks for the review feedback! Here's what needs to change: 1. Common string for 2. Missing padding in SignerInfo: The error container in I can only make code changes when directed by the PR author, an assignee, or an existing co-author. |
|
@greg-schroeder, sorry, but you also need to ask for this change #89483 (comment) as well. Melvin addressed only one comment. |
|
@MelvinBot Please implement this change as well: #89483 (comment) |
…Info - Both countryStep and signerInfoStep used identical connectToWorkspace error strings. Removed the duplicate from signerInfoStep across all 10 language files and updated SignerInfo to reference the shared countryStep.error.connectToWorkspace key. - Added ph5 padding to the error message View in SignerInfo/index.tsx to match the CountryFullStep layout. Co-authored-by: greg-schroeder <greg-schroeder@users.noreply.github.com>
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Implemented both changes from the review comment:
|
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 2d7ac4d5..82d443ca 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -3921,7 +3921,7 @@ ${amount} für ${merchant} – ${date}`,
selectCountry: 'Land auswählen',
error: {
connectToWorkspace: (workspaceRoute: string) =>
- `Dieses Bankkonto muss mit einem Arbeitsbereich verknüpft werden. Gehen Sie zu <a href="${workspaceRoute}">Arbeitsbereiche</a>, wählen Sie Ihren Arbeitsbereich und navigieren Sie dann zu Workflows > Zahlungen > Bankkonto hinzufügen.`,
+ `Dieses Bankkonto muss mit einem Workspace verknüpft sein. Gehe zu <a href="${workspaceRoute}">Workspaces</a>, wähle deinen Workspace aus und navigiere dann zu Workflows > Payments > Bankkonto hinzufügen.`,
},
},
bankInfoStep: {
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 6743169f..2f56e257 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -3909,7 +3909,7 @@ ${amount} per ${merchant} - ${date}`,
selectCountry: 'Seleziona paese',
error: {
connectToWorkspace: (workspaceRoute: string) =>
- `Questo conto bancario deve essere collegato a uno spazio di lavoro. Vai su <a href="${workspaceRoute}">Spazi di lavoro</a>, seleziona il tuo spazio di lavoro, quindi vai su Flussi di lavoro > Pagamenti > Aggiungi conto bancario.`,
+ `Questo conto bancario deve essere collegato a uno spazio di lavoro. Vai a <a href="${workspaceRoute}">Spazi di lavoro</a>, seleziona il tuo spazio di lavoro, quindi vai a Flussi di lavoro > Pagamenti > Aggiungi conto bancario.`,
},
},
bankInfoStep: {
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index acc5be0b..87b69d7e 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -3879,7 +3879,7 @@ ${integrationName === CONST.ONBOARDING_ACCOUNTING_MAPPING.other ? 'あなたの'
selectCountry: '国を選択',
error: {
connectToWorkspace: (workspaceRoute: string) =>
- `この銀行口座はワークスペースにリンクする必要があります。<a href="${workspaceRoute}">ワークスペース</a>に移動し、ワークスペースを選択して、ワークフロー > 支払い > 銀行口座を追加 に進んでください。`,
+ `この銀行口座はワークスペースにリンクする必要があります。<a href="${workspaceRoute}">ワークスペース</a>に移動し、ワークスペースを選択してから、「ワークフロー」＞「支払い」＞「銀行口座を追加」と進んでください。`,
},
},
bankInfoStep: {
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 0af59095..5f07061d 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -3906,7 +3906,7 @@ ${amount} voor ${merchant} - ${date}`,
selectCountry: 'Selecteer land',
error: {
connectToWorkspace: (workspaceRoute: string) =>
- `Deze bankrekening moet worden gekoppeld aan een werkruimte. Ga naar <a href="${workspaceRoute}">Werkruimtes</a>, selecteer je werkruimte en navigeer vervolgens naar Workflows > Betalingen > Bankrekening toevoegen.`,
+ `Deze bankrekening moet gekoppeld zijn aan een workspace. Ga naar <a href="${workspaceRoute}">Workspaces</a>, selecteer je workspace en ga vervolgens naar Workflows > Payments > Bankrekening toevoegen.`,
},
},
bankInfoStep: {
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index e0c1ae27..6478d3d1 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -3898,7 +3898,7 @@ ${amount} dla ${merchant} - ${date}`,
selectCountry: 'Wybierz kraj',
error: {
connectToWorkspace: (workspaceRoute: string) =>
- `To konto bankowe musi zostać powiązane z przestrzenią roboczą. Przejdź do <a href="${workspaceRoute}">Przestrzeni roboczych</a>, wybierz swoją przestrzeń roboczą, a następnie przejdź do Przepływy pracy > Płatności > Dodaj konto bankowe.`,
+ `To konto bankowe musi być powiązane z przestrzenią roboczą. Przejdź do <a href="${workspaceRoute}">Przestrzenie robocze</a>, wybierz swoją przestrzeń roboczą, a następnie przejdź do Przepływy pracy > Płatności > Dodaj konto bankowe.`,
},
},
bankInfoStep: {
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 3c56d8d7..92fa916f 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -3898,7 +3898,7 @@ ${amount} para ${merchant} - ${date}`,
selectCountry: 'Selecione o país',
error: {
connectToWorkspace: (workspaceRoute: string) =>
- `Esta conta bancária deve ser vinculada a um espaço de trabalho. Vá para <a href="${workspaceRoute}">Espaços de trabalho</a>, selecione seu espaço de trabalho e navegue até Fluxos de trabalho > Pagamentos > Adicionar conta bancária.`,
+ `Esta conta bancária precisa estar vinculada a um espaço de trabalho. Vá para <a href="${workspaceRoute}">Espaços de trabalho</a>, selecione seu espaço de trabalho e, em seguida, acesse Fluxos de trabalho > Pagamentos > Adicionar conta bancária.`,
},
},
bankInfoStep: {
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 6c0c2407..9c943f4a 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -3819,7 +3819,7 @@ ${amount}，商户：${merchant} - 日期：${date}`,
selectCountry: '选择国家',
error: {
connectToWorkspace: (workspaceRoute: string) =>
- `此银行账户必须关联到工作区。请前往<a href="${workspaceRoute}">工作区</a>，选择您的工作区，然后导航至工作流 > 付款 > 添加银行账户。`,
+ `此银行账户必须关联到一个工作区。请前往<a href="${workspaceRoute}">工作区</a>，选择您的工作区，然后依次进入“工作流”>“付款”>“添加银行账户”。`,
},
},
bankInfoStep: {
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
The ESLint check was cancelled (not a lint error) — GitHub reports cancelled jobs as failures. ESLint passed successfully on all previous runs of this branch. This appears to be a transient CI infrastructure issue. Fix: Re-run the failed ESLint workflow from the Actions tab. I don't have permission to trigger re-runs. |
|
The failing checks are unrelated to this PR's changes. ESLint check: Was perf-tests: Failed due to a render count deviation in Recommendation: Re-run the failing checks. No code changes needed. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
|
melvin-bot
Bot
changed the title
|
🎯 @jayeshmangwani, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
All three failing checks are unrelated to this PR's changes (language files +
No code fix needed — these should resolve on re-run. |
|
@greg-schroeder , I'm not sure what went wrong, but I approved the PR and no internal engineer was assigned to review and merge it. |
4 participants
Explanation of Change
The error message shown when a user tries to set up a non-USD bank account without connecting it to a workspace was vague — it said "Please connect this bank account to a workspace" without explaining how. Updated the message across all 10 languages to clearly instruct users: go to Workspaces, select your workspace, then navigate to Workflows > Payments > Add bank account.
This affects two places where the message appears:
countryStep.error.connectToWorkspace)signerInfoStep.error.connectToWorkspace)Fixed Issues
$ https://github.com/Expensify/Expensify/issues/629845
Tests
Non Australia (AUD) case
This bank account must be linked to a workspace. Go to Workspaces, select your workspace, then navigate to Workflows > Payments > Add bank account.Australia (AUD) case
This bank account must be linked to a workspace. Go to Workspaces, select your workspace, then navigate to Workflows > Payments > Add bank account.Offline tests
N/A — this is a copy-only change to error message strings.
QA Steps
Non Australia (AUD) case
This bank account must be linked to a workspace. Go to Workspaces, select your workspace, then navigate to Workflows > Payments > Add bank account.Australia (AUD) case
This bank account must be linked to a workspace. Go to Workspaces, select your workspace, then navigate to Workflows > Payments > Add bank account.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari