Skip to content

refactor: PureReportActionItem, move composer focus and delete-draft logic#89485

Merged
cristipaval merged 3 commits into
Expensify:mainfrom
callstack-internal:perf-purereportactionitem-edit-mode
May 11, 2026
Merged

refactor: PureReportActionItem, move composer focus and delete-draft logic#89485
cristipaval merged 3 commits into
Expensify:mainfrom
callstack-internal:perf-purereportactionitem-edit-mode

Conversation

@LukasMod
Copy link
Copy Markdown
Contributor

@LukasMod LukasMod commented May 4, 2026

Explanation of Change

Move two edit-mode-only useEffects out of PureReportActionItem and into ReportActionItemMessageEdit (the leaf that only mounts when a draft is open):

  1. Composer focus on entering edit mode. The wrapper's useEffect used usePrevious(draftMessage) to detect the no-draft to draft transition. The leaf only mounts when draftMessage !== undefined, so a plain mount-only
    effect inside it is equivalent. composerTextInputRef, the focus effect, the prop chain through ChatMessageContent, and the leaf's externally-passed ref prop all go away.
  2. Cleanup of the draft when the action becomes deleted. The wrapper's useEffect ran deleteReportActionDraft when draftMessage !== undefined && isDeletedAction(action). Moved into the leaf with the same
    isDeletedAction predicate; the draftMessage guard becomes structural. deleteReportActionDraft no longer needs to be drilled as a prop or injected by ReportActionItem.tsx; the leaf imports it directly.

For the dominant non-edit row this removes one useRef, two useEffects, one usePrevious call, and one prop chain. No behavior change.

Fixed Issues

$ #89780
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Test 1: Composer focuses when entering edit mode

  1. Open any 1:1 chat or workspace chat where you have sent at least one of your own text messages.
  2. Right-click (web) or long-press (mobile) one of your messages and pick "Edit comment".
  3. Verify the inline composer appears with the message text loaded.
  4. Verify the composer is focused without you tapping it. Press a key on your keyboard.
  5. Verify the typed character is appended to the existing draft (you do not have to click into the composer first).

Test 2: Edit save still works end-to-end

  1. Trigger "Edit comment" on one of your messages.
  2. Append text to the existing draft and press Enter (web) or tap the checkmark.
  3. Verify the message is saved and the composer disappears.
  4. Send a new message in the same chat to confirm the row above re-renders normally.

Test 3: Draft cleanup when the action is deleted while editing

Two windows or two browser sessions for the same account work, or two cooperating users in the same workspace chat.

  1. In window A, send a message in a chat. Trigger "Edit comment" and append a few characters to the draft. Do NOT save.
  2. In window B (or as another user with delete rights on this message), delete the same message.
  3. Switch back to window A. Verify the edit composer disappears and the message row goes away.
  4. Reload the chat in window A. Verify the draft does not reappear (no stale "Edit comment" pending).
  5. Trigger "Edit comment" on a different message and verify edit still works normally.

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

Same as tests

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android.native.mov
Android: mWeb Chrome
android.web.mov
iOS: Native
ios.native.mov
iOS: mWeb Safari
ios.web.mov
MacOS: Chrome / Safari
web.mov

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/pages/inbox/report/PureReportActionItem.tsx 80.22% <ø> (-0.05%) ⬇️
src/pages/inbox/report/ReportActionItem.tsx 100.00% <ø> (ø)
...inbox/report/actionContents/ChatMessageContent.tsx 91.66% <ø> (ø)
...pages/inbox/report/ReportActionItemMessageEdit.tsx 57.08% <83.33%> (+0.69%) ⬆️
... and 11 files with indirect coverage changes

@LukasMod LukasMod force-pushed the perf-purereportactionitem-edit-mode branch from 864164d to 672e129 Compare May 5, 2026 06:36
@LukasMod
Copy link
Copy Markdown
Contributor Author

LukasMod commented May 5, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 6, 2026

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team May 6, 2026 16:33
@LukasMod LukasMod force-pushed the perf-purereportactionitem-edit-mode branch from 672e129 to 2c14e0c Compare May 7, 2026 06:17
@shubham1206agra
Copy link
Copy Markdown
Contributor

@LukasMod Please fix conflicts here

@LukasMod
Copy link
Copy Markdown
Contributor Author

LukasMod commented May 8, 2026

@shubham1206agra conflicts resolved 👍

@shubham1206agra
Copy link
Copy Markdown
Contributor

Screen.Recording.2026-05-08.at.9.32.40.PM.mov

@LukasMod There's a weird bug on iOS. Can you check if you can repro this at all?

@LukasMod
Copy link
Copy Markdown
Contributor Author

LukasMod commented May 8, 2026

@shubham1206agra Do you mean edit composer flickering? I have similar on main branch (simulator, video attached) and in prod app on real device (but device is faster so it feels better). Also I guess it is much better when use device keyboard in simulator. If you mean this white screen at the end - can't repro right now

main branch:
https://github.com/user-attachments/assets/c2fd081c-be02-4395-aacc-d13fa41660ca

this branch:
https://github.com/user-attachments/assets/a50fc2dc-be21-4563-b3e4-9be5beb1089e

@shubham1206agra
Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • xIf a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-05-08.at.9.55.14.PM.mov
Android: mWeb Chrome
Screen.Recording.2026-05-08.at.9.21.10.PM.mov
iOS: HybridApp
Screen.Recording.2026-05-08.at.9.34.48.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-05-08.at.9.06.47.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-05-08.at.8.59.50.PM.mov

@melvin-bot melvin-bot Bot requested a review from cristipaval May 10, 2026 15:41
@cristipaval cristipaval merged commit 9365dd7 into Expensify:main May 11, 2026
38 checks passed
@OSBotify
Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Copy Markdown
Contributor

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.70-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.72-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot
Copy link
Copy Markdown
Contributor

No help site changes are required for this PR.

This is a pure internal refactoring that moves two edit-mode useEffect hooks from PureReportActionItem into ReportActionItemMessageEdit. There are no user-facing behavior changes, no new features, and no terminology or UI updates that would affect documentation.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.72-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants