Fix amount column misalignment on Report details page by passing shouldRemoveTotalColumnFlex to TOTAL column#89515
Closed
Krishna2323 wants to merge 2 commits intoExpensify:mainfrom
Closed
Conversation
…ldRemoveTotalColumnFlex to TOTAL column Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…izontal scroll mode Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Contributor
|
cc @JS00001 |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
JS00001
approved these changes
May 4, 2026
Contributor
|
lint is failing |
joekaufmanexpensify
approved these changes
May 4, 2026
Contributor
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
54 tasks
Contributor
|
Can this PR be closed in favor of #89575? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Two fixes for the Report details page table layout:
Amount column misalignment — The
TOTALcolumn case inTransactionItemRowwas missingshouldRemoveTotalColumnFlex, so data rows usedflex: 1(stretching) while the header used a fixed width. Adding the missing prop makes both match.Narrow items under wide header — On medium-width screens with horizontal scrolling, the header showed column titles (wide layout) but items rendered in card/narrow style. This happened because items always forced narrow layout when
isMediumScreenWidthwas true, ignoring that horizontal scrolling provides enough room. Now items checkshouldScrollHorizontallyand stay in wide layout when scrolling is active.Fixed Issues
$ #86102
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Monosnap.screencast.2026-05-04.20-40-53.mp4