Skip to content

Move pre-selected list items to top of list throughout the app#89584

Merged
robertjchen merged 16 commits into
Expensify:mainfrom
marufsharifi:fix/preselected-items-top-of-list
May 19, 2026
Merged

Move pre-selected list items to top of list throughout the app#89584
robertjchen merged 16 commits into
Expensify:mainfrom
marufsharifi:fix/preselected-items-top-of-list

Conversation

@marufsharifi
Copy link
Copy Markdown
Contributor

@marufsharifi marufsharifi commented May 5, 2026

Explanation of Change

Fixed Issues

$ #69184
PROPOSAL: #69184 (Comment)

Tests

Note: Below is just an example of one place this issue occurs. There are others, like the country list when adding a personal bank account to the Wallet. This PR fixes the bug on all relevant lists in the app at once.

  1. Go to Workspaces
  2. Go to Company cards
  3. Tap Add cards (opens country list)
  4. Verify that:
    • The selected item is at the very top
    • While selecting an item, it does not scroll
    • The selected item stays highlighted after clearing the search input
  • Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Record 1:

Screen.Recording.2026-03-30.at.7.24.01.PM.mov

Record 2:

Screen.Recording.2026-03-30.at.7.30.26.PM.mov

Record 3:

Screen.Recording.2026-03-30.at.7.24.55.PM.mov

Record 4:

Screen.Recording.2026-03-30.at.7.25.23.PM.mov

Record 5:

Screen.Recording.2026-03-30.at.7.26.39.PM.mov

Record 6:

Screen.Recording.2026-03-30.at.7.24.19.PM.mov

Record 8:

Screen.Recording.2026-03-30.at.7.27.10.PM.mov

Record 9:

Screen.Recording.2026-03-30.at.7.23.41.PM.mov

Record 10:

Screen.Recording.2026-04-01.at.3.13.33.PM.mov

Record 11:

Screen.Recording.2026-04-01.at.5.02.14.PM.mov

Record 12:

Screen.Recording.2026-04-01.at.5.03.25.PM.mov

Record 13:

Screen.Recording.2026-04-01.at.5.44.40.PM.mov

Record 14:

Screen.Recording.2026-04-01.at.5.45.11.PM.mov

Record 15:

Screen.Recording.2026-04-05.at.2.08.14.PM.mov

Record 16:

Screen.Recording.2026-04-05.at.2.13.16.PM.mov

Record 17:

Screen.Recording.2026-04-05.at.2.13.44.PM.mov

Record 18:

Screen.Recording.2026-04-05.at.2.14.28.PM.mov

Record 19:

Screen.Recording.2026-04-05.at.2.15.09.PM.mov

Record 20:

Screen.Recording.2026-04-05.at.2.17.19.PM.mov

Record 21:

Screen.Recording.2026-04-05.at.2.18.22.PM.mov

Record 22:

Screen.Recording.2026-04-05.at.2.22.26.PM.mov
Android: mWeb Chrome

Record 1:

Screen.Recording.2026-03-30.at.5.01.00.PM.mov

Record 2:

Screen.Recording.2026-03-30.at.5.03.08.PM.mov

Record 3:

Screen.Recording.2026-03-30.at.5.03.39.PM.mov

Record 4:

Screen.Recording.2026-03-30.at.5.13.30.PM.mov

Record 5:

Screen.Recording.2026-03-30.at.5.50.42.PM.mov

Record 6:

Screen.Recording.2026-03-30.at.4.55.18.PM.mov

Record 7:

Screen.Recording.2026-03-30.at.5.46.11.PM.mov

Record 8:

Screen.Recording.2026-03-30.at.4.54.08.PM.mov

Record 9:

Screen.Recording.2026-04-01.at.3.16.46.PM.mov

Record 10:

Screen.Recording.2026-04-01.at.3.17.57.PM.mov

Record 11:

Screen.Recording.2026-04-01.at.4.55.08.PM.mov

Record 12:

Screen.Recording.2026-04-01.at.4.57.46.PM.mov

Record 13:

Screen.Recording.2026-04-01.at.4.55.46.PM.mov

Record 14:

Screen.Recording.2026-04-01.at.4.58.45.PM.mov

Record 15:

Screen.Recording.2026-04-05.at.2.42.49.PM.mov

Record 16:

Screen.Recording.2026-04-05.at.3.02.24.PM.mov

Record 17:

Screen.Recording.2026-04-05.at.3.04.38.PM.mov

Record 18:

Screen.Recording.2026-04-05.at.3.05.12.PM.mov

Record 19:

Screen.Recording.2026-04-05.at.3.05.34.PM.mov

Record 20:

Screen.Recording.2026-04-05.at.3.06.56.PM.mov

Record 21:

Screen.Recording.2026-04-05.at.3.10.56.PM.mov

Record 22:

Screen.Recording.2026-04-05.at.3.11.45.PM.mov

Record 23:

Screen.Recording.2026-04-05.at.3.12.25.PM.mov
iOS: Native

Record 1:

Screen.Recording.2026-03-30.at.6.18.08.PM.mov

Record 2:

Screen.Recording.2026-03-30.at.6.18.31.PM.mov

Record 3:

Screen.Recording.2026-03-30.at.6.19.18.PM.mov

Record 4:

Screen.Recording.2026-03-30.at.6.20.11.PM.mov

Record 5:

Screen.Recording.2026-03-30.at.6.16.51.PM.mov

Record 6:

Screen.Recording.2026-03-30.at.6.20.53.PM.mov

Record 7:

Screen.Recording.2026-03-30.at.6.16.07.PM.mov

Record 8:

Screen.Recording.2026-04-01.at.11.33.09.AM.mov

Record 9:

Screen.Recording.2026-04-01.at.11.34.11.AM.mov

Record 10:

Screen.Recording.2026-04-01.at.11.35.50.AM.mov

Record 11:

Screen.Recording.2026-04-01.at.3.49.36.PM.mov

Record 12:

Screen.Recording.2026-04-01.at.3.53.02.PM.mov

Record 13:

Screen.Recording.2026-04-01.at.4.15.54.PM.mov

Record 14:

Screen.Recording.2026-04-01.at.4.16.47.PM.mov

Record 15:

Screen.Recording.2026-04-05.at.10.18.53.AM.mov

Record 16:

Screen.Recording.2026-04-05.at.11.00.26.AM.mov

Record 17:

Screen.Recording.2026-04-05.at.11.02.02.AM.mov

Record 18:

Screen.Recording.2026-04-05.at.11.02.53.AM.mov

Record 19:

Screen.Recording.2026-04-05.at.11.03.59.AM.mov

Record 20:

Screen.Recording.2026-04-05.at.11.05.48.AM.mov

Record 21:

Screen.Recording.2026-04-05.at.11.16.18.AM.mov

Record 22:

Screen.Recording.2026-04-05.at.12.22.30.PM.mov
iOS: mWeb Safari

Record 1:

Screen.Recording.2026-03-30.at.6.36.12.PM.mov

Record 2:

Screen.Recording.2026-03-30.at.6.36.51.PM.mov

Record 3:

Screen.Recording.2026-03-30.at.6.37.32.PM.mov

Record 4:

Screen.Recording.2026-03-30.at.6.36.33.PM.mov

Record 5:

Screen.Recording.2026-03-30.at.6.37.56.PM.mov

Record 6:

Screen.Recording.2026-03-30.at.6.38.40.PM.mov

Record 7:

Screen.Recording.2026-03-30.at.7.09.25.PM.mov

Record 8:

Screen.Recording.2026-03-30.at.7.14.01.PM.mov

Record 9:

Screen.Recording.2026-04-01.at.11.45.24.AM.mov

Record 10:

Screen.Recording.2026-04-01.at.11.46.41.AM.mov

Record 11:

Screen.Recording.2026-04-01.at.4.24.31.PM.mov

Record 12:

Screen.Recording.2026-04-01.at.4.25.32.PM.mov

Record 13:

Screen.Recording.2026-04-01.at.4.43.59.PM.mov

Record 14:

Screen.Recording.2026-04-05.at.11.53.14.AM.mov

Record 15:

Screen.Recording.2026-04-01.at.4.44.26.PM.mov

Record 16:

Screen.Recording.2026-04-05.at.11.55.14.AM.mov

Record 17:

Screen.Recording.2026-04-05.at.12.07.44.PM.mov

Record 18:

Screen.Recording.2026-04-05.at.12.08.31.PM.mov

Record 19:

Screen.Recording.2026-04-05.at.12.09.00.PM.mov

Record 20:

Screen.Recording.2026-04-05.at.12.09.16.PM.mov

Record 21:

Screen.Recording.2026-04-05.at.12.11.14.PM.mov

Record 22:

Screen.Recording.2026-04-05.at.12.13.37.PM.mov

Record 23:

Screen.Recording.2026-04-05.at.12.14.43.PM.mov
MacOS: Chrome / Safari

Record 1.

workspace.company.cards.add.card.feed.country.step.mov

Record 2.

settings.wallet.add.-.bank.account.account.detaisl.currencly.mov

Record 3.

Settings.Wallet.add.bank.account.bank.information.bank.region.mov

Record 4.

Settings.Wallet.add.bank.account.account.holder.detaisl.mov

Record 5.

create.expense.per.diem.subrate.mov

Record 6.

start.chat.roo.workspace.mov

Record 7.

start.chat.room.who.can.post.mov

Record 8.

only.available.by.route.copy.the.route.from.expensify.cards.mov

Record 9.

stat.chat.room.visibility.mov

Record 10.

expensify.card.issue.card.limit.type.mov

Record 11.

Expensify.card.card.item.Limit.Type.mov

Record 12.

create.expense.per.diem.add.subrate.then.update.that.subrate.mov

Record 13.

settings.profile.address.country.mov

Record 14.

Settings.profile.address.state.mov

Record 15.

Settings.Wallet.Add.bank.account.country.selection.mov

Record 16.

Screencast.From.2026-04-04.08-47-52.mp4

Record 17.

Screencast.From.2026-04-04.09-03-18.mp4

Record 18.

Screencast.From.2026-04-04.09-05-28.mp4

Record 19.

Screencast.From.2026-04-04.09-06-56.mp4

Record 20.

Screencast.From.2026-04-04.09-09-18.mp4

Record 21.

Screencast.From.2026-04-04.09-15-24.mp4

Record 22.

Screencast.From.2026-04-04.10-10-40.mp4

Record 23.

Screencast.From.2026-04-04.10-45-51.mp4

Record 24:

Screencast.From.2026-04-05.07-53-13.mp4

@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 5, 2026

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@marufsharifi marufsharifi marked this pull request as ready for review May 5, 2026 15:33
@marufsharifi marufsharifi requested review from a team as code owners May 5, 2026 15:33
@melvin-bot melvin-bot Bot requested review from flaviadefaria and linhvovan29546 and removed request for a team May 5, 2026 15:33
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 5, 2026

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@marufsharifi
Copy link
Copy Markdown
Contributor Author

marufsharifi commented May 5, 2026

I'm resolving new conflicts

github-actions[bot]
github-actions Bot reviewed May 5, 2026
View reviewed changes
Comment thread src/libs/SelectionListOrderUtils.ts Outdated
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 5, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3265456246

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/hooks/useInitialSelection.ts
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026 •
edited by github-actions Bot
Loading

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 92.30% <ø> (ø)
.../components/CountryPicker/CountrySelectorModal.tsx 100.00% <100.00%> (+100.00%) ⬆️
src/components/PushRowWithModal/PushRowModal.tsx 100.00% <100.00%> (+100.00%) ⬆️
src/components/SelectionList/BaseSelectionList.tsx 66.11% <100.00%> (+0.14%) ⬆️
...ListWithSections/BaseSelectionListWithSections.tsx 83.91% <100.00%> (-0.12%) ⬇️
src/components/StatePicker/StateSelectorModal.tsx 100.00% <100.00%> (+100.00%) ⬆️
src/components/ValuePicker/ValueSelectionList.tsx 100.00% <100.00%> (+100.00%) ⬆️
src/components/ValuePicker/ValueSelectorModal.tsx 100.00% <ø> (+100.00%) ⬆️
src/libs/SelectionListOrderUtils.ts 100.00% <100.00%> (ø)
...le/PersonalDetails/DynamicCountrySelectionPage.tsx 96.00% <100.00%> (+96.00%) ⬆️
... and 5 more
... and 18 files with indirect coverage changes

@marufsharifi
refactor: consolidate initial selection list ordering helper
755e980 
Co-authored-by: Copilot <copilot@github.com>
flaviadefaria
flaviadefaria previously approved these changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@flaviadefaria flaviadefaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a product standpoint, the fix looks good to me.

@linhvovan29546
Copy link
Copy Markdown
Contributor

linhvovan29546 commented May 6, 2026

@marufsharifi Why do we need this change?755e980 This introduces an unnecessary getKey.

linhvovan29546
linhvovan29546 reviewed May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@linhvovan29546 linhvovan29546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked the previous comment here?

@marufsharifi
Copy link
Copy Markdown
Contributor Author

marufsharifi commented May 6, 2026

@marufsharifi Why do we need this change?755e980 This introduces an unnecessary getKey.

I added it while addressing the previous feedback about duplicated logic between the key/value helpers, and I missed that it’s unnecessary now. Thanks for pointing that out. I’ll simplify this to a single value-based helper and remove the extra abstraction.

@marufsharifi
Copy link
Copy Markdown
Contributor Author

marufsharifi commented May 6, 2026

Have you checked the previous comment here?

@linhvovan29546 Yes, I checked those previous comments. They should be addressed in this PR.
Could you please take another look and let me know if anything is still missing? thanks

linhvovan29546
linhvovan29546 suggested changes May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@linhvovan29546 linhvovan29546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marufsharifi I noticed several redundant alias variables for initiallyFocusedItemKey. Could you please clean them up? I haven’t listed all of them in suggested change.

Comment thread src/components/CountryPicker/CountrySelectorModal.tsx Outdated
Comment thread src/pages/workspace/companyCards/addNew/SelectCountryStep.tsx Outdated
Comment thread src/components/PushRowWithModal/PushRowModal.tsx Outdated
@marufsharifi
Copy link
Copy Markdown
Contributor Author

marufsharifi commented May 8, 2026

@marufsharifi Could you please apply the change for this page as well?

@linhvovan29546 Thanks for catching that. It's fixed now.

@linhvovan29546
Copy link
Copy Markdown
Contributor

linhvovan29546 commented May 8, 2026

@marufsharifi The test failed

@melvin-bot melvin-bot Bot requested a review from srikarparsi May 8, 2026 11:41
@marufsharifi
Copy link
Copy Markdown
Contributor Author

marufsharifi commented May 11, 2026

@srikarparsi, please feel free to review the code when you get a chance, but please don’t merge the changes yet. I’m still reviewing a few additional edge cases.

Thanks!

@marufsharifi
Copy link
Copy Markdown
Contributor Author

marufsharifi commented May 12, 2026

@srikarparsi, I've finished testing. Please take a look when you get a chance. and merge if no feedback was required. Thanks.

@marufsharifi
Copy link
Copy Markdown
Contributor Author

marufsharifi commented May 14, 2026

@srikarparsi, gentle bump. thanks

@marufsharifi
Copy link
Copy Markdown
Contributor Author

marufsharifi commented May 19, 2026

@robertjchen, could you please take a look at this PR; i think are pending your review. thanks.

@robertjchen robertjchen requested review from robertjchen and removed request for srikarparsi May 19, 2026 05:47
robertjchen
robertjchen approved these changes May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@robertjchen robertjchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robertjchen robertjchen merged commit 4e17a1b into Expensify:main May 19, 2026
34 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

🚧 @robertjchen has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89584.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4e17a1b-e48a63d-ade0d5c6a0ac9dd245d83d11bfc52a4652bd34c5/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4e17a1b-e48a63d-2c4ac848ed4e24355c7cb26bcf21781b2d160171/index.html
Android iOS
Web 🕸️
https://89584.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request May 19, 2026
Closed
75 tasks
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented May 19, 2026

🚀 Deployed to staging by https://github.com/robertjchen in version: 9.3.76-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@MelvinBot
Copy link
Copy Markdown
Contributor

MelvinBot commented May 19, 2026

No help site changes are required for this PR.

This is a UI bug fix that reorders pre-selected items to the top of selection lists (country pickers, state pickers, value pickers). It does not introduce new features, rename settings, change workflows, or modify any user-facing terminology that would be documented in help site articles.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented May 19, 2026

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.77-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@melvin-bot melvin-bot Bot mentioned this pull request May 19, 2026
Open
8 tasks
@mkhutornyi
Copy link
Copy Markdown
Contributor

mkhutornyi commented May 20, 2026

This PR caused regression:

List is not scrolled automatically during arrow key navigation on country select page

Steps:

  1. Go to workspaces > any workspace > Company cards
  2. Click Add cards button
  3. Press Up/Down Arrow to select item
bug.mov

@linhvovan29546
Copy link
Copy Markdown
Contributor

linhvovan29546 commented May 20, 2026

Thanks, @mkhutornyi. This looks like a simple fix. @marufsharifi, could you please prioritize fixing this?

@marufsharifi
Copy link
Copy Markdown
Contributor Author

marufsharifi commented May 20, 2026

@marufsharifi, could you please prioritize fixing this?

@linhvovan29546 I will take care of it. thanks.

@marufsharifi marufsharifi mentioned this pull request May 20, 2026
Merged
52 tasks
@aswin-s aswin-s mentioned this pull request May 20, 2026
Closed
7 tasks
@amyevans amyevans mentioned this pull request May 20, 2026
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@robertjchen robertjchen robertjchen approved these changes

@flaviadefaria flaviadefaria flaviadefaria left review comments

+1 more reviewer

@linhvovan29546 linhvovan29546 linhvovan29546 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marufsharifi marufsharifi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@marufsharifi @linhvovan29546 @OSBotify @MelvinBot @mkhutornyi @robertjchen @flaviadefaria