Skip to content

[No QA] Restore commented-out SAML redirect to signin code#89680

Merged
neil-marcellini merged 3 commits intomainfrom
Rory-RestoreRedirectToSignin
May 6, 2026
Merged

[No QA] Restore commented-out SAML redirect to signin code#89680
neil-marcellini merged 3 commits intomainfrom
Rory-RestoreRedirectToSignin

Conversation

@roryabraham
Copy link
Copy Markdown
Contributor

@roryabraham roryabraham commented May 5, 2026 •
edited
Loading

Explanation of Change

Restoring code that was commented out during #fireroom-2026-01-28-user-signout, but never added back. It was not the root cause (see email w/ subject line [Post Mortem] Many Expensifiers were signed out of NewDot, the root cause was in Onyx).

Fixed Issues

(partial) #89613

Tests

Unfortunately this can't be trivially retested manually (need an invalidated SAML login), but fortunately we're just adding back code that was meant to be removed temporarily, but which due to an oversight on my part was never added back. So I think the bar for testing can be lower on this one.

Add an automated test.

  • Verify that no errors appear in the JS console

Offline tests

None.

QA Steps

n/a - we'll follow up in #89613

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@roryabraham roryabraham changed the title [No QA] Restore commented-out code [No QA] Restore commented-out SAML redirect to signin code May 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026 •
edited by github-actions Bot
Loading

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/Reauthentication.ts 71.23% <100.00%> (+2.66%) ⬆️
... and 11 files with indirect coverage changes

roryabraham and others added 2 commits May 5, 2026 16:56
@roryabraham @cursoragent
test: add unit tests for reauthenticate missing-credentials redirect
08eacb1 
Covers the case where reauthenticate() is called with no credentials,
verifying that it calls redirectToSignIn('No credentials available') and
releases the network authenticating state instead of proceeding to call
Authenticate with undefined credentials.

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham @cursoragent
refactor(test): move reauthenticate missing-credentials test into Ses…
fd3aba5 
…sionTest

Replaces the standalone ReauthenticationTest file with a single focused
test in the existing SessionTest suite. Calls reauthenticate() directly
(no API stack needed) — after beforeEach Onyx.clear(), NetworkStore
credentials are null, which is the exact condition the fix guards against.

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham roryabraham marked this pull request as ready for review May 6, 2026 00:18
@roryabraham roryabraham requested review from a team as code owners May 6, 2026 00:18
@melvin-bot melvin-bot Bot requested review from neil-marcellini and trjExpensify and removed request for a team May 6, 2026 00:18
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 6, 2026

@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@roryabraham roryabraham mentioned this pull request May 6, 2026
Merged
54 tasks
@mountiny mountiny mentioned this pull request May 6, 2026
Open
trjExpensify
trjExpensify approved these changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@trjExpensify trjExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds back some temp commented out code.

@neil-marcellini neil-marcellini merged commit e460464 into main May 6, 2026
43 of 45 checks passed
@neil-marcellini neil-marcellini deleted the Rory-RestoreRedirectToSignin branch May 6, 2026 22:14
@neil-marcellini
Copy link
Copy Markdown
Contributor

neil-marcellini commented May 6, 2026

Simple uncommenting, no reviewer checklist or C+ needed.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

🚧 @neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented May 6, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89680.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e460464-104e41d-b950877ac1fa81184dba407414255ee0f88f1d12/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e460464-104e41d-8a4226e4c4ffc1b0abe34e6bd3f1ce9802eab145/index.html
Android iOS
Web 🕸️
https://89680.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request May 6, 2026
Closed
73 tasks
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented May 6, 2026

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.3.68-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot
Copy link
Copy Markdown
Contributor

MelvinBot commented May 6, 2026

No help site changes are required for this PR. The changes are internal only — restoring commented-out reauthentication logic in Reauthentication.ts and adding an automated test. No user-facing features, UI, or workflows are affected.

@trjExpensify trjExpensify mentioned this pull request May 7, 2026
Merged
52 tasks
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented May 8, 2026

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.68-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trjExpensify trjExpensify trjExpensify approved these changes

@neil-marcellini neil-marcellini neil-marcellini approved these changes

Assignees

@roryabraham roryabraham

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@roryabraham @neil-marcellini @OSBotify @MelvinBot @trjExpensify