#2 - Add device management feature by bernhardoj · Pull Request #89704 · Expensify/App

bernhardoj · 2026-05-06T04:26:54Z

Explanation of Change

Fixed Issues

$ #86580
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Note

Known issues:

Security - The logged-in device is not displayed after verifying a new account #89664

Prerequisite: logged in to multiple devices with the same account
Success case:

Go to Account > Security > Device Management
Press Revoke on any device
Verify the device is removed from the list

Failure case:

Turn on "Simulate failing network requests"
Go to Account > Security > Device management
Press Revoke on any device
Verify a dismissible error is shown below the device
Verify an RBR is shown in the Account tab icon, Security menu item, and Device management menu item
Dismiss the error
Verify the error is dismissed and the device isn't removed

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

…vert-87948" This reverts commit 3e1312e, reversing changes made to 94727c1.

melvin-bot · 2026-05-06T04:26:59Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2026-05-06T04:27:00Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-05-06T04:35:38Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/actions/Session/index.ts	`42.85% <0.00%> (-0.10%)`	⬇️
src/libs/actions/User.ts	`37.77% <60.00%> (+0.53%)`	⬆️
...c/pages/settings/Security/DeviceManagementPage.tsx	`0.00% <0.00%> (ø)`
... and 9 files with indirect coverage changes

bernhardoj · 2026-05-06T04:37:55Z

#89648 fixed:

User is not signed out immediately after revoking current session and The logged-in device is not displayed after verifying a new account look related:

When we log in as a new user, there will be 2 fields in the logins onyx data

and only the second one with partnerID 83 will be shown, this is the "Unknown device". Is the partnerID 1 the current session device? After we verify the account, the second one with partnerID 83 is removed from the logins, leaving the device management list empty. Should we show some kind of empty state, or is the second one with partnerID 83 not supposed to be removed?

For Device is removed after dismissing the error and clearing cache, it's not a bug; it's how "Simulate failing network requests" works. The request was still sent successfully, but failed intentionally on the client.

@arosiclair

arosiclair · 2026-05-07T19:45:00Z

and only the second one with partnerID 83 will be shown, this is the "Unknown device".

We should fix this so that it displays the device name correctly when you first sign up. Let's pass deviceInfo in the SignUpUser command.

#89637

Does this melvinbot proposal fix this issue?

#89664

This is an issue on the backend. The ValidateSecondaryLogin deletes the device login because it was temporary and unvalidated. I'll update it to create a new login to replace it, but we also need to update ValidateSecondaryLogin to pass the deviceInfo too.

For #89671 (comment), it's not a bug; it's how "Simulate failing network requests" works. The request was still sent successfully, but failed intentionally on the client.

Agreed

bernhardoj · 2026-05-09T04:12:03Z

@arosiclair added deviceInfo param to both SignUpUser and ValidateSecondaryLogin.

Security - User is not signed out immediately after revoking current session

If we use the MelvinBot proposal, it will call a SignOut API which eventually logs out the user. I think we can just call redirectToSignIn, similar to when we failed to reauthenticate (which happens on every request after revoking the device).

App/src/libs/Reauthentication.ts

Lines 195 to 200 in 39d1d17

    
           Log.hmmm('[Reauthenticate] Redirecting to Sign In because we failed to reauthenticate', { 
        
               command, 
        
               error: errorMessage, 
        
           }); 
        
           redirectToSignIn(errorMessage); 
        
           return false;

WDYT?

arosiclair · 2026-05-11T18:29:03Z

Sounds good to me 👍

bernhardoj · 2026-05-12T03:05:43Z

Done

arosiclair · 2026-05-12T18:58:21Z

@arosiclair added deviceInfo param to both SignUpUser and ValidateSecondaryLogin.

Thanks, I still need to deploy a backend change to get these to work but we don't need to block on that for this PR.

@dukenv0307 ready for your review

dukenv0307 · 2026-05-13T02:33:56Z

+        if (login.partnerUserID !== autoGeneratedLogin) {
+            return;
+        }
+        redirectToSignIn();


Let's add the log here

What log to send?

cc: @arosiclair

I think it can be Log.info('Redirecting to Sign In because the current device was revoked');

Sounds good to me. Let's just add this in a quick follow up

dukenv0307 · 2026-05-13T03:09:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-05-13.at.10.03.04.mov

Android: mWeb Chrome

Screen.Recording.2026-05-13.at.09.48.04.mov

iOS: HybridApp

Screen.Recording.2026-05-13.at.09.51.15.mov

iOS: mWeb Safari

Screen.Recording.2026-05-13.at.09.46.32.mov

MacOS: Chrome / Safari

Screen.Recording.2026-05-13.at.09.35.10.mov

Screen.Recording.2026-05-13.at.09.44.58.mov

arosiclair · 2026-05-13T12:53:35Z

+        if (login.partnerUserID !== autoGeneratedLogin) {
+            return;
+        }
+        redirectToSignIn();


Sounds good to me. Let's just add this in a quick follow up

OSBotify · 2026-05-13T13:06:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-13T13:13:56Z

🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-13T13:21:27Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89704.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9d65949-624eeed-1d4162e3ae1c239709b7d170735807a97de033a4/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9d65949-624eeed-f669fde555b59ecf16aff2e901cec62071fea2d2/index.html

Web 🕸️
https://89704.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-13T21:30:04Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.3.74-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-05-15T18:09:10Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.74-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

bernhardoj added 2 commits May 6, 2026 11:54

Revert "Merge pull request Expensify#89670 from Expensify/francois-re…

86932f3

…vert-87948" This reverts commit 3e1312e, reversing changes made to 94727c1.

replace RenderHTML with plain Text becuase we don't render any HTML yet

f876b97

bernhardoj requested review from a team as code owners May 6, 2026 04:26

melvin-bot Bot assigned bernhardoj May 6, 2026

melvin-bot Bot requested review from dukenv0307 and heyjennahay May 6, 2026 04:26

melvin-bot Bot removed request for a team May 6, 2026 04:27

bernhardoj changed the title ~~Feat/86580 device management~~ #2 - Add device management feature May 6, 2026

bernhardoj added 2 commits May 9, 2026 11:19

Merge branch 'main' into feat/86580-device-management

dbb0029

add deviceInfo param

1114fa4

bernhardoj added 3 commits May 12, 2026 09:19

Merge branch 'main' into feat/86580-device-management

199fb84

prettier

f92dbea

sign out if revoking current device

1ba6535

bernhardoj added 3 commits May 12, 2026 12:23

fix test

e615d86

add test

98dec4d

prettier

5af949e

dukenv0307 reviewed May 13, 2026

View reviewed changes

dukenv0307 approved these changes May 13, 2026

View reviewed changes

melvin-bot Bot requested a review from arosiclair May 13, 2026 03:13

arosiclair approved these changes May 13, 2026

View reviewed changes

arosiclair merged commit 9d65949 into Expensify:main May 13, 2026
48 of 50 checks passed

OSBotify mentioned this pull request May 13, 2026

Deploy Checklist: New Expensify 2026-05-13 #90562

Closed

64 tasks

melvin-bot Bot mentioned this pull request May 15, 2026

[Due for payment 2026-05-22] [Device Management] Implement Device Management UI #86580

Open

Conversation

bernhardoj commented May 6, 2026 • edited by arosiclair Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 6, 2026

Uh oh!

melvin-bot Bot commented May 6, 2026

Uh oh!

codecov Bot commented May 6, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bernhardoj commented May 6, 2026

Uh oh!

arosiclair commented May 7, 2026

Uh oh!

bernhardoj commented May 9, 2026

Uh oh!

arosiclair commented May 11, 2026

Uh oh!

bernhardoj commented May 12, 2026

Uh oh!

arosiclair commented May 12, 2026

Uh oh!

dukenv0307 May 13, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj May 13, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 May 13, 2026

Choose a reason for hiding this comment

Uh oh!

arosiclair May 13, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

arosiclair May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented May 13, 2026

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

OSBotify commented May 13, 2026

Uh oh!

OSBotify commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bernhardoj commented May 6, 2026 •

edited by arosiclair

Loading

codecov Bot commented May 6, 2026 •

edited by github-actions Bot

Loading

dukenv0307 commented May 13, 2026 •

edited

Loading