[CP Staging] fix: Selected user appears twice in Add Copilot list#89715
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…lect mode instead
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
…earchSelector to keep existing behavior in other flows
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@dukenv0307 friendly bump, in case you missed this one |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…selected-duplicate [CP Staging] fix: Selected user appears twice in Add Copilot list (cherry picked from commit 905e58e) (cherry-picked to staging by grgia)
|
🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.3.67-7 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This is a UI bug fix that prevents a selected user from appearing twice in the Add Copilot list. It doesn't change any user-facing workflows, navigation steps, feature names, or terminology. The existing Copilot Access help article remains accurate. |
|
🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.3.67-11 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This is a bug fix that prevents a selected user from appearing twice in the Add Copilot list. The change adds a |
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.3.67-13 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.3.68-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes required. This PR is a bug fix that prevents a selected user from appearing twice in the Add Copilot list. It adds a No user-facing features, workflows, UI labels, or terminology were changed. The existing help site article (Copilot-Access.md) already accurately describes the Add Copilot flow and needs no updates. |
Explanation of Change
Makes
useSearchSelectornot filter out selected items fromavailableOptionsinAddDelegatePage, so that we can use them and have no duplication between Recent and Contacts sections, and also after selecting the option and going back have selected option still be visible and have its radio button selected.Fixed Issues
$ #89659
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-05-6.o.08.42.54.mov