[Odometer] Fix: Receipt is not visible after relaunching app and it loads infinitely#89739
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
flaviadefaria
left a comment
There was a problem hiding this comment.
From a product standpoint, the fix looks good to me.
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@DylanDylann All yours |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-05-06.at.22.37.10.movAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-05-06.at.22.28.20.moviOS: mWeb SafariMacOS: Chrome / Safari |
|
Great, thanks for the quick fix and review both! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…dometer_Receipt_is_not_visible_after_relaunching_app_and_it_loads_infinitely [Odometer] Fix: Receipt is not visible after relaunching app and it loads infinitely (cherry picked from commit 3362e7b) (cherry-picked to staging by Julesssss)
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.3.67-11 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR. This is a native-only bug fix that moves gallery-picked odometer receipt files into durable storage so they persist after the app is killed and relaunched. The change is purely internal file-handling logic ( No help site changes are required. |
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.3.67-13 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.3.68-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This is a technical bug fix that changes how odometer receipt images are stored internally on native (moving from a transient URI to durable storage). It does not change any user-facing behavior, workflows, UI labels, or features. The existing Distance Expenses article already accurately describes the odometer image attachment flow. |
Explanation of Change
On native, gallery-picked odometer receipts were stored using the picker's transient URI, which becomes unresolvable after the app is killed - leaving the saved-for-later receipt stuck on an infinite loader after relaunch. This change moves the picked file into the app's durable Receipts-Upload folder before persisting the URI, mirroring the camera path.
Fixed Issues
$ #89682
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
output2.mp4