fix: jump to existing workspaces tab instead of pushing new one#89750
Conversation
075937b to
7a414bb
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a414bb817
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
b89f6d7 to
8f603f3
Compare
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
2b74c02 to
5652156
Compare
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5652156392
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
0baf142 to
d75792e
Compare
|
@abdulrahuman5196 all comments have been resolved, it's ready for your review :) |
|
Looks like after removing a workspace from another device 2026-05-18.10.38.03.movFor more context |
7ee32cf to
3e67892
Compare
@ZhenjaHorbach It should work fine now :) |
|
Rechecking! |
|
now is good! |
|
Strange 2026-05-18.15.20.37.mov |
|
But overall changes look good |
|
Sorry |
mountiny
left a comment
There was a problem hiding this comment.
@WojtekBoman Do we need to update some docs about this session storage logic?
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.76-0 🚀
|
|
No help site changes required. This PR fixes internal navigation bugs (tab stack handling and not-found page focus gating). All changes are in navigation infrastructure code — no user-facing features, settings, terminology, or workflows were added or changed. |
Good point! I'll take a look 👀 |
|
Deploy Blocker #91087 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.77-3 🚀
|
Explanation of Change
Fixes two navigation bugs in workspace/domain tab handling:
WorkspacePageWithSectionsandWorkspaceInitialPage:shouldShow/shouldShowNotFoundPagenow gates onisFocused, preventing the not-found view from activating while the screen is rendered in the background (e.g. workspace deleted from another device while the user is on a different screen).navigateToWorkspacesPage: domain tab navigation now reuses the existingTAB_NAVIGATORviaTabActions.jumpTo(same as workspace), instead of callingNavigation.navigatewhich pushed a redundant newTAB_NAVIGATORon top of the stack.Screen.Recording.2026-05-06.at.16.39.16.mov
Fixed Issues
$ #88978
PROPOSAL:
Tests
TAB_NAVIGATORonto the stack (no duplicate navigator, back button behaves correctly).Offline tests
N/A — changes are navigation-only and do not involve API calls or Onyx writes.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari