Skip to content

refactor: badges own actionBadgeText translation #89752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
BartekObudzinski wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −6
Draft

refactor: badges own actionBadgeText translation #89752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/components/LHNOptionsList/OptionRowLHN/OptionRowErrorBadge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,32 @@ import React from 'react';
import {View} from 'react-native';
import Badge from '@components/Badge';
import Icon from '@components/Icon';
import useEnvironment from '@hooks/useEnvironment';
import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset';
import useLocalize from '@hooks/useLocalize';
import useTheme from '@hooks/useTheme';
import useThemeStyles from '@hooks/useThemeStyles';
import type {OptionData} from '@libs/ReportUtils';
import CONST from '@src/CONST';

type OptionRowErrorBadgeProps = {
brickRoadIndicator: OptionData['brickRoadIndicator'];
actionBadgeText: string;
actionBadge: OptionData['actionBadge'];
};

function OptionRowErrorBadge({brickRoadIndicator, actionBadgeText}: OptionRowErrorBadgeProps) {
function OptionRowErrorBadge({brickRoadIndicator, actionBadge}: OptionRowErrorBadgeProps) {
const theme = useTheme();
const styles = useThemeStyles();
const {translate} = useLocalize();
const {isProduction} = useEnvironment();
const {DotIndicator} = useMemoizedLazyExpensifyIcons(['DotIndicator']);

if (brickRoadIndicator !== CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR) {
return null;
}

const actionBadgeText = !isProduction && actionBadge ? translate(`common.actionBadge.${actionBadge}`) : '';
Copy link
Copy Markdown
Contributor

@TMisiukiewicz TMisiukiewicz May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to ship environment-based code?


return (
<View style={[styles.alignItemsCenter, styles.justifyContentCenter]}>
{actionBadgeText ? (
Expand Down
10 changes: 8 additions & 2 deletions src/components/LHNOptionsList/OptionRowLHN/OptionRowInfoBadge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,32 @@ import React from 'react';
import {View} from 'react-native';
import Badge from '@components/Badge';
import Icon from '@components/Icon';
import useEnvironment from '@hooks/useEnvironment';
import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset';
import useLocalize from '@hooks/useLocalize';
import useTheme from '@hooks/useTheme';
import useThemeStyles from '@hooks/useThemeStyles';
import type {OptionData} from '@libs/ReportUtils';
import CONST from '@src/CONST';

type OptionRowInfoBadgeProps = {
brickRoadIndicator: OptionData['brickRoadIndicator'];
actionBadgeText: string;
actionBadge: OptionData['actionBadge'];
};

function OptionRowInfoBadge({brickRoadIndicator, actionBadgeText}: OptionRowInfoBadgeProps) {
function OptionRowInfoBadge({brickRoadIndicator, actionBadge}: OptionRowInfoBadgeProps) {
const theme = useTheme();
const styles = useThemeStyles();
const {translate} = useLocalize();
const {isProduction} = useEnvironment();
const {DotIndicator} = useMemoizedLazyExpensifyIcons(['DotIndicator']);

if (brickRoadIndicator !== CONST.BRICK_ROAD_INDICATOR_STATUS.INFO) {
return null;
}

const actionBadgeText = !isProduction && actionBadge ? translate(`common.actionBadge.${actionBadge}`) : '';

if (actionBadgeText) {
return (
<Badge
Expand Down
4 changes: 2 additions & 2 deletions src/components/LHNOptionsList/OptionRowLHN/OptionRowLHNCore.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,14 +195,14 @@ function OptionRowLHN({
) : null}
<OptionRowErrorBadge
brickRoadIndicator={brickRoadIndicator}
actionBadgeText={actionBadgeText}
actionBadge={optionItem.actionBadge}
/>
</View>
</View>
<View style={[styles.flexRow, styles.alignItemsCenter]}>
<OptionRowInfoBadge
brickRoadIndicator={brickRoadIndicator}
actionBadgeText={actionBadgeText}
actionBadge={optionItem.actionBadge}
/>
{hasDraftComment && !!optionItem.isAllowedToComment && (
<View
Expand Down
Loading