Skip to content

[Home Page] Update Your Expensify Cards to Your spend to streamline common points of customer confusion#89899

Merged
grgia merged 39 commits into
Expensify:mainfrom
software-mansion-labs:@adamgrzybowski/your-spend
May 20, 2026
Merged

[Home Page] Update Your Expensify Cards to Your spend to streamline common points of customer confusion#89899
grgia merged 39 commits into
Expensify:mainfrom
software-mansion-labs:@adamgrzybowski/your-spend

Conversation

@adamgrzybowski
Copy link
Copy Markdown
Contributor

@adamgrzybowski adamgrzybowski commented May 7, 2026

Explanation of Change

  • Replace the Your Expensify Cards slot on the Home page with a broader Your spend slot.
  • Add Awaiting approval and Repaid in the last 30 days rows showing summed totals across workspaces.
  • Retitle each Expensify Card row to Recent transactions • <lastFour> and switch its total to last‑30‑days spend.
  • Tapping a row navigates to the corresponding Spend > Expenses query; rows without data are hidden, and the slot is hidden when nothing applies.

Fixed Issues

$ #87743
PROPOSAL:

Tests

Offline tests

QA Steps

  1. Sign in as a user with at least one approval-enabled workspace, one payment-enabled paid workspace, and matching outstanding/recently paid reimbursable expenses.
  2. Open Home and confirm the Your spend slot renders with Awaiting approval and Repaid in the last 30 days rows and bold summed totals.
  3. Tap each status row and verify it navigates to Spend > Expenses with the correct filters (status:outstanding / status:paid + last 30 days).
  4. Sign in as a user with one or more assigned Expensify Cards and verify a Recent transactions • <last4> row per card with the doughnut filling proportionally to spend (red at 100%).
  5. Tap a card row and verify it navigates to Spend > Expenses filtered by that card and the last 30 days.
  6. Verify applicability: with no approval/payment flow and no card the slot is hidden; with only a card, only the card row shows.
  7. Repeat on iOS native, Android native, iOS mWeb Safari, Android mWeb Chrome, and confirm no JS console errors.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 7, 2026

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...rc/components/Icon/chunks/expensify-icons.chunk.ts 0.00% <ø> (ø)
src/pages/home/HomePage.tsx 100.00% <ø> (ø)
src/pages/home/YourSpendSection/CardRow.tsx 100.00% <100.00%> (ø)
src/pages/home/YourSpendSection/const.ts 100.00% <100.00%> (ø)
src/pages/home/YourSpendSection/index.tsx 100.00% <100.00%> (ø)
src/pages/home/YourSpendSection/queries.ts 100.00% <100.00%> (ø)
src/libs/PolicyUtils.ts 69.52% <0.00%> (+1.63%) ⬆️
...ges/home/YourSpendSection/RemainingLimitCircle.tsx 30.76% <0.00%> (ø)
...rc/pages/home/YourSpendSection/useYourSpendData.ts 97.32% <97.32%> (ø)
...rc/pages/home/YourSpendSection/SpendSummaryRow.tsx 90.00% <90.00%> (ø)
... and 231 files with indirect coverage changes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented May 7, 2026

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index 4de93e2a..4a8d1ebe 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -1037,6 +1037,12 @@ const translations: TranslationDeepObject<typeof en> = {
                 other: (pluralCount: number) => `Verbleibende Zeit: ${pluralCount} Tage`,
             }),
         },
+        yourSpend: {
+            title: 'Ihre Ausgaben',
+            awaitingApproval: 'Ausstehende Genehmigung',
+            repaidLast30Days: 'In den letzten 30 Tagen zurückgezahlt',
+            recentTransactions: ({lastFour}: {lastFour: string}) => `Aktuelle Transaktionen • ${lastFour}`,
+        },
     },
     allSettingsScreen: {
         subscription: 'Abonnement',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 580833a8..e4af99e3 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -1040,6 +1040,12 @@ const translations: TranslationDeepObject<typeof en> = {
             setupRules: 'Configurer les règles de dépense',
             inviteAccountant: 'Inviter votre comptable',
         },
+        yourSpend: {
+            title: 'Vos dépenses',
+            awaitingApproval: 'En attente d’approbation',
+            repaidLast30Days: 'Remboursé au cours des 30 derniers jours',
+            recentTransactions: ({lastFour}: {lastFour: string}) => `Transactions récentes • ${lastFour}`,
+        },
     },
     allSettingsScreen: {
         subscription: 'Abonnement',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 85412c27..faaf7d26 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -1038,6 +1038,12 @@ const translations: TranslationDeepObject<typeof en> = {
             setupRules: 'Configura le regole di spesa',
             inviteAccountant: 'Invita il tuo commercialista',
         },
+        yourSpend: {
+            title: 'Le tue spese',
+            awaitingApproval: 'In attesa di approvazione',
+            repaidLast30Days: 'Rimborsato negli ultimi 30 giorni',
+            recentTransactions: ({lastFour}: {lastFour: string}) => `Transazioni recenti • ${lastFour}`,
+        },
     },
     allSettingsScreen: {
         subscription: 'Abbonamento',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 35666c34..03f8c75e 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -1021,6 +1021,12 @@ const translations: TranslationDeepObject<typeof en> = {
             setupRules: '支出ルールを設定',
             inviteAccountant: '会計士を招待',
         },
+        yourSpend: {
+            title: 'あなたの支出',
+            awaitingApproval: '承認待ち',
+            repaidLast30Days: '過去30日間に返済済み',
+            recentTransactions: ({lastFour}: {lastFour: string}) => `最近の取引 • ${lastFour}`,
+        },
     },
     allSettingsScreen: {
         subscription: 'サブスクリプション',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 11864eee..0f819689 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1036,6 +1036,12 @@ const translations: TranslationDeepObject<typeof en> = {
             setupRules: 'Uitgavenregels instellen',
             inviteAccountant: 'Nodig je accountant uit',
         },
+        yourSpend: {
+            title: 'Je uitgaven',
+            awaitingApproval: 'In afwachting van goedkeuring',
+            repaidLast30Days: 'Terugbetaald in de afgelopen 30 dagen',
+            recentTransactions: ({lastFour}: {lastFour: string}) => `Recente transacties • ${lastFour}`,
+        },
     },
     allSettingsScreen: {
         subscription: 'Abonnement',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index fee79580..713de369 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -1038,6 +1038,12 @@ const translations: TranslationDeepObject<typeof en> = {
             setupRules: 'Skonfiguruj zasady wydatków',
             inviteAccountant: 'Zaproś swojego księgowego',
         },
+        yourSpend: {
+            title: 'Twoje wydatki',
+            awaitingApproval: 'Oczekuje na zatwierdzenie',
+            repaidLast30Days: 'Spłacono w ciągu ostatnich 30 dni',
+            recentTransactions: ({lastFour}: {lastFour: string}) => `Ostatnie transakcje • ${lastFour}`,
+        },
     },
     allSettingsScreen: {
         subscription: 'Subskrypcja',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index d44b4ef4..932460a4 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -1036,6 +1036,12 @@ const translations: TranslationDeepObject<typeof en> = {
             setupRules: 'Configurar regras de gasto',
             inviteAccountant: 'Convide seu contador',
         },
+        yourSpend: {
+            title: 'Seus gastos',
+            awaitingApproval: 'Aguardando aprovação',
+            repaidLast30Days: 'Reembolsado nos últimos 30 dias',
+            recentTransactions: ({lastFour}: {lastFour: string}) => `Transações recentes • ${lastFour}`,
+        },
     },
     allSettingsScreen: {
         subscription: 'Assinatura',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index d416e611..71ba0ff5 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -1004,6 +1004,7 @@ const translations: TranslationDeepObject<typeof en> = {
             setupRules: '设置消费规则',
             inviteAccountant: '邀请你的会计',
         },
+        yourSpend: {title: '您的支出', awaitingApproval: '等待审批', repaidLast30Days: '过去30天内已偿还', recentTransactions: ({lastFour}: {lastFour: string}) => `最近交易 • ${lastFour}`},
     },
     allSettingsScreen: {
         subscription: '订阅',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

@grgia grgia self-requested a review May 7, 2026 14:30
@grgia
Copy link
Copy Markdown
Contributor

grgia commented May 7, 2026

Here's on my account:

image

Cards for ref:

image
Screen.Recording.2026-05-07.at.3.32.47.PM.mov

Clicking on the cards shows a view that doesnt seem to correlate with the results


old home page:

image

cc @JmillsExpensify

@adamgrzybowski
Copy link
Copy Markdown
Contributor Author

@grgia Okay, testing this on fake data on my end doesn't seem to work well 😄 I will try to figure out a better way of testing

@JmillsExpensify
Copy link
Copy Markdown
Contributor

No worries. We can test again tomorrow.

@github-actions
Copy link
Copy Markdown
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

Comment thread src/pages/home/YourSpendSection/useYourSpendData.ts
Comment thread src/pages/home/YourSpendSection/useYourSpendData.ts
@ZhenjaHorbach
Copy link
Copy Markdown
Contributor

But overall changes look good!

@adamgrzybowski
Copy link
Copy Markdown
Contributor Author

image

@dubielzyk-expensify @shawnborton This is the updated version. Is it okay, or should I make the second row shorter, like in the for you section?

@shawnborton
Copy link
Copy Markdown
Contributor

Shorter second row would be great!

@adamgrzybowski
Copy link
Copy Markdown
Contributor Author

@shawnborton done ✅
image

@shawnborton
Copy link
Copy Markdown
Contributor

Looks good 👍

@adamgrzybowski
Copy link
Copy Markdown
Contributor Author

@grgia I think it's good to go

Copy link
Copy Markdown
Contributor

@grgia grgia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and scene

@grgia grgia merged commit c4ce960 into Expensify:main May 20, 2026
41 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.79-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot
Copy link
Copy Markdown
Contributor

Yes, help site changes are required. The PR replaces the Assigned cards section on Home with a broader Your spend section, and the help site article Expensify-Home-Overview.md documents this section.

I've created a draft PR with the necessary updates: #91361

Changes made:

  • Replaced all references to Assigned cards with Your spend throughout the article
  • Rewrote the section description to document the three new row types: Awaiting approval, Repaid in the last 30 days, and Recent transactions • <last four digits>
  • Updated the FAQ visibility conditions to reflect the broader applicability of the new section
  • Updated keywords and internal scope metadata

Please mark it as "Ready for review" when it is ready for review.

@lanitochka17
Copy link
Copy Markdown

Deploy Blocker ##91370 was identified to be related to this PR.

@mitarachim
Copy link
Copy Markdown

Deploy Blocker #91371 was identified to be related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.