fix: enhance AddAgentPage for landscape mode support#89930
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
943761a to
bbfa979
Compare
This comment has been minimized.
This comment has been minimized.
|
🚧 @NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@Expensify/design guys do we want to support also iOS and Android using web browsers in landscape mode? I was checking and some modals are definitely not compatible, but since there isn't a lot of space available, I was wondering if we want to support that or not? |
|
Hmm @GCyganek what's our general take there - we've been updating landscape support for basically all platforms, right? |
We've been focused on fixing it on native apps on iOS and Android, not in web browsers on mobile. I believe landscape mode has been available in web browsers on mobile since the start as it was not blocked in any way, contrary to native apps, we just didn't care about it |
|
Great, thanks for the confirmation. I think it makes sense to stay consistent with our approach here then. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-05-09.at.1.27.13.AM.movAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-05-09.at.1.17.09.AM.moviOS: mWeb SafariMacOS: Chrome / Safari |
|
Author checklist and CLA are failing |
CLA is broken due to a bug, @puneetlath is ok to bypass again (due to: https://expensify.slack.com/archives/C03TQ48KC/p1777586324999179)?? |
|
@puneetlath looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
@NicolasBonet did sign the CLA here. The check is failing because of this bug: https://github.com/Expensify/Expensify/issues/631744 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.70-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR. They are purely technical UI fixes — adding landscape mode scroll support and layout adjustments to No help site changes are required. |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.72-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. The changes are a UI layout fix for the Add Agent page in landscape mode (enabling scroll view and adjusting content height). No user-facing features, workflows, or terminology were added or modified. |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.72-1 🚀
|
Explanation of Change
It fixes the issue where the user wasn't able to see the keyboard while they were typing on landscape mode.
Fixed Issues
$ #89861
PROPOSAL:https://expensify.enterprise.slack.com/docs/T03SC9DTT/F0AKV1FPD41
Tests
Offline tests
No steps needed
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-05-07.at.10.24.45.AM.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-05-07.at.10.36.02.AM.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-05-07.at.10.31.54.AM.mov