[NoQA] Show warning for locked HR toggle by ShridharGoel · Pull Request #89970 · Expensify/App

ShridharGoel · 2026-05-07T22:08:08Z

Explanation of Change

Shows the standard "Oops! Not so fast..." dialog when the HR toggle is locked because Gusto is connected. This explains that HR cannot be disabled until Gusto is disconnected from the workspace.

Fixed Issues

$ #87011
PROPOSAL: N/A

Tests

Open a workspace with Gusto connected.
Go to Workspace settings > More features.
In the Integrate section, press the locked HR toggle.
Verify the "Oops! Not so fast..." dialog appears.
Verify the dialog says HR cannot be disabled until Gusto is disconnected.
Press OK and verify the dialog closes.

Verify that no errors appear in the JS console

Offline tests

Open a workspace with Gusto connected.
Turn off the network connection.
Go to Workspace settings > More features.
Press the locked HR toggle.
Verify the warning dialog still appears and closes correctly.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-05-08.at.4.38.33.AM.mov

melvin-bot · 2026-05-07T22:08:13Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

OSBotify · 2026-05-07T23:00:48Z

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff

diff --git a/src/languages/de.ts b/src/languages/de.ts
index 2eb97325..d5c5b12f 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -5742,6 +5742,7 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
                 subtitle: 'Legen Sie einen abrechnungsfähigen Stundensatz für die Zeiterfassung fest.',
                 defaultHourlyRate: 'Standardstundensatz',
             },
+            hrWarningModal: {disconnectText: 'Um HR zu deaktivieren, trenne bitte zuerst die Verbindung von Gusto mit diesem Workspace.'},
         },
         reports: {
             reportsCustomTitleExamples: 'Beispiele:',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index a0a522e3..7ca9a7c7 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -5762,6 +5762,7 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
                 subtitle: 'Définissez un taux horaire facturable pour le suivi du temps.',
                 defaultHourlyRate: 'Taux horaire par défaut',
             },
+            hrWarningModal: {disconnectText: 'Pour désactiver les RH, veuillez d’abord déconnecter Gusto de cet espace de travail.'},
         },
         reports: {
             reportsCustomTitleExamples: 'Exemples :',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index efcd2228..c44d0975 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -5732,6 +5732,7 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
                 subtitle: 'Imposta una tariffa oraria fatturabile per il rilevamento del tempo.',
                 defaultHourlyRate: 'Tariffa oraria predefinita',
             },
+            hrWarningModal: {disconnectText: 'Per disattivare le risorse umane, disconnetti prima Gusto da questo spazio di lavoro.'},
         },
         reports: {
             reportsCustomTitleExamples: 'Esempi:',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index ebc08db9..45cef435 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -5665,6 +5665,7 @@ _詳しい手順については、[ヘルプサイトをご覧ください](${CO
                 subtitle: '時間追跡用の請求可能な時間単価を設定します。',
                 defaultHourlyRate: 'デフォルトの時給率',
             },
+            hrWarningModal: {disconnectText: '人事機能を無効にするには、まずこのワークスペースから Gusto の連携を解除してください。'},
         },
         reports: {
             reportsCustomTitleExamples: '例:',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index c923ea18..bde5c570 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -5712,6 +5712,7 @@ _Voor meer gedetailleerde instructies, [bezoek onze help-site](${CONST.NETSUITE_
                 subtitle: 'Stel een factureerbaar uurtarief in voor tijdregistratie.',
                 defaultHourlyRate: 'Standaard uurtarief',
             },
+            hrWarningModal: {disconnectText: 'Om HR uit te schakelen, verbreek eerst de verbinding van Gusto met deze workspace.'},
         },
         reports: {
             reportsCustomTitleExamples: 'Voorbeelden:',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index adaeeaa9..a784796c 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -5706,6 +5706,7 @@ _Aby uzyskać bardziej szczegółowe instrukcje, [odwiedź naszą stronę pomocy
                 subtitle: 'Ustaw godzinową stawkę rozliczeniową do śledzenia czasu.',
                 defaultHourlyRate: 'Domyślna stawka godzinowa',
             },
+            hrWarningModal: {disconnectText: 'Aby wyłączyć HR, najpierw odłącz Gusto od tego miejsca pracy.'},
         },
         reports: {
             reportsCustomTitleExamples: 'Przykłady:',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index af446e4e..83654d5e 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -5712,6 +5712,7 @@ _Para instruções mais detalhadas, [visite nossa central de ajuda](${CONST.NETS
                 subtitle: 'Defina uma taxa horária faturável para o controle de tempo.',
                 defaultHourlyRate: 'Taxa horária padrão',
             },
+            hrWarningModal: {disconnectText: 'Para desativar o RH, primeiro desconecte o Gusto deste workspace.'},
         },
         reports: {
             reportsCustomTitleExamples: 'Exemplos:',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 191caae4..5ba7a59a 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -5567,6 +5567,7 @@ _如需更详细的说明，请[访问我们的帮助网站](${CONST.NETSUITE_IM
                 subtitle: '为时间跟踪设置可计费的小时费率。',
                 defaultHourlyRate: '默认时薪',
             },
+            hrWarningModal: {disconnectText: '若要禁用人力资源功能，请先将 Gusto 与此工作区断开连接。'},
         },
         reports: {
             reportsCustomTitleExamples: '示例：',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

melvin-bot · 2026-05-07T23:09:44Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-05-07T23:17:49Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...ages/workspace/WorkspaceMoreFeaturesPage/index.tsx	`69.37% <33.33%> (-0.41%)`	⬇️
... and 22 files with indirect coverage changes

yuwenmemon · 2026-05-08T02:00:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

yuwenmemon · 2026-05-08T02:01:08Z

+            hrWarningModal: {
+                disconnectText: 'To disable HR, please disconnect Gusto from this workspace first.',
+            },


Eventually this will be parameterized for whatever connection is connected cc @Krishna2323

github-actions · 2026-05-08T02:02:22Z

🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-08T02:06:37Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89970.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-30fd07a-16ca8cb-195bdd271bef3ce496cb177cdd8ac7acd58b0097/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-30fd07a-16ca8cb-647d791d7739c4c85a0fa6d86cbf5c8a1387f43f/index.html

Web 🕸️
https://89970.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-08T02:09:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-08T15:44:16Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.3.69-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-05-11T23:44:45Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.69-18 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Show HR locked toggle warning

f56e50d

melvin-bot Bot assigned ShridharGoel May 7, 2026

Update translations

a779901

ShridharGoel marked this pull request as ready for review May 7, 2026 23:09

ShridharGoel requested review from a team as code owners May 7, 2026 23:09

melvin-bot Bot requested review from heyjennahay and shubham1206agra May 7, 2026 23:09

melvin-bot Bot removed request for a team May 7, 2026 23:09

ShridharGoel changed the title ~~Show warning for locked HR toggle~~ [NoQA] Show warning for locked HR toggle May 7, 2026

yuwenmemon approved these changes May 8, 2026

View reviewed changes

yuwenmemon merged commit 30fd07a into Expensify:main May 8, 2026
44 checks passed

OSBotify mentioned this pull request May 8, 2026

Deploy Checklist: New Expensify 2026-05-08 #90006

Closed

melvin-bot Bot mentioned this pull request May 11, 2026

[Due for payment 2026-05-18] [Due for payment 2026-04-23] [Gusto R1] Add Gusto icon and shared presentation pieces #87011

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NoQA] Show warning for locked HR toggle#89970

[NoQA] Show warning for locked HR toggle#89970
yuwenmemon merged 2 commits into
Expensify:mainfrom
ShridharGoel:gusto1.11

ShridharGoel commented May 7, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented May 7, 2026

Uh oh!

OSBotify commented May 7, 2026

Uh oh!

melvin-bot Bot commented May 7, 2026

Uh oh!

codecov Bot commented May 7, 2026 •

edited by github-actions Bot

Loading

Uh oh!

yuwenmemon commented May 8, 2026

Uh oh!

yuwenmemon May 8, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 8, 2026

Uh oh!

github-actions Bot commented May 8, 2026

Uh oh!

OSBotify commented May 8, 2026

Uh oh!

OSBotify commented May 8, 2026

Uh oh!

OSBotify commented May 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ShridharGoel commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 7, 2026

Uh oh!

OSBotify commented May 7, 2026

🦜 Polyglot Parrot! 🦜

Uh oh!

melvin-bot Bot commented May 7, 2026

Uh oh!

codecov Bot commented May 7, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

yuwenmemon commented May 8, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

yuwenmemon May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 8, 2026

Uh oh!

github-actions Bot commented May 8, 2026

Uh oh!

OSBotify commented May 8, 2026

Uh oh!

OSBotify commented May 8, 2026

Uh oh!

OSBotify commented May 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ShridharGoel commented May 7, 2026 •

edited

Loading

codecov Bot commented May 7, 2026 •

edited by github-actions Bot

Loading