fix: Preserve move-expense context through upgrade flow#89986
Draft
jakubstec wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
52 tasks
mhawryluk
approved these changes
May 11, 2026
Contributor
mhawryluk
left a comment
There was a problem hiding this comment.
cool, just a small question from me
| action: CONST.IOU.ACTION.CREATE, | ||
| iouType: CONST.IOU.TYPE.CREATE, | ||
| transactionID: generateReportID(), | ||
| transactionID: selectedTransactionsKeys.at(0) ?? generateReportID(), |
Contributor
There was a problem hiding this comment.
a random reportID is still passed below. shouldn't we update it too?
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Follow-up PR to #88952. It changes the
reportIDto useselectedTransactionsKeysinstead of generating fake transactionID, to now trigger the proper flow of moving expenses (IOURequestStepUpgrade.tsx, Line 130).Fixed Issues
$ #88928
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
iOS: Native
Screen.Recording.2026-05-08.at.12.12.07.mov
MacOS: Chrome / Safari
Screen.Recording.2026-05-08.at.11.07.28.mov
Screen.Recording.2026-05-08.at.11.09.18.mov