[Payment due @ShridharGoel] Have CSV-imported cards open the RHP by Gonals · Pull Request #89998 · Expensify/App

Gonals · 2026-05-08T12:47:30Z

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/596278
PROPOSAL:

Tests

In an account in the CSV import beta:

Log into NewDot
Go to account->Wallet->Import transactions and follow the flow. You can use this file:
fake_transactions-2026-01-16 10_56_55.629.csv
Confirm that, when clicking the card that was just created, the RHP opens:

Confirm you can add more transactions and remove the card as usual.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-05-08T12:56:26Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/settings/Wallet/PaymentMethodList.tsx	`0.00% <0.00%> (ø)`
.../settings/Wallet/PersonalCardDetailsHeaderMenu.tsx	`0.00% <0.00%> (ø)`
.../pages/settings/Wallet/PersonalCardDetailsPage.tsx	`0.00% <0.00%> (ø)`
... and 11 files with indirect coverage changes

ShridharGoel · 2026-05-08T13:03:58Z

@Gonals Kindly assign me as reviewer when it's ready, thanks

Gonals · 2026-05-08T15:36:11Z

All yours @ShridharGoel

trjExpensify

Core PR for a WN project. 👍

ShridharGoel · 2026-05-12T20:45:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-05-13.at.3.40.47.AM.mov

Android: mWeb Chrome

Screen.Recording.2026-05-13.at.3.30.10.AM.mov

iOS: HybridApp

iOS: mWeb Safari

Screen.Recording.2026-05-13.at.3.47.39.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-05-11.at.8.13.20.PM.mov

ShridharGoel · 2026-05-12T20:47:11Z

NAB: Not here page briefly shows after deletion, before the pane closes.

Screen.Recording.2026-05-13.at.2.16.07.AM.mov

ShridharGoel

Looks good, just need to consider this

melvin-bot · 2026-05-12T22:20:55Z

@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-05-12T22:20:57Z

🎯 @ShridharGoel, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/596278.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

chuckdries · 2026-05-12T22:30:52Z

+            deletePersonalCard({cardID: card.cardID, card, allTransactions, allReports, savedColumnLayout});
+            Navigation.goBack();


NAB: Not here page briefly shows after deletion, before the pane closes.

I suspect you can solve this by calling goBack before you call deletePersonalCard. That may have implications for error handling that I'm unaware of though.

Yes, I was thinking the same.

OSBotify · 2026-05-15T15:48:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

ghost · 2026-05-15T15:57:36Z

🚧 @chuckdries has triggered a test Expensify/App build. You can view the workflow run here.

ghost · 2026-05-15T16:01:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89998.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d888a77-d554b36-e00ba24ed5df5abbd7690574fb1c21e5ae3780b7/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d888a77-d554b36-070b1ab532b4878f742de9a8bef4396f49b78d94/index.html

Web 🕸️
https://89998.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-15T17:24:27Z

🚀 Deployed to staging by https://github.com/chuckdries in version: 9.3.74-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-15T17:28:08Z

Yes, help site changes are required. PR #89998 changes CSV-imported personal cards to open the card details page (RHP) and adds Delete and Import spreadsheet menu options. Two articles needed updates:

Import-Personal-Card-Transactions-From-a-Spreadsheet.md — Updated the FAQ to reflect that spreadsheet-imported cards can now be deleted from the card details page (previously said you couldn't delete them), and noted the Import spreadsheet option for adding more transactions.
Manage-Personal-Cards.md — Added the new Delete and Import spreadsheet capabilities to the list of manageable settings for spreadsheet-imported cards.

Draft PR with HelpDot label: #90806

OSBotify · 2026-05-15T18:09:58Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.74-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot · 2026-05-15T18:19:57Z

🤖 Payment issue created: #90826

mitarachim · 2026-05-15T23:42:08Z

Deploy Blocker #90847 was identified to be related to this PR.

mitarachim · 2026-05-15T23:49:31Z

Deploy Blocker #90849 was identified to be related to this PR.

lanitochka17 · 2026-05-15T23:56:43Z

Deploy Blocker ##90848 was identified to be related to this PR

Gonals added 4 commits May 8, 2026 14:44

open RHN

60f8931

hide 3 dots

e1ab5b9

add table and delete options

3b89192

better delete handling

6bf96e7

Gonals self-assigned this May 8, 2026

Gonals added 5 commits May 8, 2026 15:16

lint

be09bcf

prettier

d7224e9

lint

561dea9

use then

ba0c546

lint

208432f

Gonals marked this pull request as ready for review May 8, 2026 15:11

Gonals requested review from a team as code owners May 8, 2026 15:11

melvin-bot Bot requested review from eVoloshchak and trjExpensify and removed request for a team May 8, 2026 15:11

ghost reviewed May 8, 2026

View reviewed changes

Comment thread src/pages/settings/Wallet/PersonalCardDetailsPage.tsx

Gonals requested review from ShridharGoel and removed request for eVoloshchak May 8, 2026 15:16

Expensify deleted a comment from melvin-bot Bot May 8, 2026

trjExpensify previously approved these changes May 8, 2026

View reviewed changes

ghost reviewed May 8, 2026

View reviewed changes

Comment thread src/pages/settings/Wallet/PersonalCardDetailsPage.tsx

ShridharGoel approved these changes May 12, 2026

View reviewed changes

melvin-bot Bot requested a review from chuckdries May 12, 2026 22:20

melvin-bot Bot changed the title ~~Have CSV-imported cards open the RHP~~ [Payment due @ShridharGoel] Have CSV-imported cards open the RHP May 12, 2026

ghost reviewed May 12, 2026

View reviewed changes

Comment thread src/pages/settings/Wallet/PersonalCardDetailsPage.tsx

ghost reviewed May 12, 2026

View reviewed changes

Comment thread src/pages/settings/Wallet/PersonalCardDetailsPage.tsx

chuckdries reviewed May 12, 2026

View reviewed changes

Gonals added 2 commits May 15, 2026 15:06

Merge branch 'main' into alberto-moveSide

78fad14

move goback

82bafaf

Gonals dismissed trjExpensify’s stale review via 82bafaf May 15, 2026 13:18

chuckdries approved these changes May 15, 2026

View reviewed changes

chuckdries merged commit d888a77 into main May 15, 2026
44 checks passed

chuckdries deleted the alberto-moveSide branch May 15, 2026 15:38

OSBotify mentioned this pull request May 15, 2026

Deploy Checklist: New Expensify 2026-05-15 #90795

Closed

MelvinBot mentioned this pull request May 15, 2026

Docs updates for E/A#89998 Update help site for CSV card RHP changes #90806

Closed

melvin-bot Bot mentioned this pull request May 15, 2026

[Due for payment 2026-05-22] Payment issue for E/App PR#89998 #90826

Closed

mitarachim mentioned this pull request May 15, 2026

Wallet - Card name is not populated with display card name #90847

Open

7 tasks

mitarachim mentioned this pull request May 15, 2026

[Due for payment 2026-05-29] Wallet- RHP closes instead of returning to card page after clicking back button on import page #90849

Open

7 tasks

		deletePersonalCard({cardID: card.cardID, card, allTransactions, allReports, savedColumnLayout});
		Navigation.goBack();

Conversation

Gonals commented May 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ShridharGoel commented May 8, 2026

Uh oh!

Uh oh!

Gonals commented May 8, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ShridharGoel commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ShridharGoel commented May 12, 2026

Uh oh!

ShridharGoel left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 12, 2026

Uh oh!

melvin-bot Bot commented May 12, 2026

Uh oh!

Uh oh!

Uh oh!

chuckdries May 12, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel May 12, 2026

Choose a reason for hiding this comment

Uh oh!

Gonals May 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented May 15, 2026

Uh oh!

ghost commented May 15, 2026

Uh oh!

ghost commented May 15, 2026

Uh oh!

OSBotify commented May 15, 2026

Uh oh!

MelvinBot commented May 15, 2026

Uh oh!

OSBotify commented May 15, 2026

Uh oh!

melvin-bot Bot commented May 15, 2026

Uh oh!

mitarachim commented May 15, 2026

Uh oh!

mitarachim commented May 15, 2026

Uh oh!

lanitochka17 commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Gonals commented May 8, 2026 •

edited by github-actions Bot

Loading

codecov Bot commented May 8, 2026 •

edited by github-actions Bot

Loading

ShridharGoel commented May 12, 2026 •

edited

Loading