[GPS] Add stop address editing#90002
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Explanation of Change
WATING FOR BACKEND CHANGES THAT ALLOW SENDING MODIFIED END WAYPOINT
Adds an "Edit Stop" screen for GPS distance trips, allowing users to trim the recorded route to a shorter distance. A slider lets users set the desired endpoint; the map updates in real-time to preview the trimmed route. The trimmed end point and modified distance are persisted in Onyx (
trimmedEndPoint,modifiedDistance) and cleared when the trip resumes. Reverse-geocoding is used to resolve the trimmed stop address when online.Fixed Issues
$ #85802
PROPOSAL: N/A
Tests
trimmedEndPointormodifiedDistanceis persisted and the original trip distance is shown.modifiedDistanceandtrimmedEndPointare cleared and the full recorded distance is used again.Offline tests
12.3456, 78.9012) instead of a reverse-geocoded address, and the trimmed distance is still correctly applied.QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari