[No QA] Docs updates for E/A#85493 Add distance editing to Distance Expenses article#90012
Conversation
Update the Distance Expenses help article to document the new ability to edit distance on existing expenses via Map and Manual tabs. Co-authored-by: Mukhriddin Shakhriyorov <mukhrr@users.noreply.github.com>
HelpDot Documentation ReviewOverall AssessmentThis PR adds a new section explaining how to edit the distance on an existing Distance expense, updates YAML metadata to reflect the new editing coverage, and expands the related FAQ answer. The changes are well-structured, concise, and follow governance standards closely. A few minor items are noted below. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This review covers only the proposed changes in the diff, not unchanged portions of the file. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 209ca792b2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Clarified the section title and improved the explanation for editing distance expenses.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @sakluger |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a new section explaining how to edit an existing Distance expense (map or manual) and updates the corresponding FAQ answer to reflect the new editing capability. The changes are well-structured, concise, and align closely with the existing article style. Only minor issues were identified. Scores Summary
Key Findings
Recommendations
Files Reviewed
|
|
|
||
| To edit the distance: | ||
|
|
||
| 1. Open the Distance expense. |
There was a problem hiding this comment.
Readability / structure (missing navigation path): "Open the Distance expense" does not tell the user how to navigate to the expense. Per HELPSITE_NAMING_CONVENTIONS.md, avoid vague navigation phrases and always reference the exact UI path. Consider providing a concrete navigation instruction, such as "Select the Distance expense from your chat or report" or specifying the screen where the user can find it.
|
A preview of your ExpensifyHelp changes have been deployed to https://a17cda11.helpdot.pages.dev ⚡️ Updated articles: |
|
@sakluger looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a new procedural section explaining how to edit an existing Distance expense, and updates a related FAQ answer to provide more specific guidance. The changes are well-scoped, focused on a single workflow addition, and largely follow HelpDot governance standards. A few minor items could be tightened. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This review assessed only the proposed changes (diff), not unchanged portions of the file. |
|
🚀 Deployed to staging by https://github.com/sakluger in version: 9.3.76-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.77-3 🚀
|
Summary
Related PR: #85493
Test plan