[No QA] Docs updates for E/A#88426 Add 2 MB file size limit to global reimbursement docs#90015
Conversation
Update all global reimbursement help site articles to document the new 2 MB per-file size limit for Corpay document uploads introduced in #88426. Co-authored-by: Maxence Coulibaly <madmax330@users.noreply.github.com>
HelpDot Documentation ReviewOverall AssessmentThis PR adds file size limit information ("2 MB") across five global reimbursement articles to match a new frontend enforcement from E/A#88426. The added text is factually clear and well-placed alongside existing file-type references. However, the changes use inconsistent phrasing across files, which conflicts with the Deterministic Writing Rule in the naming conventions. Scores Summary
Key FindingsInconsistent phrasing (primary issue):
Per the governance docs, clarity and precision take precedence over prose style, and stylistic variation should be avoided. A single canonical phrasing should be chosen and applied everywhere. Positive aspects:
Recommendations
Files Reviewed
Review based on governance files: HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, TEMPLATE.md. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@jliexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| - If **you are** a Director/Senior Officer: | ||
| - Provide your full legal name, address, and ID. | ||
| - Upload proof of address and a valid form of identification (PDF, PNG, or JPEG only). | ||
| - Upload proof of address and a valid form of identification (PDF, PNG, or JPEG only, 2 MB max per file). |
There was a problem hiding this comment.
Deterministic writing / consistency: This PR uses three different phrasings for the same file size limit: "Each file must be 2 MB or less." (Australia, Canada), "2 MB max per file" (here, UK L49, US L60), and "each file must be 2 MB or less" (Europe L73, UK L73, US L30). Per HELPSITE_NAMING_CONVENTIONS.md Deterministic Writing Rule: "Be consistent. Avoid stylistic variation." Pick one phrasing and use it everywhere -- suggest "each file must be 2 MB or less" for consistency.
| 2. **Upload a Recent Bank Statement** | ||
| * The file must match the entered bank details | ||
| * Accepted formats: PDF, PNG, JPEG | ||
| * Accepted formats: PDF, PNG, JPEG (2 MB max per file) |
There was a problem hiding this comment.
Deterministic writing / consistency: "2 MB max per file" differs from other files in this PR which use "each file must be 2 MB or less." Per HELPSITE_NAMING_CONVENTIONS.md: "Be consistent. Avoid stylistic variation." Use the same phrasing across all five articles.
| - If **you are** a Director/Senior Officer: | ||
| - Provide your full legal name, address, and ID. | ||
| - Upload proof of address and a valid form of identification (PDF, PNG, or JPEG only). | ||
| - Upload proof of address and a valid form of identification (PDF, PNG, or JPEG only, 2 MB max per file). |
There was a problem hiding this comment.
Deterministic writing / consistency: "2 MB max per file" differs from the phrasing used in other changed files in this PR (e.g., "Each file must be 2 MB or less" in the Australia and Canada docs). Per HELPSITE_NAMING_CONVENTIONS.md: "Be consistent. Avoid stylistic variation." Standardize to one phrasing across all five articles.
HelpDot Documentation ReviewOverall AssessmentThis PR adds a consistent "2 MB per file" size limit notice to all five global reimbursement articles, reflecting a frontend enforcement change. The changes are minimal, accurate, and applied uniformly across the affected files. Scores Summary
Key Findings
Recommendations
Files Reviewed
Overall Recommendation: ApproveThe changes are accurate, well-scoped, and do not introduce any governance violations. The minor phrasing variation is a non-blocking suggestion for consistency. Note: This review covers only the proposed changes in the diff. Pre-existing structural issues in these files (e.g., heading conventions, YAML metadata) are not part of this PR and were not scored. |
|
@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.76-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.77-3 🚀
|
Summary
Changed articles
Global-Reimbursement-Canada.md— added "Each file must be 2 MB or less" to accepted file types lineGlobal-Reimbursement-Europe.md— added size limit to both the acceptable documents section and the inline director upload instructionGlobal-Reimbursement-United-Kingdom.md— added size limit to both the bank statement upload format line and the acceptable documents sectionGlobal-Reimbursement-United-States.md— added size limit to both the acceptable documents section and the inline director upload instructionGlobal-Reimbursement-Australia.md— added accepted file types and size limit line (was previously missing file type info)