Skip to content

[No QA] Docs updates for E/A#88426 Add 2 MB file size limit to global reimbursement docs#90015

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-docsUpdateCorpayFileSizeLimit
May 16, 2026
Merged

[No QA] Docs updates for E/A#88426 Add 2 MB file size limit to global reimbursement docs#90015
stephanieelliott merged 1 commit into
mainfrom
claude-docsUpdateCorpayFileSizeLimit

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Summary

  • Adds the new 2 MB per-file size limit for document uploads to all global reimbursement help site articles (Canada, Europe, United Kingdom, United States, Australia)
  • This reflects the frontend enforcement added in Add 2MB per-file size limit for Corpay document uploads #88426, which validates individual file sizes during Corpay onboarding document uploads

Changed articles

  • Global-Reimbursement-Canada.md — added "Each file must be 2 MB or less" to accepted file types line
  • Global-Reimbursement-Europe.md — added size limit to both the acceptable documents section and the inline director upload instruction
  • Global-Reimbursement-United-Kingdom.md — added size limit to both the bank statement upload format line and the acceptable documents section
  • Global-Reimbursement-United-States.md — added size limit to both the acceptable documents section and the inline director upload instruction
  • Global-Reimbursement-Australia.md — added accepted file types and size limit line (was previously missing file type info)

Update all global reimbursement help site articles to document the new
2 MB per-file size limit for Corpay document uploads introduced in
#88426.

Co-authored-by: Maxence Coulibaly <madmax330@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label May 8, 2026
@stephanieelliott stephanieelliott marked this pull request as ready for review May 11, 2026 20:37
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds file size limit information ("2 MB") across five global reimbursement articles to match a new frontend enforcement from E/A#88426. The added text is factually clear and well-placed alongside existing file-type references. However, the changes use inconsistent phrasing across files, which conflicts with the Deterministic Writing Rule in the naming conventions.

Scores Summary

  • Readability: 9/10 - The added text is concise and immediately understandable in every instance. No ambiguity about the constraint.
  • AI Readiness: 8/10 - The information is clearly surfaced near file-type references, making it easy for AI retrieval to associate the size limit with the upload workflow. No metadata changes were needed for this scope.
  • Style Compliance: 6/10 - The same constraint is expressed in three distinct phrasings across (and sometimes within) the five files, violating the deterministic writing rule ("Be literal. Be exact. Be consistent. Avoid stylistic variation.").

Key Findings

Inconsistent phrasing (primary issue):
The 2 MB limit is communicated using three different wordings:

  1. Each file must be 2 MB or less. (standalone sentence -- Australia, Canada)
  2. (each file must be 2 MB or less) (parenthetical -- Europe, UK, US bullet lines)
  3. (2 MB max per file) or 2 MB max per file (compact parenthetical -- Europe, UK, US inline lines)

Per the governance docs, clarity and precision take precedence over prose style, and stylistic variation should be avoided. A single canonical phrasing should be chosen and applied everywhere.

Positive aspects:

  • The placement of the size limit information is logical in every file -- it appears directly alongside the file-type references where users will look.
  • The constraint is stated in plain, user-friendly language with no jargon.
  • No governance violations related to headings, metadata, or UI element references.

Recommendations

  1. Standardize on one phrasing. Pick either the sentence form or the parenthetical form and use it consistently across all five files. Suggested canonical phrasing:

    • Standalone context: Accepted file types: PDF, PNG, JPEG. Each file must be 2 MB or less.
    • Inline/parenthetical context: (PDF, PNG, or JPEG only, each file must be 2 MB or less)

    Avoid mixing "2 MB max per file" and "each file must be 2 MB or less" -- choose one.

  2. Minor: In files where the limit appears twice (Europe, UK, US), ensure both instances use the same wording to avoid within-article inconsistency.

Files Reviewed

File Status
Global-Reimbursement-Australia.md New standalone line added -- clean
Global-Reimbursement-Canada.md Appended to existing line -- clean
Global-Reimbursement-Europe.md Two changes, two different phrasings -- needs alignment
Global-Reimbursement-United-Kingdom.md Two changes, two different phrasings -- needs alignment
Global-Reimbursement-United-States.md Two changes, two different phrasings -- needs alignment

Review based on governance files: HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, TEMPLATE.md.

@stephanieelliott stephanieelliott self-assigned this May 12, 2026
@stephanieelliott stephanieelliott changed the title Docs updates for E/A#88426 Add 2 MB file size limit to global reimbursement docs [No QA] Docs updates for E/A#88426 Add 2 MB file size limit to global reimbursement docs May 15, 2026
@stephanieelliott stephanieelliott requested a review from a team May 15, 2026 02:34
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 15, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @jliexpensify

@melvin-bot melvin-bot Bot requested review from jliexpensify and removed request for a team May 15, 2026 02:34
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 15, 2026

@jliexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Copy Markdown
Contributor

@jliexpensify jliexpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- If **you are** a Director/Senior Officer:
- Provide your full legal name, address, and ID.
- Upload proof of address and a valid form of identification (PDF, PNG, or JPEG only).
- Upload proof of address and a valid form of identification (PDF, PNG, or JPEG only, 2 MB max per file).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deterministic writing / consistency: This PR uses three different phrasings for the same file size limit: "Each file must be 2 MB or less." (Australia, Canada), "2 MB max per file" (here, UK L49, US L60), and "each file must be 2 MB or less" (Europe L73, UK L73, US L30). Per HELPSITE_NAMING_CONVENTIONS.md Deterministic Writing Rule: "Be consistent. Avoid stylistic variation." Pick one phrasing and use it everywhere -- suggest "each file must be 2 MB or less" for consistency.

2. **Upload a Recent Bank Statement**
* The file must match the entered bank details
* Accepted formats: PDF, PNG, JPEG
* Accepted formats: PDF, PNG, JPEG (2 MB max per file)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deterministic writing / consistency: "2 MB max per file" differs from other files in this PR which use "each file must be 2 MB or less." Per HELPSITE_NAMING_CONVENTIONS.md: "Be consistent. Avoid stylistic variation." Use the same phrasing across all five articles.

- If **you are** a Director/Senior Officer:
- Provide your full legal name, address, and ID.
- Upload proof of address and a valid form of identification (PDF, PNG, or JPEG only).
- Upload proof of address and a valid form of identification (PDF, PNG, or JPEG only, 2 MB max per file).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deterministic writing / consistency: "2 MB max per file" differs from the phrasing used in other changed files in this PR (e.g., "Each file must be 2 MB or less" in the Australia and Canada docs). Per HELPSITE_NAMING_CONVENTIONS.md: "Be consistent. Avoid stylistic variation." Standardize to one phrasing across all five articles.

@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a consistent "2 MB per file" size limit notice to all five global reimbursement articles, reflecting a frontend enforcement change. The changes are minimal, accurate, and applied uniformly across the affected files.

Scores Summary

  • Readability: 9/10 - The added text is clear, concise, and immediately understandable. The phrasing varies slightly across files ("Each file must be 2 MB or less" vs. "2 MB max per file") which is acceptable given differing sentence contexts, though full uniformity would be ideal.
  • AI Readiness: 8/10 - The changes themselves do not affect headings, metadata, or structural elements. The file-size constraint is stated in plain language that AI systems can parse. Note: pre-existing issues in these files (e.g., forbidden headings like "Step 1" in Australia.md, missing internalScope in YAML frontmatter) are not introduced by this PR and are out of scope.
  • Style Compliance: 9/10 - The changes use exact, literal language consistent with the deterministic writing rule. File type references (PDF, PNG, JPEG) match existing conventions. No UI elements are misnamed or improperly formatted in the changed lines.

Key Findings

  • Consistency across files is strong. All five articles now communicate the 2 MB limit, which is the core goal of this PR.
  • Minor phrasing variation. Two forms are used: "Each file must be 2 MB or less" (standalone sentence or parenthetical) and "2 MB max per file" (inline parenthetical). Both are clear, but standardizing on one form would strengthen consistency. "Each file must be 2 MB or less" is more explicit and aligns better with the deterministic writing rule from the naming conventions.
  • Australia article adds the line as a new standalone paragraph, while other files modify existing lines. This is appropriate given the different pre-existing structures.
  • No governance violations are introduced by these changes.

Recommendations

  • Low priority: Consider standardizing on a single phrasing. "Each file must be 2 MB or less" is the clearest and most explicit option. The inline variants like "2 MB max per file" could be updated to match, but this is a minor polish item and should not block the PR.
  • No structural, metadata, or heading changes are needed for this PR since it only modifies informational content within existing sections.

Files Reviewed

  • Global-Reimbursement-Australia.md - New standalone line added; clean and clear.
  • Global-Reimbursement-Canada.md - Existing line extended; reads well.
  • Global-Reimbursement-Europe.md - Two lines updated with parenthetical and standalone forms; both clear.
  • Global-Reimbursement-United-Kingdom.md - Two lines updated; consistent with Europe article.
  • Global-Reimbursement-United-States.md - Two lines updated; consistent with Europe and UK articles.

Overall Recommendation: Approve

The changes are accurate, well-scoped, and do not introduce any governance violations. The minor phrasing variation is a non-blocking suggestion for consistency.

Note: This review covers only the proposed changes in the diff. Pre-existing structural issues in these files (e.g., heading conventions, YAML metadata) are not part of this PR and were not scored.

@stephanieelliott stephanieelliott merged commit 809efef into main May 16, 2026
28 of 30 checks passed
@stephanieelliott stephanieelliott deleted the claude-docsUpdateCorpayFileSizeLimit branch May 16, 2026 00:46
@melvin-bot melvin-bot Bot added the Emergency label May 16, 2026
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 16, 2026

@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.76-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.77-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Emergency HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants