Fix from:me search filter not applied when pasted by wildan-m · Pull Request #90094 · Expensify/App

wildan-m · 2026-05-09T03:13:29Z

Explanation of Change

Pasting or typing from:me (and the other user filters: to:me, assignee:me, payer:me, exporter:me, attendee:me) was broken — the me keyword didn't turn green and the filter wasn't applied, so results came back unfiltered.

It only worked when me was picked from the autocomplete dropdown, because that path stored a mapping from me to the current user's account ID. Pasting or typing skips that step, so the keyword stayed unresolved and the literal string me was sent to the backend.

This change recognizes me as a valid value for the user-based filters in two places: the highlighting check (so the keyword turns green) and the query submission step (so it's swapped for the current user's account ID before the request goes out).

Fixed Issues

$ #86603
PROPOSAL: #86603 (comment)

Tests

Preconditions:

Signed in with an account that has at least one unsubmitted expense in the workspace.

Go to https://dev.new.expensify.com:8082 (or staging).
Navigate to Reports > Expenses.
Copy this: type:expense-report action:submit from:me
Paste it on the search field "Search for something" and press Enter, or select the first highlighted option.
Verify me turns green and the system correctly applies the filter, returning only the expense reports submitted by the current user.

Verify that no errors appear in the JS console

Offline tests

Same as Tests. The fix is entirely client-side: me resolves to the current user's account ID before the query reaches the network layer, so the substitution and highlighting work identically online or offline.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Kapture.2026-05-09.at.14.34.35.mp4

Android: mWeb Chrome

Kapture.2026-05-09.at.14.32.48.mp4

iOS: Native

Kapture.2026-05-09.at.13.48.47.mp4

iOS: mWeb Safari

Kapture.2026-05-09.at.14.09.21.mp4

MacOS: Chrome / Safari

Kapture.2026-05-09.at.13.39.21.mp4

The 'me' keyword in search queries was only recognized when selected via autocomplete (which populates the substitution map). When pasted/typed directly, 'me' was not resolved to the current user's account ID because: 1. filterOutRangesWithCorrectValue did not check for CONST.SEARCH.ME, so the value was filtered out and never highlighted green. 2. getQueryWithSubstitutions had no fallback for 'me' when the substitution map was empty, so the literal string 'me' was sent to the backend instead of the user's account ID. Add CONST.SEARCH.ME check to the highlighting validation, and resolve 'me' to currentUserAccountID in getQueryWithSubstitutions when not found in the substitution map.

…e-search-filter

codecov · 2026-05-09T03:42:11Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...s/Search/SearchRouter/getQueryWithSubstitutions.ts	`96.96% <100.00%> (+0.30%)`	⬆️
src/libs/SearchAutocompleteUtils.ts	`58.72% <100.00%> (+0.58%)`	⬆️
...nts/Search/SearchPageHeader/useSearchPageInput.tsx	`60.29% <0.00%> (ø)`
...rc/components/Search/SearchRouter/SearchRouter.tsx	`46.15% <0.00%> (ø)`
... and 12 files with indirect coverage changes

melvin-bot · 2026-05-09T07:36:45Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

huult · 2026-05-12T04:38:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-05-12.at.12.14.18.mp4

Android: mWeb Chrome

Screen.Recording.2026-05-12.at.12.16.13.mp4

iOS: HybridApp

Screen.Recording.2026-05-12.at.12.20.59.mp4

iOS: mWeb Safari

Screen.Recording.2026-05-12.at.12.22.18.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-05-12.at.12.08.50.mp4

huult

LGTM.

heyjennahay

LGTM

melvin-bot · 2026-05-12T14:07:37Z

@justinpersaud looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2026-05-12T14:19:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-13T07:25:19Z

🚀 Deployed to staging by https://github.com/justinpersaud in version: 9.3.73-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

iOS

MelvinBot · 2026-05-13T07:30:02Z

Yes, help site changes are needed. The search operators article already documents me for from: and to:, but not for assignee: and attendee: — which this PR also fixes.

Draft PR created: #90428

Changes made:

Added me keyword documentation to attendee: filter (expense section)
Added me keyword documentation to assignee: filter (task section)

Note: The payer: and exporter: filters (also supported by this PR) are not currently documented in the help article at all — that's a pre-existing gap unrelated to this PR.

OSBotify · 2026-05-13T07:56:15Z

🚀 Deployed to staging by https://github.com/justinpersaud in version: 9.3.73-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-05-13T20:57:59Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.73-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot Bot assigned wildan-m May 9, 2026

wildan-m added 2 commits May 9, 2026 10:13

Merge remote-tracking branch 'upstream/main' into wildan/86603-from-m…

e39264d

…e-search-filter

Add unit tests for from:me search filter substitution and highlighting

c586091

wildan-m marked this pull request as ready for review May 9, 2026 07:36

wildan-m requested review from a team as code owners May 9, 2026 07:36

melvin-bot Bot requested review from heyjennahay and huult and removed request for a team May 9, 2026 07:36

wildan-m mentioned this pull request May 9, 2026

[Due for payment 2026-05-20] [$250] Reports - type:expense-report query not applied when from:me #86603

Open

7 tasks

huult approved these changes May 12, 2026

View reviewed changes

melvin-bot Bot requested a review from justinpersaud May 12, 2026 05:25

heyjennahay approved these changes May 12, 2026

View reviewed changes

justinpersaud approved these changes May 12, 2026

View reviewed changes

justinpersaud merged commit 56d3055 into Expensify:main May 12, 2026
51 of 56 checks passed

melvin-bot Bot added the Emergency label May 12, 2026

OSBotify mentioned this pull request May 13, 2026

Deploy Checklist: New Expensify 2026-05-13 #90410

Closed

82 tasks

MelvinBot mentioned this pull request May 13, 2026

[No QA] Docs updates for E/A#90094 Add me keyword to assignee and attendee filters #90428

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix from:me search filter not applied when pasted#90094

Fix from:me search filter not applied when pasted#90094
justinpersaud merged 3 commits into
Expensify:mainfrom
wildan-m:wildan/86603-from-me-search-filter

wildan-m commented May 9, 2026 •

edited

Loading

Uh oh!

codecov Bot commented May 9, 2026 •

edited by github-actions Bot

Loading

Uh oh!

melvin-bot Bot commented May 9, 2026

Uh oh!

huult commented May 12, 2026 •

edited

Loading

Uh oh!

huult left a comment

Uh oh!

heyjennahay left a comment

Uh oh!

Uh oh!

melvin-bot Bot commented May 12, 2026

Uh oh!

OSBotify commented May 12, 2026

Uh oh!

OSBotify commented May 13, 2026

Uh oh!

MelvinBot commented May 13, 2026

Uh oh!

OSBotify commented May 13, 2026

Uh oh!

OSBotify commented May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

wildan-m commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 9, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 9, 2026

Uh oh!

huult commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

heyjennahay left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot Bot commented May 12, 2026

Uh oh!

OSBotify commented May 12, 2026

Uh oh!

OSBotify commented May 13, 2026

Uh oh!

MelvinBot commented May 13, 2026

Uh oh!

OSBotify commented May 13, 2026

Uh oh!

OSBotify commented May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

wildan-m commented May 9, 2026 •

edited

Loading

codecov Bot commented May 9, 2026 •

edited by github-actions Bot

Loading

huult commented May 12, 2026 •

edited

Loading