Navigate to last accessed report after dismissing migrated user welcome modal by MelvinBot · Pull Request #90134 · Expensify/App

MelvinBot · 2026-05-10T21:52:08Z

Explanation of Change

After tapping "Let's go!" on the migrated user welcome modal, the user was landing on the search page instead of their report page. This was because onClose navigated to SEARCH_ROOT rather than finding the user's last accessed report.

This updates MigratedUserWelcomeModal.onClose to use findLastAccessedReport() (the same utility used by navigateAfterOnboarding and ReportsSplitNavigator) to find and navigate to the user's last accessed report. If no report is found, the modal simply dismisses without explicit navigation, letting the underlying navigation state handle routing.

Fixed Issues

$ #89900
PROPOSAL: #89900 (comment)

Tests

On Web, sign in with a new account on OldDot (staging.expensify.com)
Log out and sign in again with the same account to validate it with a magic code
Create a Collect Workspace
Create a new report
Add an expense to the report and submit it
Open the console and run the following snippet: NVP.set('tryNewDot', {classicRedirect: {dismissed: false, timestamp: '2024-01-07'}, nudgeMigration: {timestamp: '2024-01-07'}});
Launch the NewDot
Logged in with the same newly created account
Verify that the "Welcome to New Expensify!" modal is displayed (If the modal is not displayed, close the app then reopen the app)
Tap "Let's go!"
Verify you're redirected to the Report you created on Step 5

Verify that no errors appear in the JS console

Offline tests

QA Steps

On Web, sign in with a new account on OldDot (staging.expensify.com)
Log out and sign in again with the same account to validate it with a magic code
Create a Collect Workspace
Create a new report
Add an expense to the report and submit it
Open the console and run the following snippet: NVP.set('tryNewDot', {classicRedirect: {dismissed: false, timestamp: '2024-01-07'}, nudgeMigration: {timestamp: '2024-01-07'}});
Launch the NewDot
Logged in with the same newly created account
Verify that the "Welcome to New Expensify!" modal is displayed (If the modal is not displayed, close the app then reopen the app)
Tap "Let's go!"
Verify you're redirected to the Report you created on Step 5

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-05-10T22:01:09Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/MigratedUserWelcomeModal.tsx	`0.00% <0.00%> (ø)`
... and 7 files with indirect coverage changes

eVoloshchak · 2026-05-24T13:57:40Z

@MelvinBot, pull the latest main

…me modal Co-authored-by: Eugene Voloshchak <eVoloshchak@users.noreply.github.com>

MelvinBot · 2026-05-24T14:00:26Z

Pulled the latest main into the branch. The branch was rebased onto the current main with the PR changes re-applied on top.

eVoloshchak · 2026-05-24T22:59:37Z

On Web, sign in with a new account on OldDot (staging.expensify.com)
Log out and sign in again with the same account to validate it with a
magic code
Create a Collect Workspace
Create a new report
Add an expense to the report and submit it
Open the console and run the following snippet: NVP.set('tryNewDot', {classicRedirect: {dismissed: false, timestamp: '2024-01-07'}, nudgeMigration: {timestamp: '2024-01-07'}});
Launch the NewDot
Logged in with the same newly created account
Verify that the "Welcome to New Expensify!" modal is displayed (If the modal is not displayed, close the app then reopen the app)
Tap "Let's go!"
Verify you're redirected to the Report you created on Step 7

@MelvinBot, populate the Tests and QA Tests sections of the PR Author Checklist with these tests

eVoloshchak · 2026-05-24T23:00:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

video_2026-05-25_00-59-58.mp4

Android: mWeb Chrome

Screen.Recording.2026-05-25.at.00.44.22.mov

iOS: HybridApp

Screen.Recording.2026-05-25.at.00.41.27.mov

iOS: mWeb Safari

Screen.Recording.2026-05-25.at.00.38.47.mov

MacOS: Chrome / Safari

Screen.Recording.2026-05-25.at.00.35.07.mov

MelvinBot · 2026-05-24T23:02:43Z

Updated the Tests and QA Steps sections with the provided test steps.

eVoloshchak · 2026-05-24T23:03:24Z

@MelvinBot, check off every checkbox in the PR author checklist

eVoloshchak

LGTM!
@MelvinBot, mark this as ready for review

melvin-bot · 2026-05-24T23:04:16Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #89900 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

MelvinBot · 2026-05-24T23:05:43Z

Done — all checkboxes in the PR author checklist have been checked off.

MelvinBot · 2026-05-24T23:08:27Z

PR has been marked as ready for review. ✅

melvin-bot · 2026-05-24T23:08:28Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-05-25T10:43:35Z

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-05-25T10:45:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-25T10:48:58Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90134.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-64be4e7367d-393ba1f-004606076c3bbbe67360ea5a5e993d4e65461f8c/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-64be4e7-393ba1f-c87e6d03e0571fef8623b5c203b2bfc3ea99b833/index.html

Web 🕸️
https://90134.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-25T11:22:38Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.81-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-05-25T11:24:43Z

No help site changes are required for this PR.

This PR fixes a navigation bug where dismissing the "Welcome to New Expensify!" modal navigated to the search page instead of the user's last accessed report. The change is purely internal (swapping buildCannedSearchQuery navigation for findLastAccessedReport) and does not affect any documented features, workflows, or UI labels in the help site articles.

OSBotify · 2026-05-25T22:35:40Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

trjExpensify · 2026-05-28T01:34:52Z

@grgia @eVoloshchak migrated users after dismissing the modal intentionally always land on the Spend page for their first session as it is more familiar for them.

Looks like I was assigned to review from product, but I was out of office Monday, so didn't get a chance to before this was merged. Can we CP a revert of this in the morning, please? We're actively nudging at the moment and it's disruptive. CC: @mountiny as I believe you're the deployer. 👍

MelvinBot assigned eVoloshchak May 10, 2026

MelvinBot requested a review from a team May 10, 2026 21:52

MelvinBot mentioned this pull request May 10, 2026

[$250] OldDot transition- user is not directed to Report page after tap "Lets go!" #89900

Open

7 tasks

Navigate to last accessed report after dismissing migrated user welco…

53f85da

…me modal Co-authored-by: Eugene Voloshchak <eVoloshchak@users.noreply.github.com>

MelvinBot force-pushed the claude-migratedUserWelcomeModalNavigation branch from f7482db to 53f85da Compare May 24, 2026 14:00

eVoloshchak approved these changes May 24, 2026

View reviewed changes

melvin-bot Bot requested a review from grgia May 24, 2026 23:04

MelvinBot marked this pull request as ready for review May 24, 2026 23:08

MelvinBot requested a review from a team as a code owner May 24, 2026 23:08

melvin-bot Bot requested a review from eVoloshchak May 24, 2026 23:08

melvin-bot Bot requested review from trjExpensify and removed request for a team May 24, 2026 23:08

melvin-bot Bot removed the request for review from a team May 24, 2026 23:08

eVoloshchak approved these changes May 25, 2026

View reviewed changes

grgia approved these changes May 25, 2026

View reviewed changes

grgia merged commit 64be4e7 into main May 25, 2026
55 of 57 checks passed

grgia deleted the claude-migratedUserWelcomeModalNavigation branch May 25, 2026 10:37

OSBotify mentioned this pull request May 25, 2026

Deploy Checklist: New Expensify 2026-05-25 #91591

Closed

36 tasks

eVoloshchak mentioned this pull request May 28, 2026

[CP Staging] Revert "Navigate to last accessed report after dismissing migrated user welcome modal" #91934

Merged

Conversation

MelvinBot commented May 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 10, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

eVoloshchak commented May 24, 2026

Uh oh!

MelvinBot commented May 24, 2026

Uh oh!

eVoloshchak commented May 24, 2026

Uh oh!

eVoloshchak commented May 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented May 24, 2026

Uh oh!

eVoloshchak commented May 24, 2026

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 24, 2026

Uh oh!

MelvinBot commented May 24, 2026

Uh oh!

MelvinBot commented May 24, 2026

Uh oh!

melvin-bot Bot commented May 24, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 25, 2026

Uh oh!

OSBotify commented May 25, 2026

Uh oh!

github-actions Bot commented May 25, 2026

Uh oh!

OSBotify commented May 25, 2026

Uh oh!

MelvinBot commented May 25, 2026

Uh oh!

OSBotify commented May 25, 2026

Uh oh!

trjExpensify commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MelvinBot commented May 10, 2026 •

edited

Loading

codecov Bot commented May 10, 2026 •

edited by github-actions Bot

Loading

eVoloshchak commented May 24, 2026 •

edited

Loading