[No QA] Use CreditCardWithPlane icon and Central Invoicing tooltip for travel invoicing expenses#90277
Merged
Merged
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…ingExpenseRowIcon
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
changed the title
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://09b18316.helpdot.pages.dev ⚡️ Updated articles: |
📲 Install BuildsAndroid
|
Contributor
Author
|
|
52 tasks
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 6086836e..18d0cbe2 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -8228,6 +8228,7 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
companyCard: 'Firmenkarte',
expensifyCard: 'Expensify Karte',
centralInvoicing: 'Zentrale Rechnungsstellung',
+ travelCard: 'Reisekarte',
},
distance: {
addStop: 'Stopp hinzufügen',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 6f62d178..0f4251df 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -1687,10 +1687,8 @@ const translations: TranslationDeepObject<typeof en> = {
backdropLabel: 'Fondo del Modal',
},
nextStep: {
- /* eslint-disable @typescript-eslint/no-unused-vars */
message: {
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_ADD_TRANSACTIONS]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> añadas gastos.`;
@@ -1701,7 +1699,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_SUBMIT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> envíes los gastos.`;
@@ -1713,7 +1710,6 @@ const translations: TranslationDeepObject<typeof en> = {
},
[CONST.NEXT_STEP.MESSAGE_KEY.NO_FURTHER_ACTION]: (_actor, _actorType, _eta, _etaType) => `¡No se requiere ninguna acción adicional!`,
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_FOR_SUBMITTER_ACCOUNT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> añadas una cuenta bancaria.`;
@@ -1728,7 +1724,6 @@ const translations: TranslationDeepObject<typeof en> = {
if (eta) {
formattedETA = etaType === CONST.NEXT_STEP.ETA_TYPE.DATE_TIME ? ` el ${eta} de cada mes` : ` ${eta}`;
}
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que tus gastos se envíen automáticamente${formattedETA}.`;
@@ -1739,7 +1734,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_FIX_ISSUES]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> soluciones ellos problemas.`;
@@ -1750,7 +1744,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_APPROVE]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> apruebes los gastos.`;
@@ -1761,7 +1754,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_EXPORT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> exportes este informe.`;
@@ -1772,7 +1764,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_PAY]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> pagues los gastos.`;
@@ -1783,7 +1774,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_FOR_POLICY_BANK_ACCOUNT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> termines de configurar una cuenta bancaria de empresa.`;
@@ -1803,7 +1793,6 @@ const translations: TranslationDeepObject<typeof en> = {
[CONST.NEXT_STEP.MESSAGE_KEY.SUBMITTING_TO_SELF]: (_actor, _actorType, _eta, _etaType) =>
`¡Ups! Parece que estás enviando el informe a <strong>ti mismo</strong>. Aprobar tus propios informes está <strong>prohibido</strong> por tu espacio de trabajo. Por favor, envía este informe a otra persona o contacta a tu administrador para cambiar la persona a la que lo envías.`,
[CONST.NEXT_STEP.MESSAGE_KEY.REJECTED_REPORT]: (actor, actorType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Este informe fue rechazado. Esperando a que <strong>tú</strong> corrijas los problemas y lo vuelvas a enviar manualmente.`;
@@ -2458,7 +2447,6 @@ ${amount} para ${merchant} - ${date}`,
two: 'º',
few: 'º',
other: 'º',
- /* eslint-disable @typescript-eslint/naming-convention */
'1': 'Primero',
'2': 'Segundo',
'3': 'Tercero',
@@ -2469,7 +2457,6 @@ ${amount} para ${merchant} - ${date}`,
'8': 'Octavo',
'9': 'Noveno',
'10': 'Décimo',
- /* eslint-enable @typescript-eslint/naming-convention */
},
},
approverInMultipleWorkflows: 'Este miembro ya pertenece a otro flujo de aprobación. Cualquier actualización aquí se reflejará allí también.',
@@ -6923,7 +6910,6 @@ ${amount} para ${merchant} - ${date}`,
restrictedDescription: 'Sólo las personas en tu espacio de trabajo pueden encontrar esta sala',
privateDescription: 'Sólo las personas que están invitadas a esta sala pueden encontrarla',
publicDescription: 'Cualquier persona puede unirse a esta sala',
- // eslint-disable-next-line @typescript-eslint/naming-convention
public_announceDescription: 'Cualquier persona puede unirse a esta sala',
createRoom: 'Crea una sala de chat',
roomAlreadyExistsError: 'Ya existe una sala con este nombre',
@@ -6943,7 +6929,6 @@ ${amount} para ${merchant} - ${date}`,
restricted: 'Espacio de trabajo',
private: 'Privada',
public: 'Público',
- // eslint-disable-next-line @typescript-eslint/naming-convention
public_announce: 'Anuncio Público',
},
},
@@ -7258,7 +7243,6 @@ ${amount} para ${merchant} - ${date}`,
updatedDefaultTitle: (newDefaultTitle, oldDefaultTitle) => `cambió la fórmula personalizada del nombre del informe a "${newDefaultTitle}" (previamente "${oldDefaultTitle}")`,
updatedOwnership: (oldOwnerEmail, oldOwnerName, policyName) => `asumió la propiedad del espacio de trabajo ${policyName} de ${oldOwnerName} (${oldOwnerEmail})`,
updatedAutoHarvesting: (enabled) => `${enabled ? 'habilitó' : 'deshabilitó'} el envío programado`,
- // eslint-disable-next-line @typescript-eslint/max-params
updatedIndividualBudgetNotification: (
budgetAmount,
budgetFrequency,
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index b98594c3..51139e4e 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -8250,6 +8250,7 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
companyCard: 'Carte d’entreprise',
expensifyCard: 'Carte Expensify',
centralInvoicing: 'Facturation centralisée',
+ travelCard: 'Carte de voyage',
},
distance: {
addStop: 'Ajouter un arrêt',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 0b66570b..058aa38a 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -8219,6 +8219,7 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
companyCard: 'Carta aziendale',
expensifyCard: 'Carta Expensify',
centralInvoicing: 'Fatturazione centralizzata',
+ travelCard: 'Carta Viaggio',
},
distance: {
addStop: 'Aggiungi fermata',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 1683c08d..d90d8c89 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -8118,6 +8118,7 @@ ${reportName}
companyCard: '会社カード',
expensifyCard: 'Expensify カード',
centralInvoicing: '集中請求',
+ travelCard: 'トラベルカード',
},
distance: {
addStop: '経由地を追加',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index c6282c9c..8449bd64 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -8191,6 +8191,7 @@ er bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
companyCard: 'Bedrijfskaart',
expensifyCard: 'Expensify Kaart',
centralInvoicing: 'Gecentraliseerde facturatie',
+ travelCard: 'Reiskaart',
},
distance: {
addStop: 'Stop toevoegen',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 5851baeb..907beeb4 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -8182,6 +8182,7 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
companyCard: 'Karta firmowa',
expensifyCard: 'Karta Expensify',
centralInvoicing: 'Centralne fakturowanie',
+ travelCard: 'Karta podróżna',
},
distance: {
addStop: 'Dodaj przystanek',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 7363495a..0ec02994 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -8185,6 +8185,7 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
companyCard: 'Cartão corporativo',
expensifyCard: 'Cartão Expensify',
centralInvoicing: 'Faturamento centralizado',
+ travelCard: 'Cartão de viagem',
},
distance: {
addStop: 'Adicionar parada',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index bbdbba71..77282193 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -7982,6 +7982,7 @@ ${reportName}
companyCard: '公司卡',
expensifyCard: 'Expensify 卡',
centralInvoicing: '集中开票',
+ travelCard: '旅行卡',
},
distance: {
addStop: '添加站点',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
melvin-bot
Bot
requested review from
dannymcclain,
heyjennahay and
rojiphil
and removed request for
a team
|
@dannymcclain @rojiphil One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
@rojiphil @heyjennahay please ignore the ping 👍 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d5f6994c8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
rlinoz
previously approved these changes
May 12, 2026
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
rlinoz
approved these changes
May 12, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
82 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.73-0 🚀
Bundle Size Analysis (Sentry): |
Contributor
|
No help site changes required. This PR adds a visual-only distinction: a credit-card-with-plane icon and "Travel Card" tooltip for travel-invoicing expenses in transaction rows. After reviewing the help site articles under
|
Contributor
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.73-0 🚀
Bundle Size Analysis (Sentry): |
Contributor
|
Update: On deeper review, I found one help site article that should be updated. The Central-Billing.md article covers travel card setup, booking, and reconciliation but never explains how travel card expenses are visually distinguished in the expense list. Since this PR introduces the credit-card-with-plane icon and "Travel Card" tooltip, users reading the Central Billing article should know how to identify these expenses. Draft PR created: #90436 (labeled The change adds a FAQ entry: "How can I identify Central Billing expenses in a report?" explaining the distinct icon and label. |
Contributor
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.73-4 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When a user opens a report today, expenses paid on a travel-invoicing card look identical to expenses paid on a regular Expensify card — same Expensify Card icon, same "Expensify Card" tooltip. There's no way to tell from the expense row which spend was travel-related.
This change gives travel-invoicing expense rows their own credit-card-with-plane icon and a "Central invoicing" tooltip, so users can distinguish travel spend from regular card spend at a glance.
Fixed Issues
$ #90081
PROPOSAL: N/A
Tests
Offline tests
Same as tests — icon selection is local, no network dependency.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos