Fix navigation to new workspace#90310
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
7eb1f2c to
f365b47
Compare
Push the new workspace under the active RHP so the dismiss animation reveals it directly instead of routing through WORKSPACES_LIST. Update the Escape handler to locate WORKSPACE_NAVIGATOR inside TAB_NAVIGATOR and use goBack() so backBehavior="fullHistory" returns to the previously focused tab.
f365b47 to
71ad713
Compare
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@ZhenjaHorbach all yours |
|
Will check tomorrow morning! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-05-14.12.12.20.movAndroid: mWeb Chrome2026-05-14.12.11.41.moviOS: HybridApp2026-05-14.12.12.20.moviOS: mWeb Safari2026-05-14.12.11.41.movMacOS: Chrome / Safari2026-05-14.12.09.55.mov |
|
Should we fix the mobile also? 2026-05-14.12.10.31.mov |
|
But desktop web works well! |
|
@ZhenjaHorbach I think that is ok now, lets wait for someone to complain about this first before doing anything about it |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.74-7 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. The changes here are purely internal navigation fixes — they update the escape key handler and add a helper to push a newly created workspace into the navigator stack so users land directly on the workspace details page instead of briefly seeing the workspaces list. The actual user-facing steps for creating a workspace (documented in |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.74-7 🚀
|
|
Hi @sumo-slonik. QA team failed this PR on iOS with an original issue 1778892674647.ScreenRecording_05-15-2026_19-49-36_1.mp4 |
We hoped no one would notice 😅 |
Explanation of Change
Creating a new workspace now lands directly on its details page instead of routing through the workspaces list. Escape handling in the workspace tab is updated to work with the tab-nested
WORKSPACE_NAVIGATOR.Fixed Issues
$ #88932
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-05-13.at.15.24.47.mov