Exclude built-in title field from duplicate workspace report fields count by MelvinBot · Pull Request #90340 · Expensify/App

MelvinBot · 2026-05-12T13:21:42Z

Explanation of Change

The report fields count on the duplicate workspace confirmation page (WorkspaceDuplicateSelectFeaturesForm.tsx) included the built-in text_title field, which is always present in policy.fieldList and has no pendingAction. This caused the count to be inflated by 1 — showing 1 even when all custom report fields were pending deletion offline.

This adds a fieldID !== CONST.REPORT_FIELD_TITLE_FIELD_ID filter to exclude the built-in title field, matching the existing behavior in WorkspaceReportsPage.tsx which already filters it out.

Fixed Issues

$ #89716
PROPOSAL: #89716 (comment)

Tests

Disable Report fields in a workspace (Workspace > Reports).
Duplicate the workspace.
Verify that Report fields is disabled in the duplicated workspace.
Enable Report fields in the workspace (Workspace > Reports).
Duplicate the workspace.
Verify that Report fields is enabled in the duplicated workspace.

Offline tests

Disable Report fields in a workspace (Workspace > Reports).
Duplicate the workspace.
Verify that Report fields is disabled in the duplicated workspace.
Enable Report fields in the workspace (Workspace > Reports).
Duplicate the workspace.
Verify that Report fields is enabled in the duplicated workspace.

QA Steps

Disable Report fields in a workspace (Workspace > Reports).
Duplicate the workspace.
Verify that Report fields is disabled in the duplicated workspace.
Enable Report fields in the workspace (Workspace > Reports).
Duplicate the workspace.
Verify that Report fields is enabled in the duplicated workspace.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

… workspace confirmation page The report fields count on the duplicate workspace confirmation page includes the built-in text_title field, which should be excluded (matching WorkspaceReportsPage behavior). This causes the count to show 1 even when all custom report fields have been pending-deleted offline. Co-authored-by: Sobit Neupane <sobitneupane@users.noreply.github.com>

codecov · 2026-05-12T13:31:44Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/actions/Policy/Policy.ts	`69.40% <ø> (-0.02%)`	⬇️
... and 1317 files with indirect coverage changes

sobitneupane

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2026-05-15.at.21.03.21.mov

sobitneupane · 2026-05-15T15:32:15Z

@MelvinBot When I disable the Report fields in offline and then duplicate the workspace, the Report fields become enabled in the duplicated workspace. Could you please ensure that the Report fields remain disabled in the duplicated workspace as well?

…plicate form When report fields are disabled offline, the toggle should not appear in the duplication features form, matching the pattern used by distanceRates and invoices. Co-authored-by: Sobit Neupane <sobitneupane@users.noreply.github.com>

MelvinBot · 2026-05-15T15:38:15Z

Fixed — the duplication form now also checks policy?.areReportFieldsEnabled before showing the "Reports" toggle, matching the pattern already used by distance rates (areDistanceRatesEnabled) and invoices (areInvoicesEnabled).

When report fields are disabled offline, the toggle won't appear in the feature selection list, so parts.reports will be false and the duplicated workspace will correctly have report fields disabled.

sobitneupane · 2026-05-15T16:39:43Z

@MelvinBot This will block users from copying Reports entirely. Should we instead set areReportFieldsEnabled to sourcePolicy?.areReportFieldsEnabled in buildOptimisticDuplicatePolicy when isReportsFeatureSelected is true?

App/src/libs/actions/Policy/Policy.ts

Line 3295 in 8f3ca19

areReportFieldsEnabled: isReportsFeatureSelected,

Instead of hiding the Reports toggle when areReportFieldsEnabled is false (which blocks copying Reports entirely), preserve the source policy's areReportFieldsEnabled value in buildOptimisticDuplicatePolicy. Co-authored-by: Sobit Neupane <sobitneupane@users.noreply.github.com>

MelvinBot · 2026-05-15T16:43:28Z

Good call — reverted the form change and instead updated buildOptimisticDuplicatePolicy to preserve the source policy's areReportFieldsEnabled value when reports are selected, rather than always setting it to true.

MelvinBot · 2026-05-15T16:54:10Z

All CI checks are passing. The only "failing" check is PR Author Checklist, which is an informational reminder to complete the checklist — not a code issue. All other checks (ESLint, Prettier, typecheck, all 8 test jobs, builds, spellcheck, storybook, CLA, etc.) pass successfully.

MelvinBot · 2026-05-15T17:02:14Z

The perf-tests failure is unrelated to this PR's changes.

Failure: [ReportActionCompose] should render Composer with text input interactions — render count exceeded allowed deviation by 1.

Why it's unrelated: This PR only touches Policy.ts and WorkspaceDuplicateSelectFeaturesForm.tsx, which have no connection to ReportActionCompose. The same perf-tests check is also failing on multiple other unrelated branches today, confirming this is a pre-existing/flaky issue.

The only other failing check is the PR Author Checklist, which is informational. All code-related checks (ESLint, Prettier, typecheck, all 8 test jobs, builds) pass.

sobitneupane · 2026-05-17T13:45:33Z

Sample fieldList
{
    "expensify_field_id_REPORT_FIELD_1": {
        "fieldID": "field_id_REPORT_FIELD_1",
        "name": "report_field_1",
        ...
    },
    "expensify_field_id_REPORT_FIELD_2": {
        "fieldID": "field_id_REPORT_FIELD_2",
        "name": "report_field_2",
        ...
    },
    "text_title": {
        "defaultValue": "{report:total} | {report:total:usd} | {report:total:NPR} | 102",
        "fieldID": "text_title",
        "name": "title",
        ...
    }
}

@JS00001

If we ignore text_title, the report title won't be passed when duplicating the workspace (if there are no other report fields).
If we include it, it inflates the report field count by 1, even though it's not really a report field.

One possible approach it to treat text_title separately in the UI and show something like:
"Report title, 2 report fields" in the subtext

What do you think?

JS00001 · 2026-05-18T19:23:08Z

One possible approach it to treat text_title separately in the UI and show something like:
"Report title, 2 report fields" in the subtext

Can we just make it count the report fields & exclude the title? Since thats not a field?

JS00001 · 2026-05-18T19:24:20Z

        areRulesEnabled: isRulesFeatureSelected,
        areWorkflowsEnabled: isWorkflowsFeatureSelected,
-        areReportFieldsEnabled: isReportsFeatureSelected,
+        areReportFieldsEnabled: isReportsFeatureSelected ? sourcePolicy?.areReportFieldsEnabled : false,


why is this needed?

The duplicated workspace will have report fields enabled regardless of the original workspace state if we don’t include this change.

MelvinBot · 2026-05-18T19:29:15Z

The perf-tests failure is unrelated to this PR's changes.

Failing test: [ReportActionCompose] should render Composer with text input interactions — render count exceeded allowed deviation by 1.

Why it's unrelated: This PR only modifies Policy.ts and WorkspaceDuplicateSelectFeaturesForm.tsx (workspace duplication logic). The failing test is for ReportActionCompose, a completely different component with no connection to the changed files.

Evidence: The same Reassure perf test is failing across many unrelated PRs right now (e.g., branches fix/89545, use-shared-country-zip-regex, 89302-import-spreadsheet-modal-refactor, and others). This is a known flaky/pre-existing failure in the test suite.

No code fix is needed on this PR for this check.

sobitneupane · 2026-05-19T17:13:47Z

Can we just make it count the report fields & exclude the title? Since thats not a field?

@JS00001 We can do that, but if we go that route, the report title won’t be included when duplicating the workspace in cases where there are no other report fields. However, if there is at least one report field, the report title will be included, which leads to inconsistent behavior.

MelvinBot · 2026-05-19T17:15:53Z

The perf-tests failure is unrelated to this PR.

Failing test: [ReportActionCompose] should render Composer with text input interactions — render count exceeded allowed deviation by 1.

Why it's unrelated: This PR only changes Policy.ts and WorkspaceDuplicateSelectFeaturesForm.tsx, neither of which is connected to ReportActionCompose. This is a pre-existing flaky perf regression.

The other two failing checks (PR Author Checklist and PR Reviewer Checklist) are checklist validations, not code issues.

sobitneupane · 2026-05-22T14:12:56Z

@JS00001 Just a gentle bump on these comments when you get a chance: #90340 (comment) and #90340 (comment). Thanks!

JS00001 · 2026-05-22T14:55:23Z

We can do that, but if we go that route, the report title won’t be included when duplicating the workspace in cases where there are no other report fields. However, if there is at least one report field, the report title will be included, which leads to inconsistent behavior.

Can you explain this more please?

sobitneupane · 2026-05-23T15:41:17Z

Sample fieldList
{
    "expensify_field_id_REPORT_FIELD_1": {
        "fieldID": "field_id_REPORT_FIELD_1",
        "name": "report_field_1",
        ...
    },
    "expensify_field_id_REPORT_FIELD_2": {
        "fieldID": "field_id_REPORT_FIELD_2",
        "name": "report_field_2",
        ...
    },
    "text_title": {
        "defaultValue": "{report:total} | {report:total:usd} | {report:total:NPR} | 102",
        "fieldID": "text_title",
        "name": "title",
        ...
    }
}

When we ignore the text_title field from the fieldList, there are still two report fields present (in sample fieldList above). As a result, during workspace duplication, the user sees the option to select the Reports feature (as shown in the screenshot below), and all three items(including text_title) in the sample fieldList are passed to the duplicated workspace.

However, if text_title is the only field (i.e., the user hasn’t added any report fields), the Reports feature is not shown on the "Select features to copy" screen and the report configuration is not passed to the duplicated workspace.

JS00001 · 2026-05-25T17:00:29Z

@sobitneupane lets include it as a report field then

sobitneupane · 2026-05-26T12:46:30Z

@JS00001 This is the existing behavior. For report title and 2 report fields, we currently display "3 report fields".

The separate issue we are trying to address here is that a duplicated workspace has report fields enabled regardless of the original workspace's state However, this wasn't reported in the original issue.

Should we proceed with only this latter change?

JS00001 · 2026-05-26T13:01:03Z

Yeah lets ignore the report title issues then

sobitneupane · 2026-05-26T13:23:27Z

+    const reportFields =
+        Object.values(getReportFieldsByPolicyID(policyID) ?? {}).filter(
+            (field) => field.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && field.fieldID !== CONST.REPORT_FIELD_TITLE_FIELD_ID,
+        ).length ?? 0;


@MelvinBot Let's revert the change made in WorkspaceDuplicateSelectFeaturesForm. We decided to include CONST.REPORT_FIELD_TITLE_FIELD_ID in the reportFields.

Per reviewer feedback, the built-in title field should be included in the reportFields count on the duplicate workspace confirmation page. Co-authored-by: Sobit Neupane <sobitneupane@users.noreply.github.com>

MelvinBot · 2026-05-26T13:26:34Z

Reverted the REPORT_FIELD_TITLE_FIELD_ID filter in WorkspaceDuplicateSelectFeaturesForm — reportFields now includes the built-in title field again.

MelvinBot · 2026-05-26T13:27:00Z

The checks on this PR are not failing — the latest run (triggered a few minutes ago) is still in progress with all checks queued or running.

The only historical failures on this branch are PR Author Checklist and PR Reviewer Checklist, which track manual checkbox completion in the PR description and are not fixable via code changes.

If checks fail once the current run completes, feel free to tag me again and I'll investigate.

sobitneupane · 2026-05-26T13:31:37Z

@MelvinBot Please merge main

…xcludeTitleFieldFromDuplicateWSCount Co-authored-by: Sobit Neupane <sobitneupane@users.noreply.github.com>

MelvinBot · 2026-05-26T13:42:42Z

Merged main into this branch.

MelvinBot · 2026-05-26T13:43:14Z

The ESLint failure is unrelated to this PR.

Error: 'getKeywordQueryWithCurrentSearchContext' is defined but never used in tests/unit/Search/SearchQueryUtilsTest.ts:20

Why it's unrelated: This PR only changes src/libs/actions/Policy/Policy.ts. The lint error is in a Search test file that imports getKeywordQueryWithCurrentSearchContext but never uses it — this same issue exists on main.

MelvinBot · 2026-05-26T13:43:43Z

⚠️ MelvinBot CI Fix Loop Detected

MelvinBot has made 5 consecutive commits trying to fix CI failures. Automatic CI fix dispatches are now paused for this PR.

Next steps: A human should review the recent commits and resolve the conflicting CI errors manually.

sobitneupane · 2026-05-26T13:44:51Z

@MelvinBot Please complete the author checklist with all items checked (no N/A). I have manually verified that all the items can be checked.

Also, update the Tests, Offline tests and QA steps with the following:

Disable Report fields in a workspace (Workspace > Reports).
Duplicate the workspace.
Verify that Report fields is disabled in the duplicated workspace.
Enable Report fields in the workspace (Workspace > Reports).
Duplicate the workspace.
Verify that Report fields is enabled in the duplicated workspace.

MelvinBot · 2026-05-26T13:46:04Z

No code fix needed — the test (job 3) failure is a CI infrastructure issue, not a code problem. GitHub Actions failed to download the useblacksmith/checkout action after 3 retries:

Error while copying content to a stream.
Failed to download archive '...useblacksmith/checkout...' after 3 attempts.

The other failing check (PR Author Checklist) is the manual checkbox check.

To resolve: Re-run the failed job, or push an empty change to trigger a new CI run. The remaining test jobs are still in progress and may pass.

MelvinBot · 2026-05-26T13:47:16Z

Updated the PR body:

All author checklist items are now checked
Tests, Offline tests, and QA steps updated with the report fields enable/disable duplication steps

sobitneupane · 2026-05-27T07:22:32Z

@JS00001 For the issue I mentioned above ("a duplicated workspace has report fields enabled regardless of the original workspace's state"), the backend currently always set areReportFieldsEnabled to false during duplication, regardless of the original workspace's state. So, we also need to make changes in the backend.

JS00001 · 2026-05-27T13:11:33Z

the backend currently always set areReportFieldsEnabled to false during duplication, regardless of the original workspace's state. So, we also need to make changes in the backend.

So we want the report fields to be enabled or disabled based on the previous workspace? OR based on the user selection?

JS00001 · 2026-05-27T13:43:26Z

PR open for this here: https://github.com/Expensify/Web-Expensify/pull/53201/

sobitneupane · 2026-05-27T14:26:16Z

So we want the report fields to be enabled or disabled based on the previous workspace? OR based on the user selection?

If the user has selected "Reports" feature in "Select features to copy" (isReportsFeatureSelected is true), then the report fields should be enabled or disabled based on the previous workspace. If isReportsFeatureSelected is false, report fields should remain disabled.

JS00001 · 2026-05-27T14:28:21Z

Agreed, sounds good

MelvinBot assigned sobitneupane May 12, 2026

MelvinBot requested a review from a team May 12, 2026 13:21

MelvinBot mentioned this pull request May 12, 2026

[$250] Pending deleted report field data is counted in confirmation page of duplicate WS #89716

Open

7 tasks

sobitneupane reviewed May 15, 2026

View reviewed changes

JS00001 requested changes May 18, 2026

View reviewed changes

sobitneupane reviewed May 26, 2026

View reviewed changes

Revert: include REPORT_FIELD_TITLE_FIELD_ID in reportFields count

0378965

Per reviewer feedback, the built-in title field should be included in the reportFields count on the duplicate workspace confirmation page. Co-authored-by: Sobit Neupane <sobitneupane@users.noreply.github.com>

Merge branch 'main' of https://github.com/Expensify/App into claude-e…

4305648

…xcludeTitleFieldFromDuplicateWSCount Co-authored-by: Sobit Neupane <sobitneupane@users.noreply.github.com>

Conversation

MelvinBot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 12, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sobitneupane left a comment

Choose a reason for hiding this comment

Screenshots/Videos

Uh oh!

sobitneupane commented May 15, 2026

Uh oh!

MelvinBot commented May 15, 2026

Uh oh!

sobitneupane commented May 15, 2026

Uh oh!

MelvinBot commented May 15, 2026

Uh oh!

MelvinBot commented May 15, 2026

Uh oh!

MelvinBot commented May 15, 2026

Uh oh!

sobitneupane commented May 17, 2026

Uh oh!

JS00001 commented May 18, 2026

Uh oh!

JS00001 May 18, 2026

Choose a reason for hiding this comment

Uh oh!

sobitneupane May 19, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented May 18, 2026

Uh oh!

sobitneupane commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MelvinBot commented May 19, 2026

Uh oh!

sobitneupane commented May 22, 2026

Uh oh!

JS00001 commented May 22, 2026

Uh oh!

sobitneupane commented May 23, 2026

Uh oh!

JS00001 commented May 25, 2026

Uh oh!

sobitneupane commented May 26, 2026

Uh oh!

JS00001 commented May 26, 2026

Uh oh!

sobitneupane May 26, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented May 26, 2026

Uh oh!

MelvinBot commented May 26, 2026

Uh oh!

sobitneupane commented May 26, 2026

Uh oh!

MelvinBot commented May 26, 2026

Uh oh!

MelvinBot commented May 26, 2026

Uh oh!

MelvinBot commented May 26, 2026

Uh oh!

sobitneupane commented May 26, 2026

Uh oh!

MelvinBot commented May 26, 2026

Uh oh!

MelvinBot commented May 26, 2026

MelvinBot commented May 12, 2026 •

edited

Loading

codecov Bot commented May 12, 2026 •

edited by github-actions Bot

Loading

sobitneupane commented May 19, 2026 •

edited

Loading