[Snyk] Security upgrade webpack-dev-server from 5.2.1 to 5.2.4#90343
[Snyk] Security upgrade webpack-dev-server from 5.2.1 to 5.2.4#90343MelvinBot wants to merge 1 commit into
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-WEBPACKDEVSERVER-16642067
|
@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87e4d47130
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "webpack-bundle-analyzer": "^4.5.0", | ||
| "webpack-cli": "^5.0.4", | ||
| "webpack-dev-server": "^5.2.1", | ||
| "webpack-dev-server": "^5.2.4", |
There was a problem hiding this comment.
Update lockfile alongside webpack-dev-server bump
This change updates package.json to webpack-dev-server@^5.2.4 but leaves package-lock.json pinned to ^5.2.1 (top-level dependency entry), which makes the dependency metadata inconsistent. In environments that use npm ci, this mismatch can fail installs, and in lockfile-driven installs the vulnerable version may remain in use, so the security fix is not reliably applied until the lockfile is regenerated and committed.
Useful? React with 👍 / 👎.
|
All CI failures are caused by
Fix: Run I was unable to run |
📲 Install BuildsAndroid
|
|
All CI failures (typecheck, tests, verify, build) are caused by the same root issue: The Fix: Run
|
|
🤖 All CI failures have the same root cause: To fix: Run git checkout snyk-fix-59e0b87ba9a96780670792112e126d4b
npm install
git add package-lock.json
git commit -m "Update package-lock.json for webpack-dev-server upgrade"
git pushI was unable to run |
|
All failing checks (typecheck, tests, verify, build) share the same root cause: The Snyk bot bumped Fix: Run I was unable to run |
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari