Skip to content

[Snyk] Security upgrade webpack-dev-server from 5.2.1 to 5.2.4#90343

Open
MelvinBot wants to merge 1 commit into
mainfrom
snyk-fix-59e0b87ba9a96780670792112e126d4b
Open

[Snyk] Security upgrade webpack-dev-server from 5.2.1 to 5.2.4#90343
MelvinBot wants to merge 1 commit into
mainfrom
snyk-fix-59e0b87ba9a96780670792112e126d4b

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

@MelvinBot MelvinBot commented May 12, 2026

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@MelvinBot MelvinBot requested a review from a team as a code owner May 12, 2026 13:43
@melvin-bot melvin-bot Bot requested review from srikarparsi and removed request for a team May 12, 2026 13:44
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 12, 2026

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87e4d47130

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread package.json
"webpack-bundle-analyzer": "^4.5.0",
"webpack-cli": "^5.0.4",
"webpack-dev-server": "^5.2.1",
"webpack-dev-server": "^5.2.4",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update lockfile alongside webpack-dev-server bump

This change updates package.json to webpack-dev-server@^5.2.4 but leaves package-lock.json pinned to ^5.2.1 (top-level dependency entry), which makes the dependency metadata inconsistent. In environments that use npm ci, this mismatch can fail installs, and in lockfile-driven installs the vulnerable version may remain in use, so the security fix is not reliably applied until the lockfile is regenerated and committed.

Useful? React with 👍 / 👎.

@MelvinBot
Copy link
Copy Markdown
Contributor Author

All CI failures are caused by package-lock.json being out of sync with the package.json change. The PR bumped webpack-dev-server from ^5.2.1 to ^5.2.4 but didn't regenerate the lockfile, so npm ci fails with errors like:

npm error Invalid: lock file's compression@1.7.4 does not satisfy compression@1.8.1

Fix: Run npm install --package-lock-only locally and push the updated package-lock.json.

I was unable to run npm install in my current environment to push the fix directly.

@sentry
Copy link
Copy Markdown

sentry Bot commented May 12, 2026

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
Expensify org.me.mobiexpensifyg 9.3.70-1 (509037001) Release

⚙️ app Build Distribution Settings

@MelvinBot
Copy link
Copy Markdown
Contributor Author

All CI failures (typecheck, tests, verify, build) are caused by the same root issue: package-lock.json was not updated to match the package.json change, so npm ci fails during setup.

The package.json bumps webpack-dev-server from ^5.2.1^5.2.4, but the lockfile still resolves 5.2.1. Version 5.2.4 changed several dependency ranges (notably selfsigned from ^2.4.1^5.5.0, compression ^1.7.4^1.8.1, http-proxy-middleware ^2.0.7^2.0.9), introducing many new transitive dependencies that are missing from the lockfile.

Fix: Run npm install locally and commit the updated package-lock.json. This will resolve all failing checks.

⚠️ I was unable to push this fix automatically because my execution environment does not permit running npm install.

@MelvinBot
Copy link
Copy Markdown
Contributor Author

🤖 All CI failures have the same root cause: package.json was updated (webpack-dev-server 5.2.1 → 5.2.4) but package-lock.json was not regenerated. CI runs npm ci, which requires the two files to be in sync.

To fix: Run npm install locally and commit the updated package-lock.json.

git checkout snyk-fix-59e0b87ba9a96780670792112e126d4b
npm install
git add package-lock.json
git commit -m "Update package-lock.json for webpack-dev-server upgrade"
git push

I was unable to run npm install in this environment due to permission restrictions.

@MelvinBot
Copy link
Copy Markdown
Contributor Author

All failing checks (typecheck, tests, verify, build) share the same root cause: package-lock.json is out of sync with package.json.

The Snyk bot bumped webpack-dev-server from 5.2.15.2.4 in package.json, but didn't regenerate package-lock.json. CI runs npm ci, which requires exact sync between the two files.

Fix: Run npm install --package-lock-only locally, then commit and push the updated package-lock.json.

I was unable to run npm install in my current environment due to permission restrictions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants