[No QA] Add Workspace Rooms page navigation under workspaceRoomsPage beta#90354
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
grgia
left a comment
grgia
left a comment
There was a problem hiding this comment.
ping me when you're ready for a build @sumo-slonik
sumo-slonik
force-pushed
the
kuba-nowakowski/feature/workspace-rooms-page-navigation
branch
3 times, most recently
from
1438cbf to
4ea966f
Compare
sumo-slonik
force-pushed
the
kuba-nowakowski/feature/workspace-rooms-page-navigation
branch
from
4ea966f to
4da6579
Compare
|
Hey @grgia, quick question for the Rooms page header, should I use the plain # (Hashtag) icon, or a colorfull iustration like Members/Categories headers have? If colorful, could you send it? |
|
@sumo-slonik it should be the hashtag icon illustration coloured to match the mocks |
Do you know where I can download this icon in high resolution? |
sumo-slonik
changed the title
| <ScreenWrapper | ||
| testID={WorkspaceRoomsPage.displayName} | ||
| style={[styles.defaultModalContainer]} | ||
| shouldEnableMaxHeight | ||
| > |
There was a problem hiding this comment.
i think we should add shouldShowOfflineIndicatorInWideScreen here, as well as enableEdgeToEdgeBottomSafeAreaPadding, like the rest of the workspace related pages do
| useFocusEffect( | ||
| useCallback(() => { | ||
| openWorkspaceRoomsPage(policyID); | ||
| }, [policyID]), | ||
| ); |
There was a problem hiding this comment.
useCallback() here might not be necessary, because we have react compiler
|
LGTM! Just some minor comments |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4da657908c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| useFocusEffect( | ||
| useCallback(() => { | ||
| openWorkspaceRoomsPage(policyID); |
There was a problem hiding this comment.
For users without the workspaceRoomsPage beta, opening /workspaces/<policyID>/rooms directly still mounts this screen and calls OpenWorkspaceRoomsPage; only the menu item is hidden in WorkspaceInitialPage. Since the issue explicitly makes this page beta-gated, the page itself should block non-beta users (and avoid firing the read command) rather than exposing the route via deep link/browser history.
Useful? React with 👍 / 👎.
| <Button | ||
| success | ||
| onPress={() => {}} | ||
| icon={icons.Plus} | ||
| text={translate('common.create')} | ||
| /> |
There was a problem hiding this comment.
When beta users open the new Rooms page, the visible Create button is wired to an empty handler, so pressing it appears broken and gives no navigation or feedback. Either connect this to the existing create-room flow described for the page or hide/disable the button until that flow exists.
Useful? React with 👍 / 👎.
|
I exported the #tag image from Figma, so it’s now ready for review and build. 
|
melvin-bot
Bot
requested review from
JmillsExpensify and
shubham1206agra
and removed request for
a team
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
sumo-slonik
force-pushed
the
kuba-nowakowski/feature/workspace-rooms-page-navigation
branch
from
7c4b85e to
adedffc
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: adedffc210
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| useFocusEffect(() => { | ||
| openWorkspaceRoomsPage(policyID); | ||
| }); |
There was a problem hiding this comment.
useFocusEffect is being passed an inline function, so while this screen is focused the effect is re-registered on every render and openWorkspaceRoomsPage(policyID) is called repeatedly. Any normal re-render trigger (Onyx updates, layout changes, permission changes) can therefore fire multiple redundant OpenWorkspaceRoomsPage reads instead of one per focus, which adds unnecessary API traffic and can cause noisy loading behavior.
Useful? React with 👍 / 👎.
|
@sumo-slonik Can you fix TS here? |
TS errors result from the fact that we're waiting here for the translation generation action to run. |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
grgia
left a comment
grgia
left a comment
There was a problem hiding this comment.
@sumo-slonik are you meant to have two issues in the fixed issues?
I triggered translations and test build
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index fdb762e2..80ecaa03 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -4334,6 +4334,7 @@ ${amount} für ${merchant} – ${date}`,
travelInvoicingVendor: 'Reiseanbieter',
travelInvoicingPayableAccount: 'Reiseverbindlichkeitskonto',
hr: 'Personalwesen',
+ rooms: 'Räume',
},
createdForClient: {
title: 'Du hast einen Workspace für deinen Kunden erstellt!',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 851d2392..6a1f8335 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -1687,10 +1687,8 @@ const translations: TranslationDeepObject<typeof en> = {
backdropLabel: 'Fondo del Modal',
},
nextStep: {
- /* eslint-disable @typescript-eslint/no-unused-vars */
message: {
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_ADD_TRANSACTIONS]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> añadas gastos.`;
@@ -1701,7 +1699,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_SUBMIT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> envíes los gastos.`;
@@ -1713,7 +1710,6 @@ const translations: TranslationDeepObject<typeof en> = {
},
[CONST.NEXT_STEP.MESSAGE_KEY.NO_FURTHER_ACTION]: (_actor, _actorType, _eta, _etaType) => `¡No se requiere ninguna acción adicional!`,
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_FOR_SUBMITTER_ACCOUNT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> añadas una cuenta bancaria.`;
@@ -1728,7 +1724,6 @@ const translations: TranslationDeepObject<typeof en> = {
if (eta) {
formattedETA = etaType === CONST.NEXT_STEP.ETA_TYPE.DATE_TIME ? ` el ${eta} de cada mes` : ` ${eta}`;
}
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que tus gastos se envíen automáticamente${formattedETA}.`;
@@ -1739,7 +1734,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_FIX_ISSUES]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> soluciones ellos problemas.`;
@@ -1750,7 +1744,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_APPROVE]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> apruebes los gastos.`;
@@ -1761,7 +1754,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_EXPORT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> exportes este informe.`;
@@ -1772,7 +1764,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_PAY]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> pagues los gastos.`;
@@ -1783,7 +1774,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_FOR_POLICY_BANK_ACCOUNT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> termines de configurar una cuenta bancaria de empresa.`;
@@ -1803,7 +1793,6 @@ const translations: TranslationDeepObject<typeof en> = {
[CONST.NEXT_STEP.MESSAGE_KEY.SUBMITTING_TO_SELF]: (_actor, _actorType, _eta, _etaType) =>
`¡Ups! Parece que estás enviando el informe a <strong>ti mismo</strong>. Aprobar tus propios informes está <strong>prohibido</strong> por tu espacio de trabajo. Por favor, envía este informe a otra persona o contacta a tu administrador para cambiar la persona a la que lo envías.`,
[CONST.NEXT_STEP.MESSAGE_KEY.REJECTED_REPORT]: (actor, actorType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Este informe fue rechazado. Esperando a que <strong>tú</strong> corrijas los problemas y lo vuelvas a enviar manualmente.`;
@@ -2458,7 +2447,6 @@ ${amount} para ${merchant} - ${date}`,
two: 'º',
few: 'º',
other: 'º',
- /* eslint-disable @typescript-eslint/naming-convention */
'1': 'Primero',
'2': 'Segundo',
'3': 'Tercero',
@@ -2469,7 +2457,6 @@ ${amount} para ${merchant} - ${date}`,
'8': 'Octavo',
'9': 'Noveno',
'10': 'Décimo',
- /* eslint-enable @typescript-eslint/naming-convention */
},
},
approverInMultipleWorkflows: 'Este miembro ya pertenece a otro flujo de aprobación. Cualquier actualización aquí se reflejará allí también.',
@@ -6931,7 +6918,6 @@ ${amount} para ${merchant} - ${date}`,
restrictedDescription: 'Sólo las personas en tu espacio de trabajo pueden encontrar esta sala',
privateDescription: 'Sólo las personas que están invitadas a esta sala pueden encontrarla',
publicDescription: 'Cualquier persona puede unirse a esta sala',
- // eslint-disable-next-line @typescript-eslint/naming-convention
public_announceDescription: 'Cualquier persona puede unirse a esta sala',
createRoom: 'Crea una sala de chat',
roomAlreadyExistsError: 'Ya existe una sala con este nombre',
@@ -6951,7 +6937,6 @@ ${amount} para ${merchant} - ${date}`,
restricted: 'Espacio de trabajo',
private: 'Privada',
public: 'Público',
- // eslint-disable-next-line @typescript-eslint/naming-convention
public_announce: 'Anuncio Público',
},
},
@@ -7266,7 +7251,6 @@ ${amount} para ${merchant} - ${date}`,
updatedDefaultTitle: (newDefaultTitle, oldDefaultTitle) => `cambió la fórmula personalizada del nombre del informe a "${newDefaultTitle}" (previamente "${oldDefaultTitle}")`,
updatedOwnership: (oldOwnerEmail, oldOwnerName, policyName) => `asumió la propiedad del espacio de trabajo ${policyName} de ${oldOwnerName} (${oldOwnerEmail})`,
updatedAutoHarvesting: (enabled) => `${enabled ? 'habilitó' : 'deshabilitó'} el envío programado`,
- // eslint-disable-next-line @typescript-eslint/max-params
updatedIndividualBudgetNotification: (
budgetAmount,
budgetFrequency,
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 055ebb27..188b1db8 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -4343,6 +4343,7 @@ ${amount} pour ${merchant} - ${date}`,
travelInvoicingVendor: 'Fournisseur de voyages',
travelInvoicingPayableAccount: 'Compte fournisseur déplacements',
hr: 'RH',
+ rooms: 'Salons',
},
createdForClient: {
title: 'Vous avez créé un espace de travail pour votre client !',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index ad13a9a3..42505a83 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -4320,6 +4320,7 @@ ${amount} per ${merchant} - ${date}`,
travelInvoicingVendor: 'Fornitore di viaggi',
travelInvoicingPayableAccount: 'Conto debiti per viaggi',
hr: 'Risorse umane',
+ rooms: 'Stanze',
},
createdForClient: {
title: 'Hai creato uno spazio di lavoro per il tuo cliente!',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index f9e27c2a..700d190b 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -4287,6 +4287,7 @@ ${integrationName === CONST.ONBOARDING_ACCOUNTING_MAPPING.other ? 'あなたの'
travelInvoicingVendor: '出張ベンダー',
travelInvoicingPayableAccount: '旅費未払金勘定',
hr: '人事',
+ rooms: 'ルーム',
},
createdForClient: {
title: 'クライアントのワークスペースを作成しました！',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 09452908..214910c9 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -4315,6 +4315,7 @@ ${amount} voor ${merchant} - ${date}`,
travelInvoicingVendor: 'Reisaanbieder',
travelInvoicingPayableAccount: 'Reiscrediteurenrekening',
hr: 'HR',
+ rooms: 'Kamers',
},
createdForClient: {
title: 'Je hebt een werkruimte voor je klant aangemaakt!',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index d8d87c25..ed9e738e 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -4308,6 +4308,7 @@ ${amount} dla ${merchant} - ${date}`,
travelInvoicingVendor: 'Dostawca usług turystycznych',
travelInvoicingPayableAccount: 'Konto zobowiązań z tytułu podróży',
hr: 'HR',
+ rooms: 'Pokoje',
},
createdForClient: {
title: 'Utworzyłeś przestrzeń roboczą dla swojego klienta!',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 110bed9e..3a598014 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -4310,6 +4310,7 @@ ${amount} para ${merchant} - ${date}`,
travelInvoicingVendor: 'Fornecedor de viagem',
travelInvoicingPayableAccount: 'Conta a pagar de viagens',
hr: 'RH',
+ rooms: 'Salas',
},
createdForClient: {
title: 'Você criou um espaço de trabalho para seu cliente!',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 4edd3b28..7cccd1df 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -4218,6 +4218,7 @@ ${amount}，商户：${merchant} - 日期：${date}`,
travelInvoicingVendor: '差旅供应商',
travelInvoicingPayableAccount: '差旅应付账户',
hr: '人力资源',
+ rooms: '房间',
},
createdForClient: {
title: '您已为客户创建了工作区！',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
This comment has been minimized.
This comment has been minimized.
fixed |
Reviewer Checklist
Screenshots/Videos
|
|
@sumo-slonik Fix conflicts and TS errors please. |
…-navigation # Conflicts: # Mobile-Expensify # src/CONST/index.ts
grgia
changed the title
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.3.76-0 🚀
|
|
I reviewed the changes in this PR and no help site updates are required. This PR adds a Workspace Rooms page that is gated behind the Help site documentation should be created once the Rooms feature is complete and publicly available. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.77-3 🚀
|
7 participants
QA NOTE:
This feature is under beta, NO QA required. No exploratory QA is needed until the feature is completed.
Explanation of Change
Adds a new Rooms entry to the workspace settings menu, gated behind the
workspaceRoomsPagebeta. Selecting it opens a newWorkspaceRoomsPage(currently a header-only placeholder) under the routeworkspaces/:policyID/rooms, registered in the Workspace split navigator and RHP relations. The page fires the newOpenWorkspaceRoomsPageread command on focus. Includes theroomstranslation key across all supported languages.Fixed Issues
$ #89595
PROPOSAL:
Tests
workspaceRoomsPagebeta enabled.#icon) appears in the menu.Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-05-13.at.17.03.27.mov