Skip to content

[No QA] Docs updates for E/A#90076 Add retract and reopen to Copilot limited access exclusions#90437

Merged
lschurr merged 1 commit into
mainfrom
claude-docsUpdateCopilotRetractRestriction
May 18, 2026
Merged

[No QA] Docs updates for E/A#90076 Add retract and reopen to Copilot limited access exclusions#90437
lschurr merged 1 commit into
mainfrom
claude-docsUpdateCopilotRetractRestriction

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Summary

  • Updates the Copilot Access help article to include retractions and reopens in the list of actions excluded for Limited Access Copilots.
  • This reflects the code changes in fix: Copilot with limited access level can retract expenses #90076, which added delegate access restriction checks to the Retract and Reopen actions in useLifecycleActions.tsx.

Changed file

  • docs/articles/new-expensify/settings/Copilot-Access.md — Updated the Limited Access description from "Excludes approvals, payments, rejections, and holds" to "Excludes approvals, payments, rejections, holds, retractions, and reopens."

… and reopens

The Limited Access Copilot description now reflects that retract and reopen
actions are also restricted, matching the code changes in E/A#90076.

Co-authored-by: Eskalifer1 <Eskalifer1@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label May 13, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#90076 Add retract and reopen to Copilot limited access exclusions [No QA] Docs updates for E/A#90076 Add retract and reopen to Copilot limited access exclusions May 13, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://64492eb7.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott stephanieelliott marked this pull request as ready for review May 15, 2026 02:12
@stephanieelliott stephanieelliott self-requested a review as a code owner May 15, 2026 02:12
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This is a minimal, targeted update that adds two items ("retractions, and reopens") to the Limited Access Copilot exclusion list, reflecting the code changes in PR #90076. The change is well-scoped and consistent with the existing style of the line it modifies.

Scores Summary

  • Readability: 10/10 - The updated list reads naturally with proper serial comma usage and parallel structure matching the existing items (approvals, payments, rejections, holds, retractions, and reopens).
  • AI Readiness: 10/10 - No structural changes were made; the article already has proper YAML frontmatter, task-based headings, and heading hierarchy. The added terms improve accuracy for AI retrieval by reflecting the actual product behavior.
  • Style Compliance: 9/10 - The noun forms "retractions" and "reopens" follow the same pattern as existing items in the list ("approvals," "payments," "rejections," "holds"), which are all noun forms of UI actions (Approve, Pay, etc.). This is consistent and appropriate for a descriptive list. One minor consideration: the UI labels are "Retract" and "Reopen report" -- the doc's noun forms are reasonable here, but confirming these terms match what users see in the Limited Access tooltip or description in the product would strengthen accuracy.

Key Findings

  • The change is additive and does not disrupt existing content or structure.
  • Parallel grammatical structure is maintained across the list.
  • The serial comma before "and reopens" follows standard convention.
  • No governance rule violations were introduced by this change.

Recommendations

  • Verify that "retractions" and "reopens" match the terminology users encounter in the product UI when viewing Copilot access level descriptions. If the UI uses different phrasing (e.g., "retract" and "reopen"), consider aligning more closely.
  • No other changes needed -- this is a clean, well-targeted update.

Files Reviewed

  • docs/articles/new-expensify/settings/Copilot-Access.md - One line updated to add retractions and reopens to the Limited Access exclusion list. No issues found.

@stephanieelliott stephanieelliott requested a review from a team May 15, 2026 04:11
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 15, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @lschurr

@melvin-bot melvin-bot Bot requested review from lschurr and removed request for a team May 15, 2026 04:11
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 15, 2026

@lschurr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@stephanieelliott stephanieelliott self-assigned this May 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This is a minimal, single-line change that adds "retractions, and reopens" to the list of actions excluded under Limited Access for Copilots. The change itself is accurate, clear, and well-formatted. Because the diff is so narrow, there is very little surface area to evaluate against governance rules — the modified line follows the existing pattern and reads naturally.

Scores Summary

  • Readability: 9/10 - The updated list item is clear, scannable, and follows the established bullet-point pattern. The comma-separated list reads naturally with proper Oxford comma usage.
  • AI Readiness: 9/10 - The change uses specific, descriptive feature terminology ("retractions," "reopens") that supports semantic search and retrieval. No metadata or heading changes were needed for this update.
  • Style Compliance: 9/10 - The added terms are consistent with the existing style of the bullet point. Formatting matches the surrounding content.

Key Findings

  • The proposed change is straightforward and correct — it extends an existing list with two new exclusion types using consistent language.
  • The terms "retractions" and "reopens" are clear action nouns that align with the feature behavior described in the PR title (retract and reopen actions).
  • No governance violations are introduced by this change.

Pre-existing file issues (not introduced by this PR, noted for awareness):

  • The YAML frontmatter is missing the required internalScope field per HELP_AUTHORING_GUIDELINES.md Section 3 and TEMPLATE.md.
  • The file uses multiple # headings beyond the title (e.g., # Add a Copilot, # Remove or Change a Copilot's Access), violating the "exactly one # heading" rule. These should be ## headings.
  • Several headings are not task-based as required (e.g., "Add a Copilot" should be "How to add a Copilot" or similar).
  • The file has no "How to..." heading, which is required per Section 6 of HELP_AUTHORING_GUIDELINES.md.
  • References to "three-dot menu" (in the unchanged Remove/Change section) should use the mandated format: "three dots (⋮)" per HELPSITE_NAMING_CONVENTIONS.md.
  • These are all pre-existing issues and are outside the scope of this PR's diff, but a follow-up cleanup would bring the article into full compliance.

Recommendations

  1. No changes needed for this PR — the diff is clean and correct.
  2. Consider a follow-up PR to address the pre-existing governance gaps listed above, particularly the missing internalScope metadata, heading hierarchy violations, and three-dot menu formatting.

Files Reviewed

  • docs/articles/new-expensify/settings/Copilot-Access.md — One-line update adding "retractions, and reopens" to Limited Access exclusions. Change is clean and compliant.

This review assessed only the proposed changes in the diff. Pre-existing file issues are flagged for awareness but did not affect scoring.

@lschurr lschurr merged commit c6bb58e into main May 18, 2026
27 checks passed
@lschurr lschurr deleted the claude-docsUpdateCopilotRetractRestriction branch May 18, 2026 16:47
@melvin-bot melvin-bot Bot added the Emergency label May 18, 2026
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 18, 2026

@lschurr looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a single, targeted change to the Copilot Access article: updating the Limited Access description to include two additional excluded actions ("retractions" and "reopens"). The change is factual and narrow in scope, keeping the article aligned with product behavior.

Scores Summary

  • Readability: 9/10 - The updated line reads naturally and maintains the existing list format with correct comma usage and an Oxford comma before "and reopens." Clear and scannable.
  • AI Readiness: 8/10 - The change itself is clean and does not degrade retrieval quality. The minor deduction is inherited from the existing article (e.g., some headings like "Add a Copilot" lack a "How to" prefix per Section 2 of the authoring guidelines, and the internalScope YAML field is missing per Section 3), but these are pre-existing issues outside the scope of this diff.
  • Style Compliance: 9/10 - The added terms follow the existing formatting pattern. Bold formatting on Limited Access is maintained. The terminology "retractions" and "reopens" should be verified against the exact UI labels to ensure compliance with the naming conventions (UI-exact terminology rule).

Key Findings

  • The change is well-scoped and does not introduce structural, formatting, or style regressions.
  • The added terms ("retractions" and "reopens") should be confirmed to match the exact terminology used in the product UI, per the Core UI Referencing Rules in HELPSITE_NAMING_CONVENTIONS.md. If the UI uses different phrasing (e.g., "Retract" and "Reopen" as action labels rather than noun forms), the article should mirror that exactly.
  • Pre-existing issues in the file (not introduced by this PR) include: missing internalScope in YAML frontmatter, non-task-based # headings such as "Add a Copilot" and "Switch to a Copilot Account," and use of the emoji note format rather than a standard callout. These are not attributable to this diff.

Recommendations

  1. Verify that "retractions" and "reopens" match the exact UI terminology shown in the product. If the UI uses verb forms (e.g., "Retract" / "Reopen"), consider adjusting to match (e.g., "retract and reopen actions" or the exact label).
  2. No structural changes are needed for this diff.

Files Reviewed

  • docs/articles/new-expensify/settings/Copilot-Access.md - Single line update to Limited Access description. Change is clean and appropriate.

This review assessed only the proposed changes in the diff, not pre-existing content.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/lschurr in version: 9.3.76-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.77-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Emergency HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants