83862 tags settings v2 by huult · Pull Request #90453 · Expensify/App

huult · 2026-05-13T09:40:01Z

Explanation of Change

Fixed Issues

$ #83862
PROPOSAL:

Tests

Same QA step

Verify that no errors appear in the JS console

Offline tests

QA Steps

SETTINGS_TAG_CREATE

Precondition: The workspace has tags enabled, but no tags have been imported or added yet.

Open Expensify.
Go to Workspace → Tags.
Update the URL from:
https://staging.new.expensify.com:8082/workspaces/74F19F3521623397/tags
to:
https://staging.new.expensify.com:8082/settings/74F19F3521623397/tags
to open the settings flow.
(change workspaces -> settings)
Click "Add Tag".
Verify that the Add Tag page opens and that navigation back works normally.

SETTINGS_TAGS_EDIT

Single level of tag:

Precondition: The workspace has tags enabled and contains at least one or multiple tags.

Open Expensify.
Go to Workspace → Tags.
Update the URL from:
https://staging.new.expensify.com:8082/workspaces/74F19F3521623397/tags
to:
https://staging.new.expensify.com:8082/settings/74F19F3521623397/tags
(change workspaces → settings) to open the settings flow.
Click More → Settings → Custom tag name.
Verify that the Custom Tag Name page opens and that navigation back works normally.

Multiple level tags:

Precondition: The workspace has tags enabled and contains multiple tags.

Open Expensify.
Go to Workspace → Tags.
Update the URL from:
https://staging.new.expensify.com:8082/workspaces/74F19F3521623397/tags
to:
https://staging.new.expensify.com:8082/settings/74F19F3521623397/tags
(change workspaces → settings) to open the settings flow.
Open any tags -> Custom tag name
Verify that the Custom Tag Name page opens and that navigation back works normally.

SETTINGS_TAG_SETTINGS

Precondition: The workspace has tags enabled and contains at least one or multiple tags.

Open Expensify.
Go to Workspace → Tags.
Update the URL from:
https://staging.new.expensify.com:8082/workspaces/74F19F3521623397/tags
to:
https://staging.new.expensify.com:8082/settings/74F19F3521623397/tags
(change workspaces → settings) to open the settings flow.
Open any tag.
Verify that the tag details page opens and that navigation back works normally.

SETTINGS_TAG_EDIT

Precondition: The workspace has tags enabled and contains at least one or multiple tags.

Open Expensify.
Go to Workspace → Tags.
Update the URL from:
https://staging.new.expensify.com:8082/workspaces/74F19F3521623397/tags
to:
https://staging.new.expensify.com:8082/settings/74F19F3521623397/tags
(change workspaces → settings) to open the settings flow.
Open any tag -> Name.
Verify that the Edit tag page opens and that navigation back works normally.

SETTINGS_TAG_GL_CODE

Precondition: The workspace has tags enabled and contains at least one or multiple tags.

Open Expensify.
Go to Workspace → Tags.
Update the URL from:
https://staging.new.expensify.com:8082/workspaces/74F19F3521623397/tags
to:
https://staging.new.expensify.com:8082/settings/74F19F3521623397/tags
(change workspaces → settings) to open the settings flow.
Open any tag -> GL code.
Verify that the GL code page opens and that navigation back works normally.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-05-05.at.15.41.28.mov

melvin-bot · 2026-05-13T09:40:10Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-05-13T09:49:03Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`76.92% <ø> (ø)`
...pages/workspace/tags/WorkspaceTagsSettingsPage.tsx	`0.00% <0.00%> (ø)`
src/pages/workspace/tags/WorkspaceViewTagsPage.tsx	`0.00% <0.00%> (ø)`
src/pages/workspace/tags/WorkspaceTagsPage.tsx	`47.32% <0.00%> (-0.14%)`	⬇️
src/ROUTES.ts	`17.72% <0.00%> (+0.06%)`	⬆️
src/pages/workspace/tags/TagGLCodePage.tsx	`0.00% <0.00%> (ø)`
...gation/AppNavigator/ModalStackNavigators/index.tsx	`6.74% <0.00%> (ø)`
...rc/pages/workspace/tags/WorkspaceCreateTagPage.tsx	`0.00% <0.00%> (ø)`
src/pages/workspace/tags/TagSettingsPage.tsx	`0.00% <0.00%> (ø)`
... and 2 more
... and 7 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 182446c9ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

huult · 2026-05-15T14:33:54Z

@mananjadhav This PR is ready for review

mananjadhav

Left 2 small comments.

mananjadhav · 2026-05-17T14:09:46Z

        entryScreens: [SCREENS.SETTINGS_TAGS.SETTINGS_TAGS_ROOT],
        getRoute: (orderWeight: number) => `tag-list/${orderWeight}`,
    },
+    SETTINGS_TAG_SETTINGS: {


Don't we need the OldRoute mapping?

@mananjadhav I’m not sure when we should update the route to the old route. In all migration cases where we change the route path, do we always update it to the old route, or are there cases where we actually need to set an oldRoute?

I think @mjasikowski would be better to answer. My thoughts are if the links are sent over chat then having the migration mapping really helps.

In general, mappings should be made for all migrated routes that differ from the static ones. While in some cases it might be impossible, it's better to do it in this specific case, as there shouldn't be any mapping issues here 😄

I checked, and this mapping works correctly: /settings/*/tag/*/*': '/settings/$1/tags/tag-settings/$2/$3.

Also, please check if the migrated routes differ from the static ones elsewhere in this PR, and if so, try to add mappings for them too 🙌

mananjadhav · 2026-05-17T19:09:24Z

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

web-settings-tags.mov

mananjadhav · 2026-05-18T07:48:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

mananjadhav

Completed the checklist with the screencasts updated earlier. One comment here before merging.

huult added 3 commits May 13, 2026 15:28

migrate SETTINGS_TAGS_EDIT

56bebca

migrate tags settings

4edbb23

remove type unused

182446c

huult requested review from a team as code owners May 13, 2026 09:40

melvin-bot Bot assigned huult May 13, 2026

melvin-bot Bot requested review from heyjennahay and mananjadhav and removed request for a team May 13, 2026 09:40

chatgpt-codex-connector Bot reviewed May 13, 2026

View reviewed changes

Comment thread src/ROUTES.ts

huult added 3 commits May 14, 2026 13:00

Merge remote-tracking branch 'upstream/main' into 83862-tags-settings-v2

70dc030

Merge remote-tracking branch 'upstream/main' into 83862-tags-settings-v2

a5e76f8

update eslint

e203c87

huult force-pushed the 83862-tags-settings-v2 branch from 24cfed8 to e203c87 Compare May 15, 2026 14:32

Merge remote-tracking branch 'upstream/main' into 83862-tags-settings-v2

94c6332

mananjadhav reviewed May 17, 2026

View reviewed changes

huult added 2 commits May 18, 2026 11:44

Merge remote-tracking branch 'upstream/main' into 83862-tags-settings-v2

0f51d48

updat testID

297ac3c

mananjadhav approved these changes May 18, 2026

View reviewed changes

melvin-bot Bot requested a review from mjasikowski May 18, 2026 07:49

Conversation

huult commented May 13, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 13, 2026

Uh oh!

codecov Bot commented May 13, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

huult commented May 15, 2026

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mananjadhav May 17, 2026

Choose a reason for hiding this comment

Uh oh!

huult May 18, 2026

Choose a reason for hiding this comment

Uh oh!

mananjadhav May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

collectioneur May 18, 2026

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented May 17, 2026

Screenshots/Videos

Uh oh!

mananjadhav commented May 18, 2026

Reviewer Checklist

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented May 13, 2026 •

edited by github-actions Bot

Loading

mananjadhav May 18, 2026 •

edited

Loading